New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788928 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Launcher-Tech-Debt


Sign in to add a comment

Convert Launcher Dismiss animation to ThreadedTransformTransition animation

Project Member Reported by wutao@chromium.org, Nov 27 2017

Issue description

Currently Launcher Dismiss animation is using SetBounds(), which will call SetBoundsFromAnimation on each OnProgress. Although there is no bound size change during the animation, there is overhead to update animation from ash/views and do a whole commit every frame.

Converting to ThreadedTransformTransition can let compositor optimize and accelerate the animation.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b40551330cff4baae0e3101e00fdbe6cc20ee08

commit 9b40551330cff4baae0e3101e00fdbe6cc20ee08
Author: wutao <wutao@chromium.org>
Date: Tue Nov 28 00:52:45 2017

cros: Use transform animation for Launcher dismiss animation.

Currently Launcher dismiss animation is using SetBounds, which will call
SetBoundsFromAnimation on each OnProgress. This will generate additional
overhead with a whole commit every frame. This cl converts it to use
ThreadedTransformTransition, which will let compositor optimize and
accelerate the animation.

Eve with DCHECK build, improved average smoothness from 84% to 99%.

Bug:  788928 
Test: 
Change-Id: I10a3fcb8c2895d71bf262b30c72b9f67fd0634ea
Reviewed-on: https://chromium-review.googlesource.com/792001
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519491}
[modify] https://crrev.com/9b40551330cff4baae0e3101e00fdbe6cc20ee08/ui/app_list/presenter/app_list_presenter_impl.cc

Comment 2 by vadimt@chromium.org, Nov 28 2017

Labels: Touch-Friendly-Launcher-Triaged

Comment 3 by wutao@chromium.org, Mar 15 2018

Status: Fixed (was: Available)

Sign in to add a comment