VR: Go to DD Home rather than DOFF for 'X' button shown by WebVR timeout |
||||
Issue descriptionWhen browsing is disabled and we detect that a WebVR page is failing to produce frames, we show some UX that provides and 'X' button for the user to exit presentation. For CCTs/WebAPKs/Samsung devices that run into this case, we should make the 'X' button take the user to DD home as they cannot return to Browsing mode.
,
Jan 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a1d3c5ec4b916f3007a933812da0fd074f0ef3c commit 6a1d3c5ec4b916f3007a933812da0fd074f0ef3c Author: Michael Thiessen <mthiesse@chromium.org> Date: Tue Jan 16 20:39:28 2018 VR: Return to DD home rather when exiting WebVR with browsing disabled If VR browsing is disabled and the pages requests to exit WebVR, we should return the user to DD home rather than asking them to take their headset off. Bug: 788910 Change-Id: I0c5dc00af871c04744b8b0b27769281bb515b480 Reviewed-on: https://chromium-review.googlesource.com/868236 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#529498} [modify] https://crrev.com/6a1d3c5ec4b916f3007a933812da0fd074f0ef3c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/6a1d3c5ec4b916f3007a933812da0fd074f0ef3c/chrome/browser/android/vr_shell/vr_shell_delegate.cc
,
Jan 16 2018
,
Feb 7 2018
,
Mar 13 2018
Verified on build 66.0.3359.28. Test case "VR fails, returns to DayDream Home" in "WebVR Manual Testing Plan" |
||||
►
Sign in to add a comment |
||||
Comment 1 by mthiesse@chromium.org
, Dec 5 2017