New issue
Advanced search Search tips

Issue 788900 link

Starred by 1 user
Status: Fixed
Owner:
dougarnett@chromium.org
Closed: Nov 2017
Cc:
sophiechang@chromium.org
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Crash in PreviewsOptimizationGuide::Hints::IsWhitelisted if component not loaded

Project Member Reported by dougarnett@chromium.org, Nov 27 2017 
Consistently crashes in url_matcher_.MatchURL(url) call until component is downloaded.

Comment 1 by dougarnett@chromium.org, Nov 27 2017 

backtrace has:

11-27 14:05:51.889 F/DEBUG   (18075):     #00 pc 0000992a  /data/app/org.chromium.chrome-1/lib/arm/liburl_matcher.cr.so (_ZNK11url_matcher19SubstringSetMatcher7IsEmptyEv+3)
11-27 14:05:51.889 F/DEBUG   (18075):     #01 pc 0000d28d  /data/app/org.chromium.chrome-1/lib/arm/liburl_matcher.cr.so (_ZNK11url_matcher10URLMatcher8MatchURLERK4GURL+40)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9a4dca651496927ad2c1575f49648aa0259efdf

commit b9a4dca651496927ad2c1575f49648aa0259efdf
Author: Doug Arnett <dougarnett@chromium.org>
Date: Tue Nov 28 18:22:13 2017

Fix crash in optmization guide if no hints configured


Bug:  788900 
Change-Id: Ia15c1712bc894b2c69920d37192c75b47dc67fbe
Reviewed-on: https://chromium-review.googlesource.com/794170
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519749}
[modify] https://crrev.com/b9a4dca651496927ad2c1575f49648aa0259efdf/components/previews/content/previews_optimization_guide.cc
[modify] https://crrev.com/b9a4dca651496927ad2c1575f49648aa0259efdf/components/previews/content/previews_optimization_guide_unittest.cc

Comment 3 by dougarnett@chromium.org, Nov 28 2017

Status: Fixed (was: Assigned)

Comment 4 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 5 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
►

Sign in to add a comment