New issue
Advanced search Search tips

Issue 788894 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

inline bug form needs email autocomplete

Project Member Reported by seanmccullough@chromium.org, Nov 27 2017

Issue description

This works on monorail, and is very useful so people don't have to remember or type out email addresses.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3d17e151c1f4578ef56f198e0af6315b3eb08c03

commit 3d17e151c1f4578ef56f198e0af6315b3eb08c03
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Tue Nov 28 22:46:03 2017

Add autocomplete UI for cc: field in bug form.

Demo here: https://12975-4521a54-tainted-seanmcculloug-dot-sheriff-o-matic-staging.appspot.com/chromium

I'm not sure why the cc field is now the entire width of the dialog
(no more padding, unlike the other paper-input elements, it seems).

This also fixed an issue where selection clicks in the user suggestions
menu were looping back to fire toggle calls that would re-open the menu.

Bug:  788894 
Change-Id: Iea5cb29c0236037eb0534a2cdd68096b9f4111b9
Reviewed-on: https://chromium-review.googlesource.com/792349
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>

[modify] https://crrev.com/3d17e151c1f4578ef56f198e0af6315b3eb08c03/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-file-bug.html
[modify] https://crrev.com/3d17e151c1f4578ef56f198e0af6315b3eb08c03/crdx/chopsui/crdx-user-input.html
[modify] https://crrev.com/3d17e151c1f4578ef56f198e0af6315b3eb08c03/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-file-bug.js

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4f09c9256b11bf570725ed7fe1c4977bdb5b8e31

commit 4f09c9256b11bf570725ed7fe1c4977bdb5b8e31
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Wed Nov 29 01:19:33 2017

[som] Fix some text entry issues with email autocomplete

Bug:  788894 
Change-Id: Ide4721fbd008922aeafa87c3fcf6992b3d57a778
Reviewed-on: https://chromium-review.googlesource.com/795370
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/4f09c9256b11bf570725ed7fe1c4977bdb5b8e31/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-file-bug.js

Status: Fixed (was: Assigned)

Sign in to add a comment