New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788892 link

Starred by 1 user
Status: Fixed
Owner:
█ robert...@chromium.org
Last visit > 30 days ago
Closed: Aug 6
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Raise assertions if raw & direct https are made

Project Member Reported by st...@chromium.org, Nov 27 2017 
For quite a few times, Findit unittests failed or flaked because http requests were not mocked.

It's better to have a different mechanism to always fail the tests if raw http requests are made.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/866f8be3a6509579a418685a0134ed4f277adb79

commit 866f8be3a6509579a418685a0134ed4f277adb79
Author: Roberto Carrillo <robertocn@google.com>
Date: Tue Nov 28 23:34:43 2017

[Findit] Mock urlfetch on testcase to stop tests using http.

Any calls to google.appengine.api.urlfetch.fetch should now raise an
assertion when called from test suite derived from this class.

Most suites in findit are derived from this, the rest are mostly derived
from testing_utils.AppEngineTestcase which will be addressed in a
separate patch.

R=stgao,chanli
BUG= 788892 

Change-Id: I29e1d4533e2ffe60ca17e8f6900eedc618f5ef68
Reviewed-on: https://chromium-review.googlesource.com/794173
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/866f8be3a6509579a418685a0134ed4f277adb79/appengine/findit/waterfall/test/wf_testcase.py

Comment 2 by st...@chromium.org, Aug 6

Owner: robert...@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment