New issue
Advanced search Search tips

Issue 788883 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

error: 'NR_TLB_REMOTE_FLUSH_RECEIVED' undeclared and other errors

Project Member Reported by groeck@chromium.org, Nov 27 2017

Issue description

Reported by 0day:

arch/x86/mm/tlb.c:246:17: error: 'NR_TLB_REMOTE_FLUSH_RECEIVED' undeclared (first use in this function) 
arch/x86/mm/tlb.c:246:21: error: 'NR_TLB_REMOTE_FLUSH_RECEIVED' undeclared (first use in this function) 
arch/x86/mm/tlb.c:277:17: error: 'NR_TLB_REMOTE_FLUSH' undeclared (first use in this function) 
arch/x86/mm/tlb.c:277:21: error: 'NR_TLB_REMOTE_FLUSH' undeclared (first use in this function)

Side effect of Kaiser patches; incomplete backport.

 
Uh sorry about that. What compilation mode is this happening in? Why didn't we catch it in bots?

Comment 2 by groeck@chromium.org, Nov 27 2017

See CL:791912; this is only a problem in test builds. Nothing to be concerned about for release images.

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28 2017

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/7a402717756fb48a9d603e3d3da4bc765bc7b5c6

commit 7a402717756fb48a9d603e3d3da4bc765bc7b5c6
Author: Andy Lutomirski <luto@kernel.org>
Date: Tue Nov 28 18:22:28 2017

UPSTREAM: mm/vmstat: Make NR_TLB_REMOTE_FLUSH_RECEIVED available even on UP

This fixes CONFIG_SMP=n, CONFIG_DEBUG_TLBFLUSH=y without introducing
further #ifdef soup.  Caught by a Kbuild bot randconfig build.

BUG= chromium:788883 
TEST=Build and run

Change-Id: Id3d52f66955414057a9098378ac1557593ef5079
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: ce4a4e565f52 ("x86/mm: Remove the UP asm/tlbflush.h code, always use the (formerly) SMP code")
Link: http://lkml.kernel.org/r/76da9a3cc4415996f2ad2c905b93414add322021.1496673616.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit 5dd0b16cdaff9b94da06074d5888b03235c0bf17)
Reviewed-on: https://chromium-review.googlesource.com/791912
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/7a402717756fb48a9d603e3d3da4bc765bc7b5c6/include/linux/vm_event_item.h

Comment 4 by groeck@chromium.org, Nov 30 2017

Status: Fixed (was: Started)

Sign in to add a comment