New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788881 link

Starred by 1 user
Status: Fixed
Owner:
█ zakerinasab@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
█ junov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Use SkImageInfo::minRowBytes() in SkImage::readPixels()

Project Member Reported by zakerinasab@chromium.org, Nov 27 2017 
Instead of multiplying the width of the expected pixel array to the number of
bytes per pixel, use SkImageInfo::minRowBytes(). This helps code health by
making sure the row bytes matches the passed SkImageInfo paramater.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a522f9e1662c2072a3a4cc88733d287c25a7023

commit 5a522f9e1662c2072a3a4cc88733d287c25a7023
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Tue Nov 28 18:25:37 2017

Minor code health improvements in ImageBitmap and ImageBuffer

This CL contains minor changes in ImageBitmap and ImageBuffer to:

- use blending in SkCanvas::drawImage() only if needed
- fix ImageBitmap->CopyImageData() behavior to match the signature
- use SkImageInfo::minRowBytes() in SkImage::readPixels() call sites

Bug:  785313 , 788879 , 788881 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1473fc71ce1785f87c0f3e47441515f6cd3dd7a7
Reviewed-on: https://chromium-review.googlesource.com/793951
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519755}
[modify] https://crrev.com/5a522f9e1662c2072a3a4cc88733d287c25a7023/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
[modify] https://crrev.com/5a522f9e1662c2072a3a4cc88733d287c25a7023/third_party/WebKit/Source/core/imagebitmap/ImageBitmapTest.cpp
[modify] https://crrev.com/5a522f9e1662c2072a3a4cc88733d287c25a7023/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp

Comment 2 by zakerinasab@chromium.org, Nov 28 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment