New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788872 link

Starred by 1 user
Status: Fixed
Owner:
█ thanhdle@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
tbansal@chromium.org
ryansturm@chromium.org
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Display checked decisions on chrome://interventions internals

Project Member Reported by thanhdle@chromium.org, Nov 27 2017 
Right now, the log only shows why certain preview is shown, but does not give any info on which checks passed and failed during the decision making process. For example, when the decision was made to not show a preview because the network quality was unavailable, the log does not include the checked that passed leading up to that decision, such as that the hostost is NOT blacklisted, and the user is NOT blacklisted.

Details: https://docs.google.com/document/d/1i7_1VkjJ2x86BXWocK4ZuEVq_DzdYRslt2ihJ2UdlZk
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9960c154b9c0a55c919780f751114ff42e748d3a

commit 9960c154b9c0a55c919780f751114ff42e748d3a
Author: Thanh Le <thanhdle@chromium.org>
Date: Mon Dec 04 20:49:38 2017

Add positive event logs to chrome://interventions-internals.

Design doc:
https://docs.google.com/document/d/1i7_1VkjJ2x86BXWocK4ZuEVq_DzdYRslt2ihJ2UdlZk

Screenshot: https://drive.google.com/a/chromium.org/file/d/1qGcgcNF3vCjb0cjkkrO_Sox9OEOSQtXo

Bug:  788872 
Change-Id: Ib09a31a3914aa9b244e9e6117e1cc501a102e82c
Reviewed-on: https://chromium-review.googlesource.com/791910
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521440}
[modify] https://crrev.com/9960c154b9c0a55c919780f751114ff42e748d3a/components/previews/content/previews_io_data.cc
[modify] https://crrev.com/9960c154b9c0a55c919780f751114ff42e748d3a/components/previews/content/previews_io_data.h
[modify] https://crrev.com/9960c154b9c0a55c919780f751114ff42e748d3a/components/previews/content/previews_io_data_unittest.cc
[modify] https://crrev.com/9960c154b9c0a55c919780f751114ff42e748d3a/components/previews/content/previews_ui_service.cc
[modify] https://crrev.com/9960c154b9c0a55c919780f751114ff42e748d3a/components/previews/content/previews_ui_service.h
[modify] https://crrev.com/9960c154b9c0a55c919780f751114ff42e748d3a/components/previews/content/previews_ui_service_unittest.cc
[modify] https://crrev.com/9960c154b9c0a55c919780f751114ff42e748d3a/components/previews/core/previews_black_list.cc
[modify] https://crrev.com/9960c154b9c0a55c919780f751114ff42e748d3a/components/previews/core/previews_black_list.h
[modify] https://crrev.com/9960c154b9c0a55c919780f751114ff42e748d3a/components/previews/core/previews_black_list_unittest.cc
[modify] https://crrev.com/9960c154b9c0a55c919780f751114ff42e748d3a/components/previews/core/previews_logger.cc
[modify] https://crrev.com/9960c154b9c0a55c919780f751114ff42e748d3a/components/previews/core/previews_logger.h
[modify] https://crrev.com/9960c154b9c0a55c919780f751114ff42e748d3a/components/previews/core/previews_logger_unittest.cc

Comment 2 by thanhdle@chromium.org, Dec 4 2017

Status: Fixed (was: Started)

Comment 3 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 4 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
►

Sign in to add a comment