Issue metadata
Sign in to add a comment
|
OneShotAccessibilityTreeSearchTest.VisibleOnly content_unittest fails in windows, mac and linux official builder. |
||||||||||||||||||||||||
Issue descriptionBelow mentioned content_unittest is flaky in Win, Mac and Linux official.desktop builder. OneShotAccessibilityTreeSearchTest.VisibleOnly Link to the Builder =================== https://uberchromegw.corp.google.com/i/official.desktop/builders/linux64/builds/827 https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/2404 Link to the log file ==================== https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fmac64%2F2404%2F%2B%2Frecipes%2Fsteps%2Fcontent_unittests%2F0%2Fstdout Error Log ========== [ RUN ] OneShotAccessibilityTreeSearchTest.VisibleOnly ../../content/browser/accessibility/one_shot_accessibility_tree_search_unittest.cc:193: Failure Expected: 5U Which is: 5 To be equal to: search.CountMatches() Which is: 6 [ FAILED ] OneShotAccessibilityTreeSearchTest.VisibleOnly (2 ms) [46/5426] OneShotAccessibilityTreeSearchTest.VisibleOnly (2 ms) Not sure when the test started to fail, but loops back to a CL which was committed long back. https://chromium.googlesource.com/chromium/src/+/249d06319dae095b7cc5fbd6ffd37a2e83083838 Assigning to Dominic for further updates.
,
Nov 29 2017
Apologize for that this would have caused due to the CL : https://chromium.googlesource.com/chromium/src/+/735d8176443d7d16488b8b9efa73477a91fea5d2
,
Nov 29 2017
This is on m63 branch? Assigning to katie@. I think this is related to the revert of your change for clipping. I would suggest disabling the test on m63.
,
Nov 29 2017
I've sent a change out for review at https://chromium-review.googlesource.com/c/chromium/src/+/798053
,
Nov 29 2017
This passes locally at HEAD without disabling the test, by the way.
,
Nov 29 2017
Here's a Chrome 63 only version: https://chromium-review.googlesource.com/c/chromium/src/+/798117
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d367a74b10a8ab3e6842b6babaf60f2962ff0167 commit d367a74b10a8ab3e6842b6babaf60f2962ff0167 Author: Katie Dektar <katydek@google.com> Date: Wed Nov 29 23:21:39 2017 Fix test failures in Chrome 63 by removing offscreen tests. TBR:katie@chromium.org,dtseng@chromium.org Bug: 789425, 788853 , 786164 Change-Id: I5ab250b3268e01064050779908ea1eb017bd643e Reviewed-on: https://chromium-review.googlesource.com/798117 Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#613} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/d367a74b10a8ab3e6842b6babaf60f2962ff0167/content/browser/accessibility/dump_accessibility_tree_browsertest.cc [modify] https://crrev.com/d367a74b10a8ab3e6842b6babaf60f2962ff0167/content/browser/accessibility/one_shot_accessibility_tree_search_unittest.cc
,
Nov 29 2017
This should be fixed now in 63. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by pbomm...@chromium.org
, Nov 29 2017Labels: M-63
Owner: p...@chromium.org