New issue
Advanced search Search tips

Issue 788846 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove WebNonCopyable

Project Member Reported by slangley@chromium.org, Nov 27 2017

Issue description

Remove public/platform/WebNonCopyable.h, it seems pointless.

The handful of classes that use it can just =default the copy and assignment operators if we don't want to use DISALLOW_COPY_AND_ASSIGN.
 
s/=default/=delete/
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/054b56e5e39800e6c99121da4d42b61727bd67fc

commit 054b56e5e39800e6c99121da4d42b61727bd67fc
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Nov 28 02:04:41 2017

Remove WebNonCopyable and replace any usage with explicit "= delete".

In the few use cases that were using WebNonCopyable I followed the Google
C++ style guide, which explicitly states that to remove copy
operations "explicitly disable them using = delete in the public: section".
https://google.github.io/styleguide/cppguide.html#Copyable_Movable_Types

Most places were just including the header file without actually using
the type.

This CL contains no logic changes.

Bug:  788846 
Change-Id: I991e4b9b548f67a41d79882723525a97f3625432
Reviewed-on: https://chromium-review.googlesource.com/792190
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519522}
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/content/shell/test_runner/test_interfaces.h
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/third_party/WebKit/public/platform/UserMetricsAction.h
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/third_party/WebKit/public/platform/WebBlobData.h
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/third_party/WebKit/public/platform/WebCORSPreflightResultCache.h
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/third_party/WebKit/public/platform/WebHTTPBody.h
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/third_party/WebKit/public/platform/WebMediaConstraints.h
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/third_party/WebKit/public/platform/WebMediaDeviceInfo.h
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/third_party/WebKit/public/platform/WebMediaStream.h
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/third_party/WebKit/public/platform/WebMediaStreamSource.h
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/third_party/WebKit/public/platform/WebMediaStreamTrack.h
[delete] https://crrev.com/fe20f163c38329642111dc2f965d20d73b784395/third_party/WebKit/public/platform/WebNonCopyable.h
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/third_party/WebKit/public/platform/WebRTCSessionDescription.h
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/third_party/WebKit/public/platform/WebRTCSessionDescriptionRequest.h
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/third_party/WebKit/public/platform/WebRTCVoidRequest.h
[modify] https://crrev.com/054b56e5e39800e6c99121da4d42b61727bd67fc/third_party/WebKit/public/web/WebImageDecoder.h

Status: Fixed (was: Started)

Sign in to add a comment