CWS doesn't work with --isolate-origins=https://google.com |
|||||||
Issue descriptionChrome Version: 64.0.3278.0 OS: Win10 What steps will reproduce the problem? (1) Start Chrome with --isolate-origins=https://google.com (2) Visit https://chrome.google.com/webstore What is the expected result? The navigation succeeds and you're able to install extensions/ What happens instead? The navigation never completes. This may be because the isolated origins logic is taking precedence over the CWS process isolation? Maybe we can fix in a similar way as the remote NTP in issue 755595 ?
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca171375eb03132a47f1a986343f77be726c5511 commit ca171375eb03132a47f1a986343f77be726c5511 Author: Alex Moshchuk <alexmos@chromium.org> Date: Tue Nov 28 16:11:31 2017 Fix Chrome Web Store loading in an isolated origin. When a hosted app URL also corresponds to an isolated origin, the isolated origin takes precedence, and the corresponding SiteInstance won't use the effective URL for the hosted app. However, this logic needs to exclude CWS, which still needs to resolve to its effective URL, so that the corresponding process ends up in the ProcessMap for the CWS extension ID. Otherwise, security checks such as CanCommitURL won't allow CWS navigations to succeed. Bug: 788837 Change-Id: I2b8d03d044e72bb9b8f71cb4c3accfba8d907ac4 Reviewed-on: https://chromium-review.googlesource.com/792596 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#519701} [modify] https://crrev.com/ca171375eb03132a47f1a986343f77be726c5511/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/ca171375eb03132a47f1a986343f77be726c5511/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc [modify] https://crrev.com/ca171375eb03132a47f1a986343f77be726c5511/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h [modify] https://crrev.com/ca171375eb03132a47f1a986343f77be726c5511/chrome/browser/extensions/process_management_browsertest.cc
,
Nov 28 2017
,
Nov 29 2017
I've just verified that this is fixed in Mac Canary 64.0.3280.0 - I verified that I can load CWS with --isolate-origins=https://google.com/ and successfully install an extension. Requesting merge of r519701 to M63, as this is a blocker for issue 760761 , which needs to go into M63. Note that this will need to be merged together with the fix for issue 755595 , which a similarly important blocker for issue 760761 , so I'll also request a merge there. Both are fairly short fixes and should be safe to merge.
,
Nov 29 2017
Actually adding the label this time.
,
Nov 29 2017
This bug requires manual review: We are only 5 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 29 2017
Just to give a bit more detail on #4: - The fixed codepaths only affect users of the --isolate-origins flag (and in particular specifying https://google.com/ or other URLs corresponding to remote NTP), which nobody should be using right now, so extra coverage on dev/beta wouldn't help. - The fixes are small and well-contained, so should be low-risk. - The issues fixed are deal-breakers for specifying a subset of isolated sites via enterprise policy ( issue 760761 ). If the isolated origins policy includes https://google.com, not having those fixes would break the NTP and Chrome Web Store for everyone. Issue 760761 is targeted for M63.
,
Nov 29 2017
Approving merges listed at #4 to M63 branch 3239 based on comments #4, #7 and per offline chat with alexmos@ & creis@.
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ce7b41db04249696760719f95c2ede605095147 commit 9ce7b41db04249696760719f95c2ede605095147 Author: Alex Moshchuk <alexmos@chromium.org> Date: Wed Nov 29 23:13:39 2017 Fix Chrome Web Store loading in an isolated origin. (Merge to M63) When a hosted app URL also corresponds to an isolated origin, the isolated origin takes precedence, and the corresponding SiteInstance won't use the effective URL for the hosted app. However, this logic needs to exclude CWS, which still needs to resolve to its effective URL, so that the corresponding process ends up in the ProcessMap for the CWS extension ID. Otherwise, security checks such as CanCommitURL won't allow CWS navigations to succeed. TBR=alexmos@chromium.org (cherry picked from commit ca171375eb03132a47f1a986343f77be726c5511) Bug: 788837 Change-Id: I2b8d03d044e72bb9b8f71cb4c3accfba8d907ac4 Reviewed-on: https://chromium-review.googlesource.com/792596 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#519701} Reviewed-on: https://chromium-review.googlesource.com/798221 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#612} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/9ce7b41db04249696760719f95c2ede605095147/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/9ce7b41db04249696760719f95c2ede605095147/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc [modify] https://crrev.com/9ce7b41db04249696760719f95c2ede605095147/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h [modify] https://crrev.com/9ce7b41db04249696760719f95c2ede605095147/chrome/browser/extensions/process_management_browsertest.cc
,
Nov 29 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by alex...@chromium.org
, Nov 28 2017Status: Started (was: Assigned)