New issue
Advanced search Search tips

Issue 788828 link

Starred by 1 user
Status: Fixed
Owner:
hirosh...@chromium.org
Closed: Feb 2018
Cc:
kouhei@chromium.org
neis@chromium.org
hirosh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove ScriptResource from bindings/core/v8

Project Member Reported by hirosh...@chromium.org, Nov 27 2017 
The interfaces for compilation/evaluation/etc. in bindings/core/v8 should be:
- ScriptSourceCode/ScriptModule
- CachedMetadataHandler
and bindings/core/v8 shouldn't use ScriptResource (especially in classic scripts),
- To avoid unnecessary dependencies to ScriptResource, especially to prevent V8-side from being unnecessary affected by revalidation on MemoryCache, and
- Make ScriptSourceCode cleaner, i.e. clarify that ScriptSourceCode has all necessarily information for compilation/evaluation, without need to dereference ScriptResource pointer.

This issue aims to
- Replace ScriptSourceCode's ScriptResource member with CachedMetadataHandler and
- Remove ScriptResource usage from V8ScriptRunner and ScriptController.

(One exception is the dependencies between ScriptStreamer and ScriptResource and they will remain, at least in the short term)
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dd04dea8c115189f76056aa283c643e6d1dc481

commit 7dd04dea8c115189f76056aa283c643e6d1dc481
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Thu Nov 30 21:34:05 2017

Do not use Resource for setting no_handler_reason

Instead, use ScriptSourceLocationType::kExternalFile,

Bug:  788828 
Change-Id: Ibc69d49e372ff08fd5817163e157503f3e45d1ae
Reviewed-on: https://chromium-review.googlesource.com/786094
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520698}
[modify] https://crrev.com/7dd04dea8c115189f76056aa283c643e6d1dc481/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1b7ac80edfaeaef595c342dfd41c5872c6b73ee

commit e1b7ac80edfaeaef595c342dfd41c5872c6b73ee
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Dec 01 04:03:35 2017

Do not use Resource in SelectCompileFunction()

Bug:  788828 
Change-Id: I45d9450cacce9613440496493a40098352dec4c7
Reviewed-on: https://chromium-review.googlesource.com/786530
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520847}
[modify] https://crrev.com/e1b7ac80edfaeaef595c342dfd41c5872c6b73ee/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/391f86a62e3b0ffeb9ad09b9f2b3feeb46a0ce20

commit 391f86a62e3b0ffeb9ad09b9f2b3feeb46a0ce20
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Dec 01 04:10:50 2017

Merge two versions of V8ScriptRunner::CompileScript()

The second CompileScript() overload is used only by
WorkerOrWorkletScriptController.cpp only to supply
CachedMetadataHandler to inline scripts.

This CL merges the second CompileScript() into the first, by:
- Adding CachedMetadataHandler argument to the first
  CompileScript() overload, and
- Plumbing ScriptSourceCode in WorkerOrWorkletScriptController.

This is to make ScriptSourceCode be always used when CompileScript()
is called from outside V8ScriptRunner (except for tests) and
to make the further refactoring easy.

Bug:  788828 
Change-Id: Ic3eaa5f2f15017c9093112111493d0759b0774fc
Reviewed-on: https://chromium-review.googlesource.com/786268
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520849}
[modify] https://crrev.com/391f86a62e3b0ffeb9ad09b9f2b3feeb46a0ce20/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/391f86a62e3b0ffeb9ad09b9f2b3feeb46a0ce20/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
[modify] https://crrev.com/391f86a62e3b0ffeb9ad09b9f2b3feeb46a0ce20/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/391f86a62e3b0ffeb9ad09b9f2b3feeb46a0ce20/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
[modify] https://crrev.com/391f86a62e3b0ffeb9ad09b9f2b3feeb46a0ce20/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[modify] https://crrev.com/391f86a62e3b0ffeb9ad09b9f2b3feeb46a0ce20/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23c523b050b3a7086bcaddb909e9477c8d13ab18

commit 23c523b050b3a7086bcaddb909e9477c8d13ab18
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Dec 01 18:10:54 2017

Remove Resource from V8ScriptRunner

Now that ScriptResource is used only in DCHECK()s in V8ScriptRunner,
this CL removes ScriptResource entirely from V8ScriptRunner.

V8ScriptRunner no longer needs to check the consistency between
ScriptResource and other arguments, which is/should be checked by
its callers instead.

This is preparation for removing ScriptSourceCode::Resource().

Bug:  788828 
Change-Id: Id41e634b384e04ab2881c317b1f5e661c6026954
Reviewed-on: https://chromium-review.googlesource.com/786533
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520985}
[modify] https://crrev.com/23c523b050b3a7086bcaddb909e9477c8d13ab18/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/23c523b050b3a7086bcaddb909e9477c8d13ab18/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
[modify] https://crrev.com/23c523b050b3a7086bcaddb909e9477c8d13ab18/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d00d41de963ebbfcaa000768b6d0205111124fd3

commit d00d41de963ebbfcaa000768b6d0205111124fd3
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Dec 01 19:47:59 2017

Remove ScriptSourceCode(ScriptResource*) constructor

No longer used after
https://chromium-review.googlesource.com/801665.

To make upcoming refactoring easy.

Bug:  788828 
Change-Id: Ie5ac6409c3d1c7ee113c90cff834a5ae6be53537
Reviewed-on: https://chromium-review.googlesource.com/786890
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521020}
[modify] https://crrev.com/d00d41de963ebbfcaa000768b6d0205111124fd3/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
[modify] https://crrev.com/d00d41de963ebbfcaa000768b6d0205111124fd3/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0392816436f14dc2e04c945a010d393c8c8f5fb

commit c0392816436f14dc2e04c945a010d393c8c8f5fb
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Tue Dec 05 23:24:33 2017

Move AccessControlStatus logic from ClassicScript to ClassicPendingScript

Preparation for removing ScriptSourceCode::GetResource().

Bug:  788828 
Change-Id: Ic1196997f2b7a0dd6f7febca476d45c4f4128598
Reviewed-on: https://chromium-review.googlesource.com/786891
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521883}
[modify] https://crrev.com/c0392816436f14dc2e04c945a010d393c8c8f5fb/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp
[modify] https://crrev.com/c0392816436f14dc2e04c945a010d393c8c8f5fb/third_party/WebKit/Source/core/dom/ClassicScript.cpp
[modify] https://crrev.com/c0392816436f14dc2e04c945a010d393c8c8f5fb/third_party/WebKit/Source/core/dom/ClassicScript.h
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22bf150b6fad408e508eb0efcb1bd7938f2b451b

commit 22bf150b6fad408e508eb0efcb1bd7938f2b451b
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Dec 06 00:55:48 2017

Move context document/frame null checks earlier

- It is better to do nothing when context document/frame is null.
- Preparation for removing ExecuteScriptResult.
  kShouldFireNone is no longer used, and will be removed in
  https://chromium-review.googlesource.com/791473.

Bug:  788828 , 686281
Change-Id: I2327e9065c9a07da0ea3658bb1d31765cbcb537f
Reviewed-on: https://chromium-review.googlesource.com/791450
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521926}
[modify] https://crrev.com/22bf150b6fad408e508eb0efcb1bd7938f2b451b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1ca4969c11ac1a7dc54f42eb61fdea907b089f5

commit c1ca4969c11ac1a7dc54f42eb61fdea907b089f5
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Thu Dec 07 00:48:52 2017

Move Script::CheckMIMETypeBeforeRunScript() to PendingScript

- Preparation for removing GetResource() from ScriptSourceCode.
- Preparation for removing ExecuteScriptResult.

Bug:  788828 , 686281
Change-Id: If2b4d1ca3d98a224871df38f6b01723f23cf5132
Reviewed-on: https://chromium-review.googlesource.com/791530
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522279}
[modify] https://crrev.com/c1ca4969c11ac1a7dc54f42eb61fdea907b089f5/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp
[modify] https://crrev.com/c1ca4969c11ac1a7dc54f42eb61fdea907b089f5/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
[modify] https://crrev.com/c1ca4969c11ac1a7dc54f42eb61fdea907b089f5/third_party/WebKit/Source/core/dom/ClassicScript.cpp
[modify] https://crrev.com/c1ca4969c11ac1a7dc54f42eb61fdea907b089f5/third_party/WebKit/Source/core/dom/ClassicScript.h
[modify] https://crrev.com/c1ca4969c11ac1a7dc54f42eb61fdea907b089f5/third_party/WebKit/Source/core/dom/ModulePendingScript.cpp
[modify] https://crrev.com/c1ca4969c11ac1a7dc54f42eb61fdea907b089f5/third_party/WebKit/Source/core/dom/ModulePendingScript.h
[modify] https://crrev.com/c1ca4969c11ac1a7dc54f42eb61fdea907b089f5/third_party/WebKit/Source/core/dom/ModuleScript.cpp
[modify] https://crrev.com/c1ca4969c11ac1a7dc54f42eb61fdea907b089f5/third_party/WebKit/Source/core/dom/ModuleScript.h
[modify] https://crrev.com/c1ca4969c11ac1a7dc54f42eb61fdea907b089f5/third_party/WebKit/Source/core/dom/PendingScript.h
[modify] https://crrev.com/c1ca4969c11ac1a7dc54f42eb61fdea907b089f5/third_party/WebKit/Source/core/dom/Script.h
[modify] https://crrev.com/c1ca4969c11ac1a7dc54f42eb61fdea907b089f5/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/c1ca4969c11ac1a7dc54f42eb61fdea907b089f5/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/533616f25d8d44ea01e0d3ac12be99b52c62dd22

commit 533616f25d8d44ea01e0d3ac12be99b52c62dd22
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Thu Dec 07 20:33:15 2017

Move CSP check for inline scripts to ExecuteScriptBlock()

Preparation for removing ExecuteScriptResult.
kShouldFireErrorEvent is no longer used, and will be removed in
https://chromium-review.googlesource.com/791473.

Bug:  788828 , 686281
Change-Id: Id83119633332a8592912ab6d8ca107a5134adaf7
Reviewed-on: https://chromium-review.googlesource.com/791491
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522535}
[modify] https://crrev.com/533616f25d8d44ea01e0d3ac12be99b52c62dd22/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/226a2968ba825f666b389408cd1070c66c66380b

commit 226a2968ba825f666b389408cd1070c66c66380b
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Thu Dec 07 21:07:11 2017

Merge ScriptLoader::DoExecuteScript() into ExecuteScriptBlock()

Bug:  788828 , 686281
Change-Id: I2e08c5a5e31b4d38cea50ef6cec50f51575abb5d
Reviewed-on: https://chromium-review.googlesource.com/791473
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522543}
[modify] https://crrev.com/226a2968ba825f666b389408cd1070c66c66380b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/226a2968ba825f666b389408cd1070c66c66380b/third_party/WebKit/Source/core/dom/ScriptLoader.h
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f4ce6eb7a2f54303988e38b96248082078c0d49

commit 7f4ce6eb7a2f54303988e38b96248082078c0d49
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Thu Dec 07 22:34:05 2017

Clean-up ScriptSourceCode

Makes most of the members of ScriptSourceCode const.

Bug:  788828 , 686281
Change-Id: I112ed0a2dd8e6a6e84647f49dc61ad4a840d9413
Reviewed-on: https://chromium-review.googlesource.com/666242
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522580}
[modify] https://crrev.com/7f4ce6eb7a2f54303988e38b96248082078c0d49/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
[modify] https://crrev.com/7f4ce6eb7a2f54303988e38b96248082078c0d49/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70a740542455ff94e4da520a8c629112cff5f875

commit 70a740542455ff94e4da520a8c629112cff5f875
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Dec 08 00:22:42 2017

Set ScriptSourceCode::url_/source_map_url_ in ctor

Preparation for removing ScriptSourceCode::resource_.

Bug:  788828 , 686281
Change-Id: I278b86f0d5baf650e7468ef9f62970bd28ea4209
Reviewed-on: https://chromium-review.googlesource.com/786895
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522638}
[modify] https://crrev.com/70a740542455ff94e4da520a8c629112cff5f875/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
[modify] https://crrev.com/70a740542455ff94e4da520a8c629112cff5f875/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d1a458799d108aefda87d9939c675a07c994970

commit 7d1a458799d108aefda87d9939c675a07c994970
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Dec 08 00:35:25 2017

Do not use Resource in CacheOptions() in ScriptController

To remove Resource from ScriptController, this CL
- Introduces CachedMetadataHandler::IsServedFromCacheStorage(), and
- Uses it in ScriptController's CacheOptions().

Bug:  788828 ,  784875 
Change-Id: Iaf34c40ceff223357361e8a189c3bf5d33251ffc
Reviewed-on: https://chromium-review.googlesource.com/786322
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522645}
[modify] https://crrev.com/7d1a458799d108aefda87d9939c675a07c994970/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/7d1a458799d108aefda87d9939c675a07c994970/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp
[modify] https://crrev.com/7d1a458799d108aefda87d9939c675a07c994970/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.h
[modify] https://crrev.com/7d1a458799d108aefda87d9939c675a07c994970/third_party/WebKit/Source/platform/loader/fetch/CachedMetadataHandler.h
[modify] https://crrev.com/7d1a458799d108aefda87d9939c675a07c994970/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/945431d84342213951f61cadde27c5192fac1f70

commit 945431d84342213951f61cadde27c5192fac1f70
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Dec 08 19:33:00 2017

Replace ScriptSourceCode::GetResource() with CacheHandler()

As a result of preceding refactoring CLs,
ScriptSourceCode::GetResource() is no longer used, except for
getting its cache handler.
This CL removes GetResource() and instead introduces
ScriptSourceCode::CacheHandler(), to make it clearer that
ScriptSourceCode has all necessary information for compilation,
evaluation and code caching, without relying on ScriptResource.

Where CachedMetadataHandler was given separately,
this CL sets the CachedMetadataHandler to ScriptSourceCode
and removes the separate CachedMetadataHandler arguments.

Bug:  788828 , 686281
Change-Id: I19555cafa7637bbb2289e9085baadd400e9987dd
Reviewed-on: https://chromium-review.googlesource.com/791493
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522841}
[modify] https://crrev.com/945431d84342213951f61cadde27c5192fac1f70/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/945431d84342213951f61cadde27c5192fac1f70/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
[modify] https://crrev.com/945431d84342213951f61cadde27c5192fac1f70/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h
[modify] https://crrev.com/945431d84342213951f61cadde27c5192fac1f70/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
[modify] https://crrev.com/945431d84342213951f61cadde27c5192fac1f70/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/945431d84342213951f61cadde27c5192fac1f70/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
[modify] https://crrev.com/945431d84342213951f61cadde27c5192fac1f70/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[modify] https://crrev.com/945431d84342213951f61cadde27c5192fac1f70/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h
[modify] https://crrev.com/945431d84342213951f61cadde27c5192fac1f70/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp
[modify] https://crrev.com/945431d84342213951f61cadde27c5192fac1f70/third_party/WebKit/Source/core/exported/WebScriptSource.cpp
[modify] https://crrev.com/945431d84342213951f61cadde27c5192fac1f70/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[modify] https://crrev.com/945431d84342213951f61cadde27c5192fac1f70/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/883274a62856effbb00abde7bf975294b5b7328f

commit 883274a62856effbb00abde7bf975294b5b7328f
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Sun Dec 10 21:00:30 2017

Always use ScriptSourceCode in V8ScriptRunner::CompileScript()

Bug:  788828 
Change-Id: I5874bb6e4a283a3049a94c0f66292101dfa5cec7
Reviewed-on: https://chromium-review.googlesource.com/794514
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523030}
[modify] https://crrev.com/883274a62856effbb00abde7bf975294b5b7328f/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
[modify] https://crrev.com/883274a62856effbb00abde7bf975294b5b7328f/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/883274a62856effbb00abde7bf975294b5b7328f/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
[modify] https://crrev.com/883274a62856effbb00abde7bf975294b5b7328f/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
[modify] https://crrev.com/883274a62856effbb00abde7bf975294b5b7328f/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
[modify] https://crrev.com/883274a62856effbb00abde7bf975294b5b7328f/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb33dbbbcf6f36daa5d7d116769b72a3c91ed9dc

commit bb33dbbbcf6f36daa5d7d116769b72a3c91ed9dc
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Mon Dec 11 20:58:12 2017

Remove ScriptStreamer::resource_

Instead of storing a Resource pointer, this CL plumbs the
Resource pointer given as the NotifyAppendData() argument.

This removes the last persistent Resource pointer in bindings/core/v8.

Bug:  788828 
Change-Id: Iae1c457537a69c3acf9846d92b9cc02e84ec71fc
Reviewed-on: https://chromium-review.googlesource.com/798530
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523203}
[modify] https://crrev.com/bb33dbbbcf6f36daa5d7d116769b72a3c91ed9dc/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
[modify] https://crrev.com/bb33dbbbcf6f36daa5d7d116769b72a3c91ed9dc/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h
[modify] https://crrev.com/bb33dbbbcf6f36daa5d7d116769b72a3c91ed9dc/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp

Comment 18 by hirosh...@chromium.org, Feb 13 2018

Status: Fixed (was: Started)
►

Sign in to add a comment