New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788813 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
█ yzjr@chromium.org
linds...@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Consolidate iOS utilities to execute JS

Project Member Reported by baxley@chromium.org, Nov 27 2017 
There are multiple utility methods inside ios/chrome/test and ios/web to execute JavaScript. We probably need more than one method to support EarlGrey and unit tests, but I believe there is a bit of code that can be shared, and some APIs can probably be removed.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/449a1c7bf1f52ec8fd4a771bfe370043646beb95

commit 449a1c7bf1f52ec8fd4a771bfe370043646beb95
Author: Mike Baxley <baxley@chromium.org>
Date: Mon Nov 27 19:37:27 2017

Update TODO to consolidate execute JS methods.

The bug for the existing TODO is too broad and tracks any generic
duplication in EarlGrey utilities. This updates the TODO with a bug
to specifcially track the issue that we may have too many utility
methods to execute JS.

Bug: 788813
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I32b373c133f2ecd1154d6e78732c0f3fa6cdc487
Reviewed-on: https://chromium-review.googlesource.com/790944
Reviewed-by: Menglu Huang <huangml@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519366}
[modify] https://crrev.com/449a1c7bf1f52ec8fd4a771bfe370043646beb95/ios/chrome/test/earl_grey/chrome_earl_grey.h
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 28

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by eugene...@chromium.org, Nov 28

Cc: -baxley@chromium.org -eugene...@chromium.org -huangml@chromium.org linds...@chromium.org yzjr@chromium.org
Status: Available (was: Untriaged)
►

Sign in to add a comment