New issue
Advanced search Search tips

Issue 788796 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 789698



Sign in to add a comment

v8.browsing_desktop failing on chromium.perf/Linux Perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Nov 27 2017

Issue description

Imgur page in v8.browsing_desktop failing on chromium.perf/Linux Perf

Builders failed on: 
- Linux Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf


 
Owner: mythria@chromium.org
Status: Assigned (was: Available)
It seems that a test suite times out. Can we increase the time limit for this test?

Comment 2 by hbos@chromium.org, Nov 28 2017

Regardless of the solution to this, can we disable the test that's failing? (I don't know how to do that with these python tests)

This bot has been unhealthy for several days we need to make it green.
Cc: mythria@chromium.org
Owner: ----
Status: Available (was: Assigned)
I will be landing a cl to disable imgur story that is causing the timeout. Looks like the timeout is happening when computing the metric. The trace looks as follows:

(INFO) 2017-11-27 14:48:14,644 trace_data.Serialize:191  Trace sizes in bytes: {'traceEvents': 566015235, 'telemetry': 211820, 'tabIds': 38}
+-----------------------------------------------------------------------------+
| End of shard 0                                                              |
|  Pending: 3554.1s  Duration: 1511.6s  Bot: build30-a9  Exit: -15  TIMED_OUT |
+-----------------------------------------------------------------------------+
Total duration: 1511.6s
WARNING:root:collect_cmd had non-zero return code: 241
Traceback (most recent call last):
  File "/b/rr/tmpCH3dfE/rw/checkout/scripts/slave/recipe_modules/swarming/resources/standard_isolated_script_merge.py", line 45, in <module>
    sys.exit(main())
  File "/b/rr/tmpCH3dfE/rw/checkout/scripts/slave/recipe_modules/swarming/resources/standard_isolated_script_merge.py", line 41, in main
    return StandardIsolatedScriptMerge(args.output_json, args.jsons_to_merge)
  File "/b/rr/tmpCH3dfE/rw/checkout/scripts/slave/recipe_modules/swarming/resources/standard_isolated_script_merge.py", line 24, in StandardIsolatedScriptMerge
    shard_results_list.append(json.load(f))
  File "/usr/lib/python2.7/json/__init__.py", line 290, in load
    **kw)
  File "/usr/lib/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 384, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
WARNING:root:merge_cmd had non-zero return code: 1
step returned non-zero exit code: 241
Cc: nedngu...@google.com simonhatch@chromium.org perezju@chromium.org
Ned, Juan any idea what could have gone wrong recently. It seems to be happening only on linux perf bots. on windows it is working fine. 
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/564d279682098c46cdba237d51476e8bbba34a18

commit 564d279682098c46cdba237d51476e8bbba34a18
Author: Mythri Alle <mythria@chromium.org>
Date: Tue Nov 28 17:58:55 2017

Disable imgur page in v8.browsing_desktop on linux platform

Bug:  chromium:788796 
Change-Id: I208022746d63a6379dcf55cb12c1ec8fea8aabcc
Reviewed-on: https://chromium-review.googlesource.com/794110
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519740}
[modify] https://crrev.com/564d279682098c46cdba237d51476e8bbba34a18/tools/perf/benchmarks/v8_browsing.py

Labels: Needs-Bisect
I would rely on bisect to figure out what went wrong on imgur page.
Cc: jbudorick@chromium.org
+jbudorick the call stack in #3 is about an error in standard_isolated_script_merge.py

not sure what this has to do with the imgur page?
I am not sure, but looking at: "ValueError: No JSON object could be decoded" at the end, I guess the page timesout when producing the data. The script fails because there is no data maybe. 

I dint think about this yesterday, but imgur page has been failing for quite some time on v8.runtimestats.browsing_desktop benchmark. I recently changed this to v8.browsing_desktop. So, this is not a recent failure. I am sorry, dint look at carefully yesterday.

Also, when compared to other pages the number of trace events are much higher on this one. For example for the trace in #3 the number of trace events is  566015235. Does this seem reasonable? Is telemetry expected to handle such numbers?
Which build on Linux Perf is that stack from #3 from?
#8: yeah, it looks like standard_isolated_script_merge.py is being handed an empty but existing file. Sending out a CL to clean up how that's handled here: https://chromium-review.googlesource.com/c/chromium/tools/build/+/797150
Blocking: 789698
Labels: -Sheriff-Chromium
Owner: mythria@chromium.org
It seems like this test suite isn't failing on the bot in question; presumably the CLs above helped.

->mythria to decide what further needs to be done on this bug; it's not clear to me what further action should be taken here.

Removing from sheriff queue.
Status: Assigned (was: Available)
I have disabled imgur page, so I guess the bot is happy. Though I still think we need to look into why the json file was not produced in the first place. The fix from jbudorick@ (in #12) would handle the case when there are empty JSON files more gracefully. So, I think we still need to keep this bug to track failures on imgur. 

Comment 17 Deleted

Labels: v8-benchmarks
Components: Blink>JavaScript Speed>Benchmarks
Shouldn't we re-enable imgur in order to try if the CL helped?
I am sorry, I was planning to look into it but didn't get to it. In my understanding, the json file should not be empty. imgur page fails locally too. Not consistently though. That is the reason, I haven't enabled imgur yet. I thought it could be because of the large number of trace events it produces (10x more than the average). I haven't verified it yet. I will be on vacation from tomorrow. I will have a look at this once I am back after christmas.

Comment 22 by ajha@chromium.org, Jan 30 2018

Labels: Needs-Feedback
Is there any test page where we can test and check for the bisect for this?
Status: WontFix (was: Assigned)
Since we are moving to a new pages and it is too old may be not worth investigating it now.

Sign in to add a comment