New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788779 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: Bug-Regression



Sign in to add a comment

14.6% regression in graphics_SanAngeles at 32520001007600000:32530001007700000

Project Member Reported by gurchetansingh@google.com, Nov 27 2017

Issue description

ChromeOS Version range: 64.10076.0.0 - 64.10077.0.0 
Chrome Version range: 64.0.3252.0 - 64.0.3253.0 


https://crosland.corp.google.com/log/10076.0.0..10077.0.0
https://chromium.googlesource.com/chromium/src/+log/64.0.3252.0..64.0.3253.0?pretty=fuller&n=10000

Looks related to the Mesa uprev..
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 27 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=788779

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=8b4f168836827dacf62f2478e122b30140e81f4d3fdd861c6a6241c853f0cbac


Bot(s) for this bug's original alert(s):

cros-cyan
Labels: Gfx-Guard
Cc: gurcheta...@chromium.org
Owner: pwang@chromium.org
According to ihf@, graphics_SanAngeles is a very old app and we shouldn't look at it for performance difference.  pwang@, can you remove this alert?

Comment 4 by ihf@chromium.org, Nov 28 2017

I think we should still get alerted, but discount alerts a lot. It is basically a very weak signal, but having it can help find out where a problem came from.

Comment 5 by pwang@chromium.org, Nov 28 2017

I am more on not deleting the alert completely, but tweaking the alerts so that we don't get too much noise.

Comment 6 by pwang@chromium.org, Nov 28 2017

Owner: gurcheta...@chromium.org
Checked my email, it seems that the SanAngeles is quite stable (not much alerts generated). So I think it is fine to keep the current setting.

The fps drop in this bug seems to be a real thing?
Cc: marc...@chromium.org chadversary@chromium.org
Status: WontFix (was: Assigned)
I bisected and the commit that caused the issue is:

717e7539124dc459276385a02847b06ea1989973 is the first bad commit
commit 717e7539124dc459276385a02847b06ea1989973
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Fri Sep 8 15:00:14 2017 -0700

i965: Use a WC map and memcpy for the batch instead of pwrite.

We'd like to eliminate the malloc'd shadow copy eventually, but there
are still unresolved performance problems.  In the meantime, let's at 
least get rid of pwrite.

On Apollolake, improves Synmark OglBatch6 performance by:
1.53581% +/- 0.269589% (n=108).

Reviewed-by: Matt Turner <mattst88@gmail.com>
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

It's just weird we have a FPS of 260-320, when in reality it should between 0-60 fps.  I guess it measures something that is correlated with frame rate?  In any case, let's ignore this regression for now since we are unsure about the usefulness of the benchmark.  If we find other regressions associated with that commit, maybe we'll do something...

Sign in to add a comment