New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788766 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue 781585



Sign in to add a comment

16% regression in graphics_WebGLAquarium at 32720001014600000:32730001014900000

Project Member Reported by gurchetansingh@google.com, Nov 27 2017

Issue description

Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 27 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=788766

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=9f145ab13ae858e96943ee62b8562583f9338494fc6a6ba1783d47c3508b0a68


Bot(s) for this bug's original alert(s):

cros-veyron_minnie
Labels: Gfx-Guard
Cc: marc...@chromium.org gurcheta...@chromium.org
Owner: ----
Status: vmiurachromium.org (was: Assigned)
[bisected]

651b0c341c3c1b813250dd4df4c45b423d760e93 is the first bad commit
commit 651b0c341c3c1b813250dd4df4c45b423d760e93
Author: Victor Miura <vmiura@chromium.org>
Date:   Sat Nov 18 05:03:43 2017 +0000

    Reland "gpu scheduler: Compute stream priorities based on priority of waiters."
    
    This is a reland of 56eadad0e85ad5331dea863690efc604e3d763b4
    Original change's description:
    > gpu scheduler: Compute stream priorities based on priority of waiters.
    >
    > Previously, a stream tracked all of it's fences that had waiting streams
    > in 'release_fences'.  If 'release_fences' was non-empty, the stream's
    > priority got bumped up to High.  This means a stream with Normal priority
    > waiting on Low priority stream could bump that stream up to High priority.
    >
    > This change removes that tracking, and instead keeps count of the number
    > of waiting streams at each StreamPriority.  The highest priority with non-
    > zero count becomes the stream's priority.
    >
    > When a stream changes priority, it recursively propagates it's new priority
    > to all streams it's waiting on.
    >
    > BUG= 781585 
    >
    > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    > Change-Id: I1fc96f6ca065a8e1f83ddaa61ae4f9725c324bcb
    > Reviewed-on: https://chromium-review.googlesource.com/754415
    > Commit-Queue: Victor Miura <vmiura@chromium.org>
    > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
    > Reviewed-by: Antoine Labour <piman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#515097}
    
    Bug:  781585 
    Change-Id: I67055fe2887a8ffcc8032af32ab221a3d66bedac
    Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/762145
    Commit-Queue: Victor Miura <vmiura@chromium.org>
    Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#517702}

The avg_fps_050_fishes metric of graphics_WebGLAquarium regressed by following amounts:

cros-veyron_minnie: 16%
cros-bob: 19.4%
cros-kevin: 8.0%

vmiura@ -- can you investigate this regression and try to improve the performance of this CL?  To build ChomeOS or Chrome for CrOS, please follow this guide:

http://www.chromium.org/chromium-os/developer-guide
https://chromium.googlesource.com/chromiumos/docs/+/master/simple_chrome_workflow.md

After you've built you can run this test with the following command:

test_that -b ${BOARD} $IP graphics_WebGLAquarium

It will report a variety of numbers.  The avg_fps_0050_fishes metrics regressed the most.  Let me know if you have any questions.
Owner: vmi...@chromium.org
Status: Assigned (was: vmiurachromium.org)
Cc: sunn...@chromium.org

Comment 6 by kbr@chromium.org, Dec 2 2017

Blockedon: 781585
Ping, any update on this one? The perf doesn't seem to be back
Cc: kbr@chromium.org
Ping?
Cc: vmi...@chromium.org
Owner: sunn...@chromium.org
I'll investigate this.

Sign in to add a comment