New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788762 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Account for scale when calculate child bounds in UiElement::DoLayOutChildren

Project Member Reported by bshe@chromium.org, Nov 27 2017

Issue description

We currently only use size. But the element might be scaled which changes the bounds.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b41f128f7b2039e051a7256b6fc53bb5d1eb634

commit 7b41f128f7b2039e051a7256b6fc53bb5d1eb634
Author: Ian Vollick <vollick@chromium.org>
Date: Tue Dec 19 15:50:12 2017

[vr] Bounds-contains-children and linear layout should account for scale

Previously, size would not be considered when performing a linear layout
or when containing children. With this CL, both now accommodate scaled
elements.

Bug:  788762 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9f676956b8d109afde0443507b6130af5a46507a
Reviewed-on: https://chromium-review.googlesource.com/832827
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525040}
[modify] https://crrev.com/7b41f128f7b2039e051a7256b6fc53bb5d1eb634/chrome/browser/vr/elements/linear_layout.cc
[modify] https://crrev.com/7b41f128f7b2039e051a7256b6fc53bb5d1eb634/chrome/browser/vr/elements/linear_layout_unittest.cc
[modify] https://crrev.com/7b41f128f7b2039e051a7256b6fc53bb5d1eb634/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/7b41f128f7b2039e051a7256b6fc53bb5d1eb634/chrome/browser/vr/elements/ui_element_unittest.cc

Status: Fixed (was: Available)
Labels: M-65 Test-Complete

Sign in to add a comment