New issue
Advanced search Search tips

Issue 788760 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 788802
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

browser_tests WebRtcRtpBrowserTest.AddAndRemoveTracksWithoutStream & AddAndRemoveTracksWithIndividualStreams failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Nov 27 2017

Issue description

Owner: phoglund@chromium.org
Status: Untriaged (was: Available)
phoglund@, Could you please take a look and triage this issue? Thanks.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41685df6c4bc45f2170f7ae651198956ea24ee7c

commit 41685df6c4bc45f2170f7ae651198956ea24ee7c
Author: Peng Huang <penghuang@chromium.org>
Date: Mon Nov 27 17:46:08 2017

Disable two flaky WebRtcRtpBrowserTests

Disable two flaky tests:
  WebRtcRtpBrowserTest.AddAndRemoveTracksWithoutStream
  WebRtcRtpBrowserTest.AddAndRemoveTracksWithIndividualStreams

TBR=phoglund@chromium.org

Bug:  788760 
Change-Id: I9409c1c1108f361197f86cf66340e5311b5a4e4d
Reviewed-on: https://chromium-review.googlesource.com/790950
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519331}
[modify] https://crrev.com/41685df6c4bc45f2170f7ae651198956ea24ee7c/chrome/browser/media/webrtc/webrtc_rtp_browsertest.cc

Components: Blink>WebRTC>PeerConnection
Owner: ----
Setting component so the team working on RTP can triage.

Comment 5 by guidou@chromium.org, Nov 28 2017

Owner: hbos@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by hbos@chromium.org, Nov 28 2017

I will try to debug and fix when I have time (Sheriff now). I did a run earlier and I couldn't repro any failures on my Mac laptop running these tests...

Comment 7 by hbos@chromium.org, Nov 28 2017

Labels: -Sheriff-Chromium
Tests are disabled and an owner has been assigned. Removing sheriff label.

Comment 8 by hbos@chromium.org, Dec 5 2017

Status: Started (was: Assigned)
It's a shame the sheriff-o-matic doesn't include links to the specific builds that failed, only the bots. I don't have the failing logs and I can't repro on my mac.

I am speculating that the flakes that was seen were caused by the same thing as  https://crbug.com/788802  which was quickly fixed by https://chromium-review.googlesource.com/c/chromium/src/+/791350. That explains why the other browser tests has not been marked flaky and why I can't repro.

I'll re-enable the tests.
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41b00c13fecd10d8f0e7a574056c4f3d31ebdffc

commit 41b00c13fecd10d8f0e7a574056c4f3d31ebdffc
Author: Henrik Boström <hbos@chromium.org>
Date: Tue Dec 05 11:54:49 2017

Re-enable WebRtcRtpBrowserTests no longer flaky.

Enable two tests:
- WebRtcRtpBrowserTest.AddAndRemoveTracksWithoutStream
- WebRtcRtpBrowserTest.AddAndRemoveTracksWithIndividualStreams

Also remove the AppendSwitch for "RTCRtpSender", a flag which has been
removed and enabled by default.

TBR=phoglund@chromium.org

Bug:  788760 
Change-Id: I2942aed11dca4bf70e4540840ff796def64a3f1d
Reviewed-on: https://chromium-review.googlesource.com/808384
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521670}
[modify] https://crrev.com/41b00c13fecd10d8f0e7a574056c4f3d31ebdffc/chrome/browser/media/webrtc/webrtc_rtp_browsertest.cc

Comment 10 by hbos@chromium.org, Dec 5 2017

Mergedinto: 788802
Status: Duplicate (was: Started)
Tests re-enabled, merging into fixed issue.

Sign in to add a comment