Correct title of reauthentication prompt for viewing passwords on Android |
||||
Issue descriptionThe Android-provided reauth screen currently shows the following sub-title/description: "Unlock to continue setting up your phone" We define it in IDS_LOCKSCREEN_DESCRIPTION and use in lockDevice in PasswordReauthenticationFragment. As the user is not trying to set up their phone but to view or copy a password, we might need to change it to something like: "Unlock to continue viewing your password" and "Unlock to continue copying your password" respectively. Adding melandory@ to check that there is no historical reason for which the string should keep mentioning the setting up, and also maxwalker@ (who found out) and srahim@ for checking if the proposal makes sense or whether there are better alternatives.
,
Nov 29 2017
Thanks for confirmation! I'm starting on this, because I actually need to do that anyway for bug 788701 .
,
Nov 29 2017
Adding screencast for https://crrev.com/c/796630
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8b3f701a2b857e966f074bc310d9f59c6542ed2 commit f8b3f701a2b857e966f074bc310d9f59c6542ed2 Author: Vaclav Brozek <vabr@chromium.org> Date: Wed Nov 29 19:29:33 2017 [Android password settings] Fix reauth explanation If the user tries to view or copy passwords in Chrome on Android, the settings page asks them to reauthenticate. The explanation on the reauthentication screen is currently confusing, telling the user that they need to reauthenticate to "continue setting up [their] phone". This CL changes that message to mirror better the user's original intention, mentioning copying or viewing as appropriate. The change has no test. While the instrumentation tests are able to trigger the reauthentication screen, there seems to be no way to read UI elements on that, because it is being rendered by Android and not by Chrome. Bug: 788749 Change-Id: I06c25c837606aa427cb5cb6db39e8e3fbeb5aa07 Reviewed-on: https://chromium-review.googlesource.com/796630 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#520197} [modify] https://crrev.com/f8b3f701a2b857e966f074bc310d9f59c6542ed2/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java [modify] https://crrev.com/f8b3f701a2b857e966f074bc310d9f59c6542ed2/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordReauthenticationFragment.java [modify] https://crrev.com/f8b3f701a2b857e966f074bc310d9f59c6542ed2/chrome/android/java/strings/android_chrome_strings.grd
,
Nov 29 2017
,
Nov 29 2017
Text as implemented in the GRD file LGTM, thanks.
,
Nov 30 2017
Thanks for confirming! (And to explain why I did not wait for the confirmation before landing the CL: the change seemed to be an improvement even if not the final one, and I am always ready to do follow-ups.)
,
Nov 29
|
||||
►
Sign in to add a comment |
||||
Comment 1 by melandory@chromium.org
, Nov 28 2017