New issue
Advanced search Search tips

Issue 788747 link

Starred by 1 user
Status: Fixed
Owner:
kkhorimoto@chromium.org
Closed: Aug 17
Cc:
eugene...@chromium.org
justincohen@chromium.org
kkhorimoto@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

While in fullscreen mode scrolling up and down on healthline.com results in the status bar changing sizes

Project Member Reported by linds...@chromium.org, Nov 27 2017 

App Version: 64.0.3279.0
iOS Version: iOS11.1.2
Device: iPhone8, iPhoneX
URL: healthline.com/health/cold-flu/cold#overview1

Steps to reproduce:
  1. Load the above URL
  2. Scroll towards the bottom of the page while watching the clock in the status bar

Observed results:
Notice the narrow (in fullscreen mode) status bar will flicker, changing to a more narrow size and then back. If you can't repro try reloading the page.

Expected results:
The narrow fullscreen sized status bar should consistently stay the same size and have no flicker.


Number of times you were able to reproduce: 4/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies:Yes
Observed behavior in Chrome Mobile on Android: n/a
Check for similar behavior on Firefox/Safari: Safari: No, Firefox: No
Bug reproducible on current stable build (App Version, iOS Version): Yes M62
Bug reproducible on the current beta channel (dogfoody) build (App Version, iOS Version): Yes M63

Video: https://drive.google.com/file/d/1hrrqR4SuYGLTPuksht2-JZJvwkC3FKdm/view

Comment 1 by justincohen@chromium.org, Nov 27 2017

Cc: kkhorimoto@chromium.org
I see a lot of [_legacyFullscreenController disableFullScreen] calls when I wouldn't expect them.  It looks like this site overloads scroll events, I wonder if something odd is going on here.

Comment 2 by kkhorimoto@chromium.org, Nov 27 2017

Cc: eugene...@chromium.org
Components: UI>Browser>FullScreen
Owner: kkhorimoto@chromium.org
Status: Assigned (was: Untriaged)
Is this a regression?  I haven't changed any code in the existing fullscreen logic apart from renaming _fullscreenController to _legacyFullscreenController.  I'll check today where there erroneous |-disableFullScreen| calls are coming from.  It's likely that this is happening due to some changes in the navigation stack, as |-disableFullScreen| is triggered by navigation events.

Comment 3 by eugene...@chromium.org, Nov 27 2017 

I think the page changes URL fragment during the scroll and disableFullScreen is called from -[Tab didCommitNavigationWithDetails:webState:].

There is no need to disable fullscreen inside didCommitNavigationWithDetails:webState:. It's already done in webState:didStartNavigation:

Comment 4 by eugene...@chromium.org, Dec 15 2017

Components: -Mobile>WebView>Glue

Comment 5 by eugene...@chromium.org, Aug 17

Status: Fixed (was: Assigned)
Seems to work fine with the new UI. Please verify.

Comment 6 by linds...@chromium.org, Aug 22 

I can no longer repro this.
►

Sign in to add a comment