Exo doesn't track pressed keys properly. |
|||||
Issue descriptionThis is a regression from starting to use a post-target event handler in exo::Keyboard. Pre-target handler needs to be used to track pressed keys correctly. The result is that incorrect set of pressed keys is passed to clients when input focus enter a client window.
,
Nov 27 2017
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a43a3ee8c62aa181bf89902ead6ab71c80b43f03 commit a43a3ee8c62aa181bf89902ead6ab71c80b43f03 Author: David Reveman <reveman@chromium.org> Date: Tue Nov 28 02:07:08 2017 exo: Fix tear down crash in Seat class. Fix ExoParts destruction order to ensure that WMHelper instance is valid when exo::Display is destroyed. Bug: 788731 Test: Running Chrome with DCHECKs no longer fails at shutdown. Change-Id: I9bddecd863d92b600378488e04612cff87cef1ae Reviewed-on: https://chromium-review.googlesource.com/792214 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#519523} [modify] https://crrev.com/a43a3ee8c62aa181bf89902ead6ab71c80b43f03/ash/wayland/wayland_server_controller.cc [modify] https://crrev.com/a43a3ee8c62aa181bf89902ead6ab71c80b43f03/chrome/browser/exo_parts.cc
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f9d5619eef81ec64b59755944717d0691bbd65f commit 3f9d5619eef81ec64b59755944717d0691bbd65f Author: David Reveman <reveman@chromium.org> Date: Mon Dec 04 02:57:52 2017 exo: Fix tracking of modifier flags. Modifier flags needs same treatment as pressed keys. Move modifier flag tracking to Seat class. Bug: 788731 Tbr: yoshiki@chromium.org Test: exo_unittests --gtest_filter=KeyboardTest.OnKeyboardEnter Change-Id: Ife2fae2d622dfff3617830ba232d0267fdbc9b35 Reviewed-on: https://chromium-review.googlesource.com/805359 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521257} [modify] https://crrev.com/3f9d5619eef81ec64b59755944717d0691bbd65f/components/exo/keyboard.cc [modify] https://crrev.com/3f9d5619eef81ec64b59755944717d0691bbd65f/components/exo/keyboard_unittest.cc [modify] https://crrev.com/3f9d5619eef81ec64b59755944717d0691bbd65f/components/exo/seat.cc [modify] https://crrev.com/3f9d5619eef81ec64b59755944717d0691bbd65f/components/exo/seat.h
,
Dec 4 2017
,
Dec 4 2017
Approving merge to M64 Chrome OS.
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cac3c386497adf9fc5f308745c80ce133407b764 commit cac3c386497adf9fc5f308745c80ce133407b764 Author: David Reveman <reveman@chromium.org> Date: Mon Dec 04 20:48:19 2017 exo: Fix tracking of modifier flags. Modifier flags needs same treatment as pressed keys. Move modifier flag tracking to Seat class. TBR=reveman@chromium.org (cherry picked from commit 3f9d5619eef81ec64b59755944717d0691bbd65f) Bug: 788731 Tbr: yoshiki@chromium.org Test: exo_unittests --gtest_filter=KeyboardTest.OnKeyboardEnter Change-Id: Ife2fae2d622dfff3617830ba232d0267fdbc9b35 Reviewed-on: https://chromium-review.googlesource.com/805359 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521257} Reviewed-on: https://chromium-review.googlesource.com/806724 Cr-Commit-Position: refs/branch-heads/3282@{#17} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/cac3c386497adf9fc5f308745c80ce133407b764/components/exo/keyboard.cc [modify] https://crrev.com/cac3c386497adf9fc5f308745c80ce133407b764/components/exo/keyboard_unittest.cc [modify] https://crrev.com/cac3c386497adf9fc5f308745c80ce133407b764/components/exo/seat.cc [modify] https://crrev.com/cac3c386497adf9fc5f308745c80ce133407b764/components/exo/seat.h |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Nov 27 2017