New issue
Advanced search Search tips

Issue 788725 link

Starred by 1 user
Status: Fixed
Owner:
drott@chromium.org
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Consider merging canvas rotation flags between ShapeResult and ShapeResultBloberizer

Project Member Reported by drott@chromium.org, Nov 27 2017 
When removing the canvas rotation hacks from SimpleFontData a new flag CanvasRotationInVertical was introduced, which is semantically similar to BlobRotation in ShapeResultBloberizer. We can probably unify those.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d0a42f144444aba64ba081df9164692841f7e44

commit 8d0a42f144444aba64ba081df9164692841f7e44
Author: Dominik Röttsches <drott@chromium.org>
Date: Tue Dec 05 15:33:01 2017

Merge BlobRotation and CanvasRotationInVertical

Bug:  788725 
Change-Id: I09d62b7df3f739006972a27f35ab26da4808e310
Reviewed-on: https://chromium-review.googlesource.com/807933
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521698}
[modify] https://crrev.com/8d0a42f144444aba64ba081df9164692841f7e44/third_party/WebKit/Source/platform/fonts/Font.cpp
[modify] https://crrev.com/8d0a42f144444aba64ba081df9164692841f7e44/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.cpp
[modify] https://crrev.com/8d0a42f144444aba64ba081df9164692841f7e44/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.h

Comment 2 by drott@chromium.org, Dec 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment