GetCollectStatsConsent() ends up blocking where it shouldn't? |
||||
Issue descriptioncrrev.com/c/783707 landed a call to GetCollectStatsConsent() that seems to end up in a disallowed blocking call, and it's preventing my simplechrome on soraka from booting up, the crash stack says: [27334:27334:1127/100516.056462:FATAL:thread_restrictions.cc(29)] Check failed: !g_blocking_disallowed.Get().Get(). Function marked as blocking was called from a scope that disallows blocking! If this task is running inside the TaskScheduler, it needs to have MayBlock() in its TaskTraits. Otherwise, consider making this blocking work asynchronous or, as a last resort, you may use ScopedAllowBlocking in a narrow scope. #0 0x583b4a50806c base::debug::StackTrace::StackTrace() #1 0x583b4a526d63 logging::LogMessage::~LogMessage() #2 0x583b4a5927e6 base::AssertBlockingAllowed() #3 0x583b4a51c7b3 base::DirectoryExists() #4 0x583b4a1466b8 GoogleUpdateSettings::GetCollectStatsConsent() #5 0x583b4d00f44c chromeos::GaiaScreenHandler::LoadGaiaWithVersion() #6 0x583b485c5e74 _ZN4base8internal7InvokerINS0_9BindStateIMN7content11SavePackageEFvRKNS_17RepeatingCallbackIFvPNS3_12DownloadItemEEEEPNS3_16DownloadItemImplEEJNS_7WeakPtrIS4_EES9_EEEFvSD_EE3RunEPNS0_13BindStateBaseESD_ #7 0x583b484b4ad9 base::internal::ReplyAdapter<>() #8 0x583b47b2d0fb _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12OnceCallbackIFvNSt3__110unique_ptrINS_5ValueENS4_14default_deleteIS6_EEEEEEEPS9_EJSB_NS0_12OwnedWrapperIS9_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #9 0x583b4a588ee4 base::(anonymous namespace)::PostTaskAndReplyRelay::RunReplyAndSelfDestruct() #10 0x583b4a5088c8 base::debug::TaskAnnotator::RunTask() #11 0x583b4a5d39e6 base::internal::IncomingTaskQueue::RunTask() #12 0x583b4a52fa7d base::MessageLoop::RunTask() #13 0x583b4a52fe8b base::MessageLoop::DeferOrRunPendingTask() #14 0x583b4a530140 base::MessageLoop::DoWork() #15 0x583b4a5324f9 base::MessagePumpLibevent::Run() #16 0x583b4a52f2cc base::MessageLoop::Run() #17 0x583b4a55d9a5 base::RunLoop::Run() #18 0x583b4a11fe57 ChromeBrowserMainParts::MainMessageLoopRun() #19 0x583b4848d964 content::BrowserMainLoop::RunMainMessageLoopParts() #20 0x583b48491413 content::BrowserMainRunnerImpl::Run() #21 0x583b4848919e content::BrowserMain() #22 0x583b4a106204 content::RunNamedProcessTypeMain() #23 0x583b4a106d17 content::ContentMainRunnerImpl::Run() #24 0x583b4a113319 service_manager::Main() #25 0x583b4a105591 content::ContentMain() #26 0x583b47a8aea8 ChromeMain #27 0x7d69ef0e9736 __libc_start_main SDK version is 10149.0.0, developer build on 519295 alemate@ can you plz take a look? thx
,
Nov 28 2017
emulator debug build crashes with same stack trace
,
Nov 28 2017
alemate@ ping
,
Nov 30 2017
raise it to p1
,
Nov 30 2017
Thanks for pinpointing this down Miguel! This also breaks my desktop target_os = "chromeos" build. Any ETA on when this may be fixed Alexander? I can just run with "dcheck_always_on = false", but I dislike doing that.
,
Nov 30 2017
Reverting the offending CL since there seems to be evidence of it being hit by a few devs and not just me, crrev.com/c/800890.
,
Dec 1 2017
This has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/802764 .
,
Jul 30
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mcasas@chromium.org
, Nov 27 2017