TracingControllerImpl::OnMetadataAvailable DCHECK hit during webkit_layout_tests |
||
Issue descriptionFrom https://chromium-swarm.appspot.com/task?id=3a15eb28e7823210&refresh=10&show_raw=1: 03:05:49.686 22568 worker/2 http/tests/devtools/service-workers/service-worker-v8-cache.js crashed, (stderr lines): 03:05:49.686 22568 [22679:1295:1127/030549.606568:FATAL:tracing_controller_impl.cc(396)] Check failed: !filtered_metadata_. This is leading to flaky webkit_layout_test failures; please fix as soon as possible.
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87a4dbb155d94f4854a1adeb2db07770f670cbb7 commit 87a4dbb155d94f4854a1adeb2db07770f670cbb7 Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Mon Nov 27 21:27:17 2017 tracing: fix a bug when no endpoint is given When no trace endpoint is given to StopTracing, we don't reset filtered_metadata_ which causes a DCHECK failure in the next StopTracing call. Bug: 788698 Change-Id: Ifb76f0d68ffc92a6d34498b9e574e31f0644b2dc Reviewed-on: https://chromium-review.googlesource.com/791210 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#519411} [modify] https://crrev.com/87a4dbb155d94f4854a1adeb2db07770f670cbb7/content/browser/tracing/tracing_controller_impl.cc
,
Nov 28 2017
,
Nov 29 2017
I think this is fixed now. However, the bot is still flaky, which I suspect is due to another issue (no tracing controller DCHECKs in the logs). |
||
►
Sign in to add a comment |
||
Comment 1 by chiniforooshan@chromium.org
, Nov 27 2017