New issue
Advanced search Search tips

Issue 788694 link

Starred by 1 user
Status: Fixed
Owner:
tommi@chromium.org
Closed: Dec 2017
Cc:
guidou@chromium.org
hta@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make WebRTC's rtc::Event use WaitableEvent

Project Member Reported by tommi@chromium.org, Nov 27 2017 
As WebRTC's TaskQueue implementation is about to be implemented on top of Chromium's TaskScheduler framework, we should override WebRTC's 'Event' implementation with one that uses WaitableEvent so that we'll get the benefits of thread restriction checks in Chromium for WebRTC.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cda8addd5b0934e2ce45762f7b43ede30ed7c12b

commit cda8addd5b0934e2ce45762f7b43ede30ed7c12b
Author: Tommi <tommi@chromium.org>
Date: Thu Dec 07 18:55:53 2017

Make WebRTC's rtc::Event implementation rely on WaitableEvent.

Also add a gtest_prod_util.h override to avoid conflict of macro redefinition.

Bug:  788694 
Change-Id: Ib5a597da593a8fccc39b7c37041bd283f4160f67
Reviewed-on: https://chromium-review.googlesource.com/793832
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522490}
[modify] https://crrev.com/cda8addd5b0934e2ce45762f7b43ede30ed7c12b/third_party/webrtc_overrides/rtc_base/event.cc
[modify] https://crrev.com/cda8addd5b0934e2ce45762f7b43ede30ed7c12b/third_party/webrtc_overrides/rtc_base/event.h
[add] https://crrev.com/cda8addd5b0934e2ce45762f7b43ede30ed7c12b/third_party/webrtc_overrides/rtc_base/gtest_prod_util.h

Comment 2 by tommi@chromium.org, Dec 7 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment