New issue
Advanced search Search tips

Issue 788684 link

Starred by 1 user
Status: Fixed
Owner:
toyoshim@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Web MIDI: check failure in MidiManagerAndroid dtor on arm64

Project Member Reported by toyoshim@chromium.org, Nov 27 2017 
[FATAL:midi_manager_android.cc(58)] Check failed: all_output_ports_.empty().


Repro step:
1. Visit a site using Web MIDI API with DCHECK enabled Chrome
2. Reload

If dynamic instantiation is enabled (should be by default now), and the device supports MIDI service, Chrome will catch a DCHECK failure on MidiManagerAndroid's dtor.

Comment 1 by toyoshim@chromium.org, Nov 27 2017 

Of course, this needs a MIDI output (virtual) device installed.

E.g., this app can make the Android have a virtual output port. https://play.google.com/store/apps/details?id=net.volcanomobile.sonivoxeasmidi&hl=en
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9de72a68487e0821370115aef972c04ec7257b4

commit d9de72a68487e0821370115aef972c04ec7257b4
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Tue Nov 28 06:23:41 2017

MidiManagerAndroid: containers' clear and empty check were not matched

In Finalize(), MidiManagerAndroid clears |input_port_to_index_| and
|output_port_to_index_| explicitly, but checks |all_input_ports| and
|all_output_ports| to be empty in the destructor.

We should clear and check all four members in Finalize() and destructor.

Bug:  788684 
Change-Id: Ia60f57a6faedb89559b0bb1019605bbcc0b78522
Reviewed-on: https://chromium-review.googlesource.com/790076
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519590}
[modify] https://crrev.com/d9de72a68487e0821370115aef972c04ec7257b4/media/midi/midi_manager_android.cc

Comment 3 by toyoshim@chromium.org, Nov 28 2017

Owner: toyoshim@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment