New issue
Advanced search Search tips

Issue 788682 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 771126
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 714618



Sign in to add a comment

Security: Unmasked Password incorrectly cleared after changing search criteria

Reported by mail2al...@gmail.com, Nov 27 2017

Issue description

Hello,

With the password management page and filtering a given site, I can see the password by clicking on the show button after entering password of the OS session. Then, by deleting the value entered in the filter field, the password displayed before remains visible for the first site in the list and that prevents me from seeing the password of the latter. The capture shows the problem encountered after emptying the filter field. Thank you.
Regards,
Ali


Google Chrome
Google Chrome is up to date
Version 62.0.3202.94 (Official Build) (64-bit)


 
Components: UI>Browser>Passwords UI>Browser>WebUI
Labels: Restrict-View-SecurityEmbargo
Summary: Security: Password is still visible after unmasking (was: Security: Password is still visible after )
This looks like a minor functional bug rather than a security issue, but the user seems to have displayed an actual password, so setting Restrict-View-SecurityEmbargo.
Components: -UI>Browser>WebUI UI>Settings
Labels: -Type-Bug-Security -Restrict-View-SecurityEmbargo -Restrict-View-SecurityTeam OS-Chrome OS-Linux OS-Mac OS-Windows Type-Bug
Status: Untriaged (was: Unconfirmed)
Summary: Security: Unmasked Password incorrectly cleared after changing search criteria (was: Security: Password is still visible after unmasking)
This is indeed a functional bug; confirmed repro on Chrome 63. Deleting screenshots with PII.

1. Visit chrome://settings/passwords
2. Unmask the first password.
3. Perform a search using the UI on the tab that returns an account OTHER than the one you unmasked

Observe: The unmasked password is shown as if it were the password of the first search result.
Labels: Needs-Bisect Needs-Triage-M63
Cc: jdoerrie@chromium.org
The getPassword_ function inside show_password_behavior.js gets confused such that a previously-retrieved password is returned (e.g. "this.password") even for a different |item|. I don't know much about Polymer, but it looks like iron-list reuses template nodes, which would imply that a single behavior could be reused for different items?

show_password_behavior.js hasn't changed since it landed in 62.0.3175.0 via crrev.com/491454.

Comment 5 by vabr@chromium.org, Nov 28 2017

Blocking: 714618
Labels: Hotlist-Polish Pri-3
Status: Available (was: Untriaged)
jdoerrie@, who investigated this area most recently is already Cc-ed. There is no doubt that this has been an issue, so marking as Available.
Mergedinto: 771126
Status: Duplicate (was: Available)

Sign in to add a comment