New issue
Advanced search Search tips

Issue 788681 link

Starred by 1 user
Status: Assigned
Owner:
mek@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 611935



Sign in to add a comment

[mojo-blobs] Investigate proper type to use for status in BlobReaderClient

Project Member Reported by mek@chromium.org, Nov 27 2017 
Currently the BlobReaderClient mojo interface reports status as a net::Error. Maybe it would be cleaner to have a separate blob specific enum instead (or in addition to) the net::Error.

The reason this currently uses net::Error is because internally in the blob system that's what is being used, and furthermore I was envisioning future situations where we might want to implement the blob URLLoader on top of the Blob mojo interface, in which case converting net::Error to some other type to then convert it back to net::Error seemed suboptimal.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/869d4ca5d25d35a0fe3c72a4f113bdb927d4876d

commit 869d4ca5d25d35a0fe3c72a4f113bdb927d4876d
Author: Daniel Murphy <dmurph@chromium.org>
Date: Mon Apr 02 22:21:08 2018

Adding blob reading error metrics, re-enabling IDB large value wrapping

This change is to further investigate crbug/756447:
* Fixes some vague error reporting in BlobReader
* Adds a feature flag around IDB big value wrapping (and re-enables it)
* Adds UMA metrics around blob reading and IDB large value reading.

Bug:  756447 , 788681
Change-Id: I398fee4e69582e76f0a81449ff26a45ec3abe32f
Reviewed-on: https://chromium-review.googlesource.com/988843
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547537}
[modify] https://crrev.com/869d4ca5d25d35a0fe3c72a4f113bdb927d4876d/content/browser/blob_storage/blob_url_unittest.cc
[modify] https://crrev.com/869d4ca5d25d35a0fe3c72a4f113bdb927d4876d/storage/browser/blob/blob_reader.cc
[modify] https://crrev.com/869d4ca5d25d35a0fe3c72a4f113bdb927d4876d/storage/browser/blob/blob_reader_unittest.cc
[modify] https://crrev.com/869d4ca5d25d35a0fe3c72a4f113bdb927d4876d/third_party/WebKit/Source/DEPS
[modify] https://crrev.com/869d4ca5d25d35a0fe3c72a4f113bdb927d4876d/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp
[modify] https://crrev.com/869d4ca5d25d35a0fe3c72a4f113bdb927d4876d/third_party/WebKit/Source/core/fileapi/FileReaderLoader.h
[modify] https://crrev.com/869d4ca5d25d35a0fe3c72a4f113bdb927d4876d/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
[modify] https://crrev.com/869d4ca5d25d35a0fe3c72a4f113bdb927d4876d/third_party/WebKit/Source/modules/indexeddb/IDBRequestLoader.cpp
[modify] https://crrev.com/869d4ca5d25d35a0fe3c72a4f113bdb927d4876d/third_party/WebKit/Source/modules/indexeddb/IDBValueWrapping.h
[modify] https://crrev.com/869d4ca5d25d35a0fe3c72a4f113bdb927d4876d/third_party/WebKit/Tools/Scripts/audit-non-blink-usage.py
[modify] https://crrev.com/869d4ca5d25d35a0fe3c72a4f113bdb927d4876d/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b5df969c1c811274ce6331a4d2360a444c46323

commit 0b5df969c1c811274ce6331a4d2360a444c46323
Author: Daniel Murphy <dmurph@chromium.org>
Date: Thu Apr 05 04:07:01 2018

[BlobStorage] Fixed reading metrics error value

Bug:  756447 , 788681
Change-Id: I6cd4d87384bd55f7168a6c8889c631f2f7d9c015
Reviewed-on: https://chromium-review.googlesource.com/996461
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548320}
[modify] https://crrev.com/0b5df969c1c811274ce6331a4d2360a444c46323/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp
[modify] https://crrev.com/0b5df969c1c811274ce6331a4d2360a444c46323/third_party/WebKit/Source/modules/indexeddb/IDBRequestLoader.cpp
►

Sign in to add a comment