New issue
Advanced search Search tips

Issue 788660 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Tracking bug for improvements to Password Manager Settings page on Android

Project Member Reported by melandory@chromium.org, Nov 27 2017

Issue description

Tracks changes for the password manager settings page.
 
Old state. On/Of switch is displayed.
Screenshot_20171127-115851.png
92.8 KB View Download
New state On/Off switch isn't displayed anymore
Screenshot_20171127-115821.png
114 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6b0df376ac25ced6d0f9f3e5ea9623b1a2c56a0

commit a6b0df376ac25ced6d0f9f3e5ea9623b1a2c56a0
Author: Tatiana Gornak <melandory@chromium.org>
Date: Tue Nov 28 11:08:09 2017

Remove Password manager status indicator from Main Prefs page

BUG=788660

Change-Id: I404f1d9efb3e0b1df2119ff3ea7981988ebf3c76
Reviewed-on: https://chromium-review.googlesource.com/788913
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519649}
[modify] https://crrev.com/a6b0df376ac25ced6d0f9f3e5ea9623b1a2c56a0/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java

Comment 4 by vabr@chromium.org, Feb 28 2018

Adding phone screenshots for https://crrev.com/c/941215, which changes the settings title.
main-settings.png
78.3 KB View Download
inside-passwords.png
75.0 KB View Download
LGTM. Thanks, Vaclav!
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca4ffa3dc0ac4ab2120e72140bb41685d2ad2719

commit ca4ffa3dc0ac4ab2120e72140bb41685d2ad2719
Author: Vaclav Brozek <vabr@chromium.org>
Date: Wed Feb 28 18:13:44 2018

[Android settings] Call password settings "Passwords"

Based on a UI review decision (go/pppme), the title of the passwords
settings on Android should be just "Passwords", instead of the dated
"Save passwords" -- the settings page offers much more than the
ability to switch password manager on or off.

This CL splits the string used for the settings title and for the
switch of the "save passwords" preference. It changes the former to
"Passwords" and keeps the latter "Save passwords".

Screenshots: https://crbug.com/788660#c4

Bug: 788660
Change-Id: I699b753932c379f971b13ada69470f807627ea7a
Reviewed-on: https://chromium-review.googlesource.com/941215
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539885}
[modify] https://crrev.com/ca4ffa3dc0ac4ab2120e72140bb41685d2ad2719/chrome/android/java/res/xml/main_preferences.xml
[modify] https://crrev.com/ca4ffa3dc0ac4ab2120e72140bb41685d2ad2719/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
[modify] https://crrev.com/ca4ffa3dc0ac4ab2120e72140bb41685d2ad2719/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/ca4ffa3dc0ac4ab2120e72140bb41685d2ad2719/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java

Owner: ----
Status: Available (was: Assigned)
Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Sign in to add a comment