For enabling/disabling debug recording, Browser process will communicate with Audio Process using Mojo IPC.
For enabling/disabling debug recording, Browser process will communicate with Audio Process using Mojo IPC. Design doc: go/debug-recording-mojo-design
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e47cfcb255b1fedf1a8770ba1fbae9f113c7564 commit 4e47cfcb255b1fedf1a8770ba1fbae9f113c7564 Author: Marina Ciocea <marinaciocea@chromium.org> Date: Mon Nov 27 11:41:36 2017 rename GetOutputDebugRecordingFileNameWithExtensions Remove "Output" from function name and update ASCII diagram to reflect that AudioDebugRecordingManager is used for recording both input and output audio streams. Bug: 788657 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie86a4e5daf446ca2f82c895117ee810ca33449ae Reviewed-on: https://chromium-review.googlesource.com/789834 Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#519278} [modify] https://crrev.com/4e47cfcb255b1fedf1a8770ba1fbae9f113c7564/media/audio/audio_debug_recording_manager.cc [modify] https://crrev.com/4e47cfcb255b1fedf1a8770ba1fbae9f113c7564/media/audio/audio_debug_recording_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a65a5c4d697f594fc21ec2bb069041c9375bf2c commit 0a65a5c4d697f594fc21ec2bb069041c9375bf2c Author: Marina Ciocea <marinaciocea@chromium.org> Date: Thu Jan 11 22:50:54 2018 Create debug recording files in audio debug recording manager. Move file creation responsibility from audio debug file writer to audio debug recording manager. This is needed for debug recording mojofication. Bug: 788657 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If6b111c33f8c13f43a6c96bc8613ce862c21dc6b Reviewed-on: https://chromium-review.googlesource.com/832434 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#528791} [modify] https://crrev.com/0a65a5c4d697f594fc21ec2bb069041c9375bf2c/media/audio/audio_debug_file_writer.cc [modify] https://crrev.com/0a65a5c4d697f594fc21ec2bb069041c9375bf2c/media/audio/audio_debug_file_writer.h [modify] https://crrev.com/0a65a5c4d697f594fc21ec2bb069041c9375bf2c/media/audio/audio_debug_file_writer_unittest.cc [modify] https://crrev.com/0a65a5c4d697f594fc21ec2bb069041c9375bf2c/media/audio/audio_debug_recording_helper.cc [modify] https://crrev.com/0a65a5c4d697f594fc21ec2bb069041c9375bf2c/media/audio/audio_debug_recording_helper.h [modify] https://crrev.com/0a65a5c4d697f594fc21ec2bb069041c9375bf2c/media/audio/audio_debug_recording_helper_unittest.cc [modify] https://crrev.com/0a65a5c4d697f594fc21ec2bb069041c9375bf2c/media/audio/audio_debug_recording_manager.cc [modify] https://crrev.com/0a65a5c4d697f594fc21ec2bb069041c9375bf2c/media/audio/audio_debug_recording_manager_unittest.cc [modify] https://crrev.com/0a65a5c4d697f594fc21ec2bb069041c9375bf2c/media/audio/mock_audio_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c472a279c82ff2a858a0517c9d306c6058f18599 commit c472a279c82ff2a858a0517c9d306c6058f18599 Author: Marina Ciocea <marinaciocea@chromium.org> Date: Tue Feb 06 20:26:16 2018 Update interface for enabling/disabling debug recording in media/. * Remove EnableDebugRecording/DisableDebugRecording from AudioManager, and add a getter for AudioDebugRecordingManager instead, used by AudioDebugRecordingSessionImpl to toggle debug recording directly on AudioDebugRecordingManager. * Pass a file creation callback instead of file name to AudioDebugRecordingManager::EnableDebugRecording. * Move CreateFile from AudioDebugRecordingManager to AudioDebugRecordingSessionImpl. * Add unittest for AudioDebugRecordingSessionImpl.cc:CreateFile. * Add MockAudioDebugRecordingManager. * Rename AudioDebugFileWriter::GetFileNameExtension to GetFileExtension, so that it's not confused with extensions of filename, e.g output.<ID>. Bug: 788657 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9d0c4323f0e9630185d5e8af81c9e1b8f7b07a71 Reviewed-on: https://chromium-review.googlesource.com/881501 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#534780} [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/BUILD.gn [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_debug_file_writer.cc [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_debug_file_writer.h [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_debug_file_writer_unittest.cc [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_debug_recording_helper.cc [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_debug_recording_helper.h [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_debug_recording_helper_unittest.cc [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_debug_recording_manager.cc [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_debug_recording_manager.h [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_debug_recording_manager_unittest.cc [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_debug_recording_session.cc [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_debug_recording_session_impl.cc [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_debug_recording_session_impl_unittest.cc [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_manager.h [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_manager_base.cc [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_manager_base.h [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/audio_manager_unittest.cc [add] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/mock_audio_debug_recording_manager.cc [add] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/mock_audio_debug_recording_manager.h [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/mock_audio_manager.cc [modify] https://crrev.com/c472a279c82ff2a858a0517c9d306c6058f18599/media/audio/mock_audio_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec commit c6d46d2f6d9f5e4c2253159ac23bd0371443fdec Author: Marina Ciocea <marinaciocea@chromium.org> Date: Mon Feb 26 15:21:28 2018 Introduce debug recording Mojo implementation. * add mojo interfaces for enabling debug recording and creating debug recording files. * add debug recording session factory to toggle between media/audio/ and services/audio/ debug recording implementations. Design doc: http://doc/123YGEhyyDqbO1440rwdg0T_4UPxNyZmJboczjFIZpMI#heading=h.xpzwbhip9is6 This CL depends on [1]. Switching to mojo implementation will be done in [2]. [1] https://crrev.com/c/875927 [2] https://crrev.com/c/921281 Bug: 788657 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idbbfdb89c6ad4ff373ac25db83b5ed4ef6167b86 Reviewed-on: https://chromium-review.googlesource.com/810809 Reviewed-by: Tommi <tommi@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#539134} [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/chrome/browser/BUILD.gn [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/chrome/browser/media/webrtc/DEPS [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/chrome/browser/media/webrtc/audio_debug_recordings_handler.cc [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/content/browser/webrtc/webrtc_internals.cc [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/BUILD.gn [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/audio_debug_file_writer.cc [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/audio_debug_file_writer.h [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/audio_debug_file_writer_unittest.cc [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/audio_debug_recording_helper.cc [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/audio_debug_recording_helper.h [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/audio_debug_recording_helper_unittest.cc [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/audio_debug_recording_manager.cc [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/audio_debug_recording_manager.h [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/audio_debug_recording_manager_unittest.cc [delete] https://crrev.com/5a9ac91df06db70b4353bc9adaa8d6f48d17df85/media/audio/audio_debug_recording_session.cc [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/audio_debug_recording_session.h [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/audio_debug_recording_session_impl.cc [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/audio_debug_recording_session_impl_unittest.cc [add] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/audio_debug_recording_test.cc [add] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/media/audio/audio_debug_recording_test.h [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/BUILD.gn [add] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/debug_recording.cc [add] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/debug_recording.h [add] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/debug_recording_unittest.cc [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/manifest.json [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/public/cpp/BUILD.gn [add] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/public/cpp/debug_recording_session.cc [add] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/public/cpp/debug_recording_session.h [add] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/public/cpp/debug_recording_session_factory.cc [add] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/public/cpp/debug_recording_session_factory.h [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/public/mojom/BUILD.gn [add] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/public/mojom/debug_recording.mojom [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/service.cc [modify] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/service.h [add] https://crrev.com/c6d46d2f6d9f5e4c2253159ac23bd0371443fdec/services/audio/test/debug_recording_session_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/307aeaf345e71b502ecef84da59243370a97da8d commit 307aeaf345e71b502ecef84da59243370a97da8d Author: Marina Ciocea <marinaciocea@chromium.org> Date: Mon Mar 05 10:01:01 2018 Pass stream type and ID to mojom::DebugRecordingFileProvider. Following discussion from [1], I updated DebugRecordingFileProvider interface to take stream type and ID instead of FilePath suffix as input, and build file suffix in interface implementation. This CL introduces duplicate code in media/audio/audio_debug_recording_session_impl.cc, that will be removed after switching to mojo implementation [2]. [1] https://crrev.com/c/810809/40/services/audio/public/mojom/debug_recording.mojom#18 [2] https://crrev.com/c/921281 Bug: 788657 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2e656797be3ca4663eb9393e74df7a73785e02a2 Reviewed-on: https://chromium-review.googlesource.com/941949 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#540799} [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/media/audio/audio_debug_recording_helper.cc [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/media/audio/audio_debug_recording_helper.h [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/media/audio/audio_debug_recording_helper_unittest.cc [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/media/audio/audio_debug_recording_manager.cc [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/media/audio/audio_debug_recording_manager.h [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/media/audio/audio_debug_recording_manager_unittest.cc [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/media/audio/audio_debug_recording_session_impl.cc [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/media/audio/audio_debug_recording_session_impl_unittest.cc [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/media/audio/audio_manager_base.cc [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/media/audio/mock_audio_debug_recording_manager.h [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/services/audio/debug_recording.cc [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/services/audio/debug_recording.h [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/services/audio/debug_recording_unittest.cc [add] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/services/audio/public/cpp/debug_recording.typemap [add] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/services/audio/public/cpp/debug_recording_mojom_traits.cc [add] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/services/audio/public/cpp/debug_recording_mojom_traits.h [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/services/audio/public/cpp/debug_recording_session.cc [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/services/audio/public/cpp/debug_recording_session.h [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/services/audio/public/cpp/typemaps.gni [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/services/audio/public/mojom/debug_recording.mojom [modify] https://crrev.com/307aeaf345e71b502ecef84da59243370a97da8d/services/audio/test/debug_recording_session_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/222973e48f26fc2b26045ed3ed5d8fd36757b40e commit 222973e48f26fc2b26045ed3ed5d8fd36757b40e Author: Marina Ciocea <marinaciocea@chromium.org> Date: Mon Mar 05 13:48:05 2018 Switch debug recording to Mojo implementation. Bug: 788657 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idb284c691eec3b6c468431c2a16ae2a7977211cf Reviewed-on: https://chromium-review.googlesource.com/921281 Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#540812} [modify] https://crrev.com/222973e48f26fc2b26045ed3ed5d8fd36757b40e/services/audio/public/cpp/debug_recording_session_factory.cc
Comment 1 by bugdroid1@chromium.org
, Nov 27 2017