New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788656 link

Starred by 3 users
Status: Fixed
Owner:
█ mcgreevy@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
ajha@chromium.org
█ brajkumar@chromium.org
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Able to navigate to other links/pages when Add to Desktop overlay is present

Project Member Reported by sc00335...@techmahindra.com, Nov 27 2017 
Chrome Version: 64.0.3278.0
OS: Windows, Linux

What steps will reproduce the problem?
(1) Navigate to any webpage >> Click on 3 dot menu
(2) More tools >> select Add to Desktop 
(3) Click on any links on background tab or open new tab and observe

Expected: Should not be able to interact with background tab and open new tab or exit chrome.

Actual: Instead able to interact with other links and tabs present.

NOTE: Add to desktop option is not available in Mac

This is a regression issue broken in M64.

Good Build: 64.0.3270.0
Bad Build: 64.0.3271.0

You are probably looking for a change made after 517017 (known good), but no later than 517018 (first known bad).
CHANGELOG URL:
 https://chromium.googlesource.com/chromium/src/+log/f01395ff3538341da0ea9eec0978a15afa26f3e2..556227a5a0ebb6a048b8ae89648b306a88f74c84

Reviewed-on: https://chromium-review.googlesource.com/726958

Suspecting same from changelog.

@mcgreevy: Please confirm whether this is an issue or intended change.

Adding RB-Stable as this is a recent regression. Please remove if not the case.

Thanks!
Actual_add to desktop.ogv
961 KB View Download
Expected_add to desktop.ogv
899 KB View Download

Comment 1 by mcgreevy@chromium.org, Nov 27 2017 

Thanks for the report. This is an unintended change. I'm preparing a fix now.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba884046d8371d4327e034d57ca097c520b240a3

commit ba884046d8371d4327e034d57ca097c520b240a3
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Tue Nov 28 05:47:02 2017

Make app install dialogs modal.

The dialogs should be tab modal, but don't currently attach properly to
the WebContentsModalDialogManager.
Using ShowWebModalDialogViews(..) fixes the attachment.

Bug:  788656 
Change-Id: Ib4fcb4c5597e831fad027364b278f1f28be89dae
Reviewed-on: https://chromium-review.googlesource.com/792370
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519583}
[modify] https://crrev.com/ba884046d8371d4327e034d57ca097c520b240a3/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc
[modify] https://crrev.com/ba884046d8371d4327e034d57ca097c520b240a3/chrome/browser/ui/views/extensions/pwa_confirmation_view.cc
[modify] https://crrev.com/ba884046d8371d4327e034d57ca097c520b240a3/chrome/browser/ui/views/extensions/pwa_confirmation_view_browsertest.cc

Comment 3 by mcgreevy@chromium.org, Nov 28 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment