New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788649 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove dead code left behind by emojiHandwritingVoice notification refactoring

Project Member Reported by blakeo@chromium.org, Nov 27 2017

Issue description

After refactoring the notification to mojo, it seems the old IsEmojiHandwritingVoiceOnImeMenuEnabled() was left behind.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/303fe8e6f6e3d02495021d190c9a68cd4edbb26d

commit 303fe8e6f6e3d02495021d190c9a68cd4edbb26d
Author: Blake O'Hare <blakeo@chromium.org>
Date: Tue Nov 28 04:17:59 2017

Remove dead code leftover from crrev.com/c/675084

Either 675084 left this code dead or any remaining usage was removed
afterwards. Either way, it's safe to remove now.

My dream of fixing a CL with an identical bug number was narrowly
thwarted. :(

Bug:  788649 
Change-Id: Icc408f328be611cff06320f4a93e81d0757e153b
Reviewed-on: https://chromium-review.googlesource.com/788648
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519563}
[modify] https://crrev.com/303fe8e6f6e3d02495021d190c9a68cd4edbb26d/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
[modify] https://crrev.com/303fe8e6f6e3d02495021d190c9a68cd4edbb26d/chrome/browser/chromeos/input_method/input_method_manager_impl.h
[modify] https://crrev.com/303fe8e6f6e3d02495021d190c9a68cd4edbb26d/ui/base/ime/chromeos/input_method_manager.h
[modify] https://crrev.com/303fe8e6f6e3d02495021d190c9a68cd4edbb26d/ui/base/ime/chromeos/mock_input_method_manager.cc
[modify] https://crrev.com/303fe8e6f6e3d02495021d190c9a68cd4edbb26d/ui/base/ime/chromeos/mock_input_method_manager.h

Comment 2 by blakeo@chromium.org, Dec 22 2017

Status: Fixed (was: Assigned)

Sign in to add a comment