Widespread external/wpt failures on webkit_layout_tests |
||
Issue descriptionwebkit_layout_tests failing on chromium.webkit/WebKit Mac10.11 Builders failed on: - WebKit Mac10.11: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11 (among others, likely all of them as they catch up.) The failures look like: FAIL File interface: existence and properties of interface object assert_equals: prototype of File is not Blob expected function "function Blob() { [native code] }" but got function "function () { [native code] }" (see https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=277745ce199536f7f4d90a0517d1d28eff134768&as=idlharness-actual.txt) I suspect r519227. I will revert it to see what happens.
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eac49849835e9859e9e7a0d1005207757ef2ed37 commit eac49849835e9859e9e7a0d1005207757ef2ed37 Author: Greg Thompson <grt@chromium.org> Date: Mon Nov 27 09:15:41 2017 Revert "bindings: Merge ConstructorForTypeSlowCase and ContructorPlainType" This reverts commit 7bd06facab4413a6e14c6dfb447db17e0f08e888. Reason for revert: Tentative revert for widespread external/wpt failures on webkit_layout_tests; see https://crbug.com/788644 . Original change's description: > bindings: Merge ConstructorForTypeSlowCase and ContructorPlainType > > We had ConstructorPlainType in V8ContextSnapshots.cpp independent from > V8PerContextData::ConstructorForTypeSlowCase only not to use cached one. > So they are almost copy of each other. > > This CL makes the common part as an independent function, and make old two > functions to use the new one for their main tasks. > > > Bug: None > Change-Id: Iec40475f2507c2de3a75b450ae83b1041c6dd2b9 > Reviewed-on: https://chromium-review.googlesource.com/763033 > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519227} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org Change-Id: I55e9b5d003dac6bf4d14eb359ae9812933f97a93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 788644 Reviewed-on: https://chromium-review.googlesource.com/789877 Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#519250} [modify] https://crrev.com/eac49849835e9859e9e7a0d1005207757ef2ed37/third_party/WebKit/Source/bindings/core/v8/V8ContextSnapshot.cpp [modify] https://crrev.com/eac49849835e9859e9e7a0d1005207757ef2ed37/third_party/WebKit/Source/platform/bindings/V8ObjectConstructor.cpp [modify] https://crrev.com/eac49849835e9859e9e7a0d1005207757ef2ed37/third_party/WebKit/Source/platform/bindings/V8ObjectConstructor.h [modify] https://crrev.com/eac49849835e9859e9e7a0d1005207757ef2ed37/third_party/WebKit/Source/platform/bindings/V8PerContextData.cpp
,
Nov 27 2017
The revert did the trick for now. Good luck with your next attempt!
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f47b361887a31cccf42a6e21a82bccf28372bdaa commit f47b361887a31cccf42a6e21a82bccf28372bdaa Author: Hitoshi Yoshida <peria@chromium.org> Date: Thu Nov 30 15:49:55 2017 bindings: Merge ConstructorForTypeSlowCase and ContructorPlainType We had ConstructorPlainType in V8ContextSnapshots.cpp independent from V8PerContextData::ConstructorForTypeSlowCase only not to use cached one. So they are almost copy of each other. This CL makes the common part as an independent function, and make old two functions to use the new one for their main tasks. Bug: 788644 Change-Id: I782a48668b2d9716c0919413bfcb515424a06d98 Reviewed-on: https://chromium-review.googlesource.com/795282 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#520552} [modify] https://crrev.com/f47b361887a31cccf42a6e21a82bccf28372bdaa/third_party/WebKit/Source/bindings/core/v8/V8ContextSnapshot.cpp [modify] https://crrev.com/f47b361887a31cccf42a6e21a82bccf28372bdaa/third_party/WebKit/Source/platform/bindings/V8ObjectConstructor.cpp [modify] https://crrev.com/f47b361887a31cccf42a6e21a82bccf28372bdaa/third_party/WebKit/Source/platform/bindings/V8ObjectConstructor.h [modify] https://crrev.com/f47b361887a31cccf42a6e21a82bccf28372bdaa/third_party/WebKit/Source/platform/bindings/V8PerContextData.cpp |
||
►
Sign in to add a comment |
||
Comment 1 by grt@chromium.org
, Nov 27 2017Labels: -Sheriff-Chromium
Owner: peria@chromium.org
Status: Assigned (was: Available)