Don't set distribution recalc flag if UA shadow root doesn't use <content> elements |
|||
Issue description
fast/dom/shadow/no-renderers-for-light-children.html is crashing with IncrementalShadowDOM flag.
It looks <input type="datetime" /> is using UA shadow root, but isn't using <content> element there.
We don't need to set distribution recalc flag in such a case because it is guaranteed that we don't need to reclac distribution for the shadow tree.
====
fast/dom/shadow/no-renderers-for-light-children.html
*#document
HTML
HEAD
#text "\n"
SCRIPT
#text "\n\nif (window.testRunner)\n testRunner.dumpAsText();\n\nwindow.addEventListener('load', function()\n{\n document.getElementsByTagName('input')[0].appendChild(document.createTextNode('FAIL'));\n}, false);\n\n"
#text "\n"
#text "\n"
BODY
#text "\nChildren of an element are never rendered if it has a shadow DOM subtree."
BR
#text "\nShould not see the word FAIL below."
BR
#text "\n"
INPUT
#shadow-root(UserAgent)
DIV (editable)
#text "FAIL"
#text "\n\n\n"
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfa2cf8cf5a7c188e3962801ece398406dae4ecf commit dfa2cf8cf5a7c188e3962801ece398406dae4ecf Author: Hayato Ito <hayato@chromium.org> Date: Mon Nov 27 10:48:38 2017 [IncrementalShadowDOM] Update bug id for fast/dom/shadow/ tests which crash with the flag TBR=kochi Bug: 787717 , 788608 , 788610 , 788623 , 788635 Change-Id: I82f8502fc336739022f7de36cb7aaf6dd7934b90 Reviewed-on: https://chromium-review.googlesource.com/790042 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#519270} [modify] https://crrev.com/dfa2cf8cf5a7c188e3962801ece398406dae4ecf/third_party/WebKit/LayoutTests/TestExpectations
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae25118dfc992270cfa42ea85d5b94b9d2b1a454 commit ae25118dfc992270cfa42ea85d5b94b9d2b1a454 Author: Hayato Ito <hayato@chromium.org> Date: Tue Nov 28 05:28:28 2017 [IncrementalShadowDOM] Update bug id for external/wpt/shadow-dom/ tests which crash with the flag virtual/incremental-shadow-dom/external/wpt/shadow-dom/slotchange-event.html is failing for other reasons, which I'll look deeper later. TBR=kochi Bug: 788608 , 788635 Change-Id: I1e5cb26d7202588b02b04d871e614e178b20225d Reviewed-on: https://chromium-review.googlesource.com/792832 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#519578} [modify] https://crrev.com/ae25118dfc992270cfa42ea85d5b94b9d2b1a454/third_party/WebKit/LayoutTests/TestExpectations
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3f0217877ba2312aa39e1bcdc6d4a0ae1b04d49 commit b3f0217877ba2312aa39e1bcdc6d4a0ae1b04d49 Author: Takayoshi Kochi <kochi@chromium.org> Date: Fri Dec 15 02:19:03 2017 Remove layout tests that depend on multiple shadow roots They happened to pass because they are ref tests and they expected no change after adding multiple shadow root (with <shadow> inside author shadow, etc.). Bug: 788635 Change-Id: I514a66fe1c0dbcd2ea724d60c4a392ddef34f92e Reviewed-on: https://chromium-review.googlesource.com/826327 Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#524294} [modify] https://crrev.com/b3f0217877ba2312aa39e1bcdc6d4a0ae1b04d49/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-only-shadow-expected.html [delete] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-only-shadow.html [delete] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-with-attribute-expected.html [delete] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-with-attribute.html [delete] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-with-style-expected.html [delete] https://crrev.com/5735cf1d89e23baa6c1e4edc6541d9fd1eed6009/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-with-style.html
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dacffa53f8006988a14be38293ad77755803dac6 commit dacffa53f8006988a14be38293ad77755803dac6 Author: Takayoshi Kochi <kochi@chromium.org> Date: Tue Dec 19 05:29:43 2017 Remove passing failure expectations for incremental-shadow-dom 20 virtual/incremental-shadow-dom expected failures are already passing. Remove these entries from the TestExpectations file. TBR=hayato@chromium.org Bug: 776656 , 788635 Change-Id: I8483a342fe762f0ceb447108e3bb89e183613bb1 Reviewed-on: https://chromium-review.googlesource.com/832293 Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#524947} [modify] https://crrev.com/dacffa53f8006988a14be38293ad77755803dac6/third_party/WebKit/LayoutTests/TestExpectations
,
Dec 27 2017
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3853c0b84da0994c4d28ca8c38737d257e95075 commit f3853c0b84da0994c4d28ca8c38737d257e95075 Author: Takayoshi Kochi <kochi@chromium.org> Date: Fri Jan 12 05:23:19 2018 Convert V0 UA shadow in <meter> to use V1 In <meter> element, <content> in V0 UA shadow was used to hold its fallback contents, and the contents will become visible when it gets styled as '-webkit-appearance: none'. This CL changes the <content> with <slot> which has "user agent default slot" semantics. The <meter>'s V1 UA shadow root looks like: <meter> #shadow-root <div pseudo="-webkit-meter-inner-element"> <div pseudo="-webkit-meter-bar"> <div pseudo="-webkit-meter-optimum-value" style="width: 0%;"> </div> </div> </div> <div pseudo="-internal-fallback"> <slot></slot> </div> </meter> Bug: 787717 , 788635 Change-Id: I820996da7b6ba0c053dbf6117cadc6a6c3a9a76f Reviewed-on: https://chromium-review.googlesource.com/799516 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#528884} [modify] https://crrev.com/f3853c0b84da0994c4d28ca8c38737d257e95075/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/f3853c0b84da0994c4d28ca8c38737d257e95075/third_party/WebKit/LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt [add] https://crrev.com/f3853c0b84da0994c4d28ca8c38737d257e95075/third_party/WebKit/LayoutTests/shadow-dom/ua/meter-and-ua-shadow.html [add] https://crrev.com/f3853c0b84da0994c4d28ca8c38737d257e95075/third_party/WebKit/LayoutTests/shadow-dom/ua/meter-fallback-expected.html [add] https://crrev.com/f3853c0b84da0994c4d28ca8c38737d257e95075/third_party/WebKit/LayoutTests/shadow-dom/ua/meter-fallback.html [modify] https://crrev.com/f3853c0b84da0994c4d28ca8c38737d257e95075/third_party/WebKit/Source/core/html/HTMLMeterElement.cpp
,
Jan 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a064b39bd3c9e2be6df1f41b656e10249524f62c commit a064b39bd3c9e2be6df1f41b656e10249524f62c Author: Takayoshi Kochi <kochi@chromium.org> Date: Mon Jan 15 07:28:34 2018 Convert V0 UA shadow in <progress> to use V1 This is a part of conversion from V0 UA shadow to V1. <progress> element doesn't have any <contents> element, thus the conversion is straightforward to set V1 type. The internal of <progress>'s UA shadow looks like this: <progress> #shadow-root <div pseudo="-webkit-progress-inner-element"> <div pseudo="-webkit-progress-bar"> <div pseudo="-webkit-progress-value"> </div> </div> </div> Bug: 788635 , 787717 Change-Id: I743f5c99a8273f29cefe18a9e8789c43eec47f4a Reviewed-on: https://chromium-review.googlesource.com/866276 Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#529218} [modify] https://crrev.com/a064b39bd3c9e2be6df1f41b656e10249524f62c/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/a064b39bd3c9e2be6df1f41b656e10249524f62c/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp
,
Jan 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e5cc04cd9a82d8c1f6594630e4b5fb21786857b commit 2e5cc04cd9a82d8c1f6594630e4b5fb21786857b Author: Takayoshi Kochi <kochi@chromium.org> Date: Mon Jan 15 07:42:36 2018 Remove passing entry in TestExpectations This test has become passing already by prior UA shadow V0->V1 conversion CLs. TBR=hayato@chromium.org Bug: 788635 Change-Id: I8a6afccaccdb3f31f4b15f885a3f949396de9ce6 Reviewed-on: https://chromium-review.googlesource.com/866596 Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#529221} [modify] https://crrev.com/2e5cc04cd9a82d8c1f6594630e4b5fb21786857b/third_party/WebKit/LayoutTests/TestExpectations
,
Jan 15 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by hayato@chromium.org
, Nov 27 2017