New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788610 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 793728

Blocking:
issue 787717



Sign in to add a comment

<details>/<summary> is using <content> elements.

Project Member Reported by hayato@chromium.org, Nov 27 2017

Issue description

fast/dom/shadow/content-child-whitespace-between-span.html is crashing with IncrementalShadowDOM flag.

*#document                                   
        DOCTYPE html                         
        HTML                                 
                HEAD                         
                        #text "\n"           
                        STYLE                
                                #text "\nsummary { display: none; }\nspan { background-color: red; }\n"                                                                               
                        #text "\n"           
                #text "\n"                   
                BODY                         
                        #text "\n"           
                        DIV                  
                                #text "\n"   
                                DIV          
                                        #text "\n"                                         
                                        DETAILS                                            
                                                #shadow-root                               
                                                        CONTENT id="details-summary"       
                                                                SUMMARY                    
                                                                        #shadow-root       
                                                                                DIV id="details-marker"                                                                               
                                                                                CONTENT    
                                                                        #text "Details"    
                                                        DIV id="details-content"           
                                                                CONTENT                    
                                                #text "\n"                                 
                                                DIV                                        
                                                        #text "Hello1"                     
                                                #text "\n"                                 
                                                SPAN                                       
                                                        #text "Hello2"                     
                                                #text "\n"                                 
                                                SPAN                                       
                                                        #text "Hello3"                     
                                                #text "\n"                                 
                                                SUMMARY                                    
                                                        #shadow-root                       
                                                                DIV id="details-marker"    
                                                                CONTENT                    
                                                #text "\n"                                 
                                        #text "\n"                                         
                                #text "\n"   
                        #text "\n\n\n"       

 

Comment 1 by hayato@chromium.org, Nov 27 2017

Blocking: 787717
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ad1af19ba0b43c8a9e1371e59393ba4d805aad3

commit 2ad1af19ba0b43c8a9e1371e59393ba4d805aad3
Author: Hayato Ito <hayato@chromium.org>
Date: Mon Nov 27 08:11:56 2017

[IncrementalShadowDOM] Update bug id for a test which uses <details>/<summary> and crashes

TBR=kochi

Bug:  788610 
Change-Id: Ia1bfd0a502c7d7a6f5a4790731c3bfc6ddd851e9
Reviewed-on: https://chromium-review.googlesource.com/790176
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519243}
[modify] https://crrev.com/2ad1af19ba0b43c8a9e1371e59393ba4d805aad3/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfa2cf8cf5a7c188e3962801ece398406dae4ecf

commit dfa2cf8cf5a7c188e3962801ece398406dae4ecf
Author: Hayato Ito <hayato@chromium.org>
Date: Mon Nov 27 10:48:38 2017

[IncrementalShadowDOM] Update bug id for fast/dom/shadow/ tests which crash with the flag

TBR=kochi

Bug:  787717 , 788608 , 788610 , 788623 , 788635 
Change-Id: I82f8502fc336739022f7de36cb7aaf6dd7934b90
Reviewed-on: https://chromium-review.googlesource.com/790042
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519270}
[modify] https://crrev.com/dfa2cf8cf5a7c188e3962801ece398406dae4ecf/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by kochi@chromium.org, Dec 11 2017

Blockedon: 793728

Comment 5 by kochi@chromium.org, Dec 27 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a

commit 56f2d861c19897381a5ad3bf1db19bf9a8fdac6a
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Thu Jan 11 17:02:27 2018

Convert V0 UA shadow in <summary> and <details> to V1

This CL introduces basis for the rest of elements that use
V0 UA shadow to be converted to V1 UA shadow, and uses it
for converting <summary> and <details>.

For V1 UA shadow root, we don't use the normal slot assignment
mechanism for V1 shadow roots, but use assignment filter, which
is similar to what we had internally for <details> element.
Design doc: https://goo.gl/Rcw1Nt

Convert <details> and <summary> to use V1 UA shadow root
will cover the use cases of <slot> usage in V1 UA shadow
root.  CLs for converting other elements will follow.

<summary> and <details>'s UA shadow internals are like this:

<summary>
  #shadow-root
    <div pseudo="-webkit-details-marker" id="details-marker"></div>
    <slot name="user-agent-default-slot"></slot>

<details>
  #shadow-root
    <slot name="user-agent-custom-assign-slot" id="details-summary">
      <summary>Details</summary>
    </slot>
    <div id="details-content">
      <slot name="user-agent-default-slot"></slot>
    </div>

Bug:  787717 ,  788610 ,  793728 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I67b11cb82174463581f66ec5e98e609737148aa2
Reviewed-on: https://chromium-review.googlesource.com/817716
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528645}
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/4b57e0551c56f232f64c95b6d92b480bfbbad8af/third_party/WebKit/LayoutTests/fast/dom/shadow/details-summary-distributed-expected.html
[delete] https://crrev.com/4b57e0551c56f232f64c95b6d92b480bfbbad8af/third_party/WebKit/LayoutTests/fast/dom/shadow/details-summary-distributed.html
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/LayoutTests/platform/linux/html/details_summary/details-remove-summary-1-and-click-expected.txt
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/LayoutTests/platform/linux/html/details_summary/details-remove-summary-4-and-click-expected.txt
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/LayoutTests/platform/mac/html/details_summary/details-remove-summary-1-and-click-expected.txt
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/LayoutTests/platform/mac/html/details_summary/details-remove-summary-4-and-click-expected.txt
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/LayoutTests/platform/win/html/details_summary/details-remove-summary-1-and-click-expected.txt
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/LayoutTests/platform/win/html/details_summary/details-remove-summary-4-and-click-expected.txt
[add] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/LayoutTests/shadow-dom/ua/summary-details-and-ua-shadow.html
[add] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/LayoutTests/shadow-dom/ua/summary-details-distribution-expected.html
[add] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/LayoutTests/shadow-dom/ua/summary-details-distribution.html
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/Source/core/dom/ShadowRoot.h
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/Source/core/dom/SlotAssignment.cpp
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/Source/core/dom/SlotAssignment.h
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/Source/core/html/HTMLContentElement.cpp
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/Source/core/html/HTMLContentElement.h
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/Source/core/html/HTMLDetailsElement.h
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/Source/core/html/HTMLSlotElement.h
[modify] https://crrev.com/56f2d861c19897381a5ad3bf1db19bf9a8fdac6a/third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp

Comment 7 by kochi@chromium.org, Jan 11 2018

Status: Fixed (was: Started)

Sign in to add a comment