New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788608 link

Starred by 2 users
Status: Fixed
Owner:
█ kochi@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
rakina@chromium.org
hayato@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 787717



Sign in to add a comment

<object> is using <content> elements.

Project Member Reported by hayato@chromium.org, Nov 27 2017 
LayoutTests/fast/dom/shadow/adopt-node-with-shadow-root.html  is crashing with IncrementlaShadowDOM flag.

*#document                                   
        DOCTYPE html                         
        HTML                                 
                HEAD                         
                        #text "\n"           
                        SCRIPT               
                        STYLE                
                                #text ".pass {font-weight: bold;color: green;}.fail {font-weight: bold;color: red;}#console {white-space: pre-wrap;font-family: monospace;}"          
                        #text "\n"           
                #text "\n"                   
                BODY                         
                        #text "\n"           
                        DIV id="console"     
                        #text "\n"           
                        OBJECT id="root"     
                                #shadow-root 
                                        CONTENT                                            
                                #text "\n"   
                                SCRIPT       
                                        #text "\nfunction test() {\n    var foreignDocument = document.getElementById('root').contentDocument;\n    shadow = foreignDocument.getElementById('s').createShadowRoot();\n    shouldThrow(\"document.adoptNode(shadow)\");\n}\n"
                                #text "\n\n\n"

Comment 1 by hayato@chromium.org, Nov 27 2017

Blocking: 787717
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b6faab999043d5f88b170d5ec740a7ee77d3aa3

commit 0b6faab999043d5f88b170d5ec740a7ee77d3aa3
Author: Hayato Ito <hayato@chromium.org>
Date: Mon Nov 27 06:55:01 2017

[IncrementalShadowDOM] Update bug id for a test which uses <object> and crashes

TBR=kochi

Bug:  788608 
Change-Id: Ie500c328487db1f2917ba1ed3366ca3663cf6022
Reviewed-on: https://chromium-review.googlesource.com/790052
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519231}
[modify] https://crrev.com/0b6faab999043d5f88b170d5ec740a7ee77d3aa3/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfa2cf8cf5a7c188e3962801ece398406dae4ecf

commit dfa2cf8cf5a7c188e3962801ece398406dae4ecf
Author: Hayato Ito <hayato@chromium.org>
Date: Mon Nov 27 10:48:38 2017

[IncrementalShadowDOM] Update bug id for fast/dom/shadow/ tests which crash with the flag

TBR=kochi

Bug:  787717 , 788608 , 788610 , 788623 , 788635 
Change-Id: I82f8502fc336739022f7de36cb7aaf6dd7934b90
Reviewed-on: https://chromium-review.googlesource.com/790042
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519270}
[modify] https://crrev.com/dfa2cf8cf5a7c188e3962801ece398406dae4ecf/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae25118dfc992270cfa42ea85d5b94b9d2b1a454

commit ae25118dfc992270cfa42ea85d5b94b9d2b1a454
Author: Hayato Ito <hayato@chromium.org>
Date: Tue Nov 28 05:28:28 2017

[IncrementalShadowDOM] Update bug id for external/wpt/shadow-dom/ tests which crash with the flag

virtual/incremental-shadow-dom/external/wpt/shadow-dom/slotchange-event.html is failing for other
reasons, which I'll look deeper later.

TBR=kochi

Bug:  788608 , 788635 
Change-Id: I1e5cb26d7202588b02b04d871e614e178b20225d
Reviewed-on: https://chromium-review.googlesource.com/792832
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519578}
[modify] https://crrev.com/ae25118dfc992270cfa42ea85d5b94b9d2b1a454/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by kochi@chromium.org, Dec 27 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb4692c0babd2fdd7f54e6f4f876a6e060d9bb8a

commit bb4692c0babd2fdd7f54e6f4f876a6e060d9bb8a
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Fri Jan 12 08:24:30 2018

Convert V0 UA shadow in <object> and <embed> to use V1

<object> and <embed> are both sharing the same UA shadow
implementation defined in HTMLPluginElement.cpp, and
their UA shadow root contains only a user agent default <slot>.

Bug:  787717 ,  788608 
Change-Id: I5d8289b3c8a096020a20352102d0a098286f67d3
Reviewed-on: https://chromium-review.googlesource.com/799611
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528906}
[modify] https://crrev.com/bb4692c0babd2fdd7f54e6f4f876a6e060d9bb8a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/bb4692c0babd2fdd7f54e6f4f876a6e060d9bb8a/third_party/WebKit/LayoutTests/editing/editability/ignored-content-expected.txt
[modify] https://crrev.com/bb4692c0babd2fdd7f54e6f4f876a6e060d9bb8a/third_party/WebKit/LayoutTests/editing/pasteboard/paste-noplugin-expected.txt
[modify] https://crrev.com/bb4692c0babd2fdd7f54e6f4f876a6e060d9bb8a/third_party/WebKit/LayoutTests/fast/parser/object-with-textarea-fallback-expected.txt
[modify] https://crrev.com/bb4692c0babd2fdd7f54e6f4f876a6e060d9bb8a/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
[modify] https://crrev.com/bb4692c0babd2fdd7f54e6f4f876a6e060d9bb8a/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/bb4692c0babd2fdd7f54e6f4f876a6e060d9bb8a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Comment 7 by kochi@chromium.org, Jan 12 2018

Status: Fixed (was: Started)
►

Sign in to add a comment