New issue
Advanced search Search tips

Issue 788604 link

Starred by 4 users
Status: Available
Owner: ----
Cc:
falken@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 540509



Sign in to add a comment

Remove foreign fetch and link rel=serviceworker

Project Member Reported by falken@chromium.org, Nov 27 2017 
Foreign fetch and link rel=serviceworker have been removed from the specification.

(Update) Bulk removed the code. Remaining tasks:
tasks/investigation:
* Clean up enums in service_worker_modes.h that only have one or two values now.
* Remove components/link_header_util <https://codereview.chromium.org/1811163002>
* In worker_fetch_context_impl.cc:
  // TODO(falken): Is still this needed? It used to set kForeign for foreign
  // fetch.
* Remove ServiceWorkerURLJobWrapper::Delegate. Now the only delegate is
ServiceWorkerControlleeRequestHandler since there is no more
ForeignFetchRequestHandler. But it might be useful to keep for unit tests.
* Remove UMA code and mark histograms as obsolete.
* Cleanup WPT registration-*html tests which were factored out into resources/registration*js files to share code with foreign fetch tests.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2898d2a95064276f84a6803253f15b0ea018f82a

commit 2898d2a95064276f84a6803253f15b0ea018f82a
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Nov 28 10:39:45 2017

service worker: Remove Foreign Fetch and Link registration tests.

These were removed from the specification:
https://github.com/w3c/ServiceWorker/commit/0d09f488c062f0db5d65a243da0bbddaec3de1dd

This also prepares for removal of Foreign Fetch + Link registration by
changing the status from experimental to disabled, so tests run with
them disabled.

Bug: 788604
Change-Id: I700a041b3d981872bf82c5573efa9ac8fd8feba9
Reviewed-on: https://chromium-review.googlesource.com/792754
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519639}
[modify] https://crrev.com/2898d2a95064276f84a6803253f15b0ea018f82a/third_party/WebKit/LayoutTests/external/wpt/html/dom/interfaces-expected.txt
[modify] https://crrev.com/2898d2a95064276f84a6803253f15b0ea018f82a/third_party/WebKit/LayoutTests/external/wpt/interfaces/html.idl
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/iframe-sandbox-register-link-element.https.html
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-basic.https.html
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-mime-types.https-expected.txt
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-mime-types.https.html
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-scope.https-expected.txt
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-scope.https.html
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-script-url.https-expected.txt
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-script-url.https.html
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-script.https-expected.txt
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-script.https.html
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-security-error.https.html
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/register-link-header.https.html
[modify] https://crrev.com/2898d2a95064276f84a6803253f15b0ea018f82a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/registration-updateviacache.https-expected.txt
[modify] https://crrev.com/2898d2a95064276f84a6803253f15b0ea018f82a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/registration-updateviacache.https.html
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/iframe-register-link-element.html
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/link-header.py
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/foreignfetch-origin-trial-interfaces-expected.txt
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/foreignfetch-origin-trial-interfaces.html
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/resources/foreignfetch-origin-trial-interfaces-worker-disabled.js
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/resources/foreignfetch-origin-trial-interfaces-worker-enabled.php
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/resources/foreignfetch-origin-trial-interfaces-worker.php
[delete] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-service-worker-link-rel.php
[modify] https://crrev.com/2898d2a95064276f84a6803253f15b0ea018f82a/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/2898d2a95064276f84a6803253f15b0ea018f82a/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/2898d2a95064276f84a6803253f15b0ea018f82a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/2898d2a95064276f84a6803253f15b0ea018f82a/third_party/WebKit/Source/platform/runtime_enabled_features.json5
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f497cf3c009d1e74c52910bd182ac4b5944c2b51

commit f497cf3c009d1e74c52910bd182ac4b5944c2b51
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Nov 29 08:11:42 2017

service worker: Remove foreign fetch and link registration.

These were removed from the specification:
https://github.com/w3c/ServiceWorker/commit/0d09f488c062f0db5d65a243da0bbddaec3de1dd

This CL is mostly mechanical but there were some finesses done to
DocumentThreadableLoader.cpp.

For a smaller diff, some transitive cleanup is left for future patches. Remaining
tasks/investigation:
* Clean up enums in service_worker_modes.h that only have one or two values now.
* Remove components/link_header_util <https://codereview.chromium.org/1811163002>
* In worker_fetch_context_impl.cc:
  // TODO(falken): Is still this needed? It used to set kForeign for foreign
  // fetch.
* Remove ServiceWorkerURLJobWrapper::Delegate. Now the only delegate is
ServiceWorkerControlleeRequestHandler since there is no more
ForeignFetchRequestHandler. But it might be useful to keep for unit tests.
* Remove UMA code and mark histograms as obsolete.

Bug: 788604
Change-Id: Ieb57111fc7f226adc15989d2250c7169ad73a4b9
Reviewed-on: https://chromium-review.googlesource.com/792731
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520042}
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/BUILD.gn
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/embedded_worker_test_helper.h
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/content/browser/service_worker/foreign_fetch_request_handler.cc
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/content/browser/service_worker/foreign_fetch_request_handler.h
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/content/browser/service_worker/link_header_support.cc
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/content/browser/service_worker/link_header_support.h
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/content/browser/service_worker/link_header_support_unittest.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_context_wrapper.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_database.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_database.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_database.proto
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_database_unittest.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_register_job.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_register_job.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_response_info.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_response_info.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_storage.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_storage.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/browser/storage_partition_impl_map.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/common/service_worker/service_worker_event_dispatcher.mojom
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/common/service_worker/service_worker_fetch_request_struct_traits.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/public/common/resource_response.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/public/common/resource_response_info.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/public/common/resource_response_info.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/public/common/service_worker_modes.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/renderer/loader/web_url_request_util.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/renderer/service_worker/worker_fetch_context_impl.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/content/test/BUILD.gn
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/net/log/net_log_event_type_list.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/core/CoreInitializer.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/core/html/HTMLLinkElement.idl
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/core/html/RelList.cpp
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/ModulesInitializer.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/payments/PaymentHandlerUtils.cpp
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/serviceworkers/BUILD.gn
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.h
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.idl
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEventInit.idl
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchOptions.idl
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.h
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/serviceworkers/InstallEvent.cpp
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/serviceworkers/InstallEvent.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/serviceworkers/InstallEvent.idl
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.h
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp
[delete] https://crrev.com/9676ea8c32dac6cc850cbae281330a9fcf2021a1/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/modules/serviceworkers/WebEmbeddedWorkerImplTest.cpp
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/platform/exported/WebCORS.cpp
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/public/platform/WebURLRequest.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/public/platform/WebURLResponse.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/public/platform/modules/fetch/fetch_api_request.mojom
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/public/platform/modules/serviceworker/service_worker_error_type.mojom
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
[modify] https://crrev.com/f497cf3c009d1e74c52910bd182ac4b5944c2b51/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

Comment 3 by falken@chromium.org, Nov 30 2017

Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25d4ea38b620941ca98a102e2f49b26e836c6480

commit 25d4ea38b620941ca98a102e2f49b26e836c6480
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Thu Jan 18 09:48:22 2018

ServiceWorker: Remove custom timeout feature from fetch events

FetchEvent used to need the custom timeout for foreign fetch, but it has already
removed. This patch removes the custom timeout codes from SWFetchDispatcher and
some loading related stuff.

Bug:  774374 , 788604
Change-Id: Ifba12ad93f5572b10e0f75c60fcaec8e6fa954b1
Reviewed-on: https://chromium-review.googlesource.com/872514
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530103}
[modify] https://crrev.com/25d4ea38b620941ca98a102e2f49b26e836c6480/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/25d4ea38b620941ca98a102e2f49b26e836c6480/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/25d4ea38b620941ca98a102e2f49b26e836c6480/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc
[modify] https://crrev.com/25d4ea38b620941ca98a102e2f49b26e836c6480/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/25d4ea38b620941ca98a102e2f49b26e836c6480/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/25d4ea38b620941ca98a102e2f49b26e836c6480/content/browser/service_worker/service_worker_url_loader_job.cc
[modify] https://crrev.com/25d4ea38b620941ca98a102e2f49b26e836c6480/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/25d4ea38b620941ca98a102e2f49b26e836c6480/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/25d4ea38b620941ca98a102e2f49b26e836c6480/content/browser/service_worker/service_worker_url_request_job_unittest.cc

Comment 5 by falken@chromium.org, Feb 21 2018

Labels: -Type-Bug Type-Task
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c616ecf30685ca7a3488e9b41652257d69949135

commit c616ecf30685ca7a3488e9b41652257d69949135
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Feb 21 11:47:25 2018

service worker: Remove ServiceWorkerFetchType enums.

Since foreign fetch was removed, the enum only had one type, so it's
not needed.

R=shimazu
TBR=kinuko

Bug: 788604
Change-Id: I0ed04cc5a0076c67c1e0f7b1ef0d4e6b4d145880
Reviewed-on: https://chromium-review.googlesource.com/928094
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538067}
[modify] https://crrev.com/c616ecf30685ca7a3488e9b41652257d69949135/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/c616ecf30685ca7a3488e9b41652257d69949135/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc
[modify] https://crrev.com/c616ecf30685ca7a3488e9b41652257d69949135/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/c616ecf30685ca7a3488e9b41652257d69949135/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/c616ecf30685ca7a3488e9b41652257d69949135/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/c616ecf30685ca7a3488e9b41652257d69949135/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/c616ecf30685ca7a3488e9b41652257d69949135/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/c616ecf30685ca7a3488e9b41652257d69949135/content/common/service_worker/service_worker_fetch_request_mojom_traits.cc
[modify] https://crrev.com/c616ecf30685ca7a3488e9b41652257d69949135/content/common/service_worker/service_worker_fetch_request_mojom_traits.h
[modify] https://crrev.com/c616ecf30685ca7a3488e9b41652257d69949135/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/c616ecf30685ca7a3488e9b41652257d69949135/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/c616ecf30685ca7a3488e9b41652257d69949135/content/public/common/service_worker_modes.h
[modify] https://crrev.com/c616ecf30685ca7a3488e9b41652257d69949135/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.h
[modify] https://crrev.com/c616ecf30685ca7a3488e9b41652257d69949135/third_party/WebKit/public/platform/modules/fetch/fetch_api_request.mojom
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71ea9ff0ff80999f05b7e267b04384bba0fe5617

commit 71ea9ff0ff80999f05b7e267b04384bba0fe5617
Author: Joshua Bell <jsbell@chromium.org>
Date: Fri Mar 02 00:19:04 2018

Remove foreign fetch expectation missed in r519639

Bug: 788604
Change-Id: I8f8ea1b9a847c10b35bfa48e9320922a9bdb2afb
Reviewed-on: https://chromium-review.googlesource.com/944619
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540365}
[delete] https://crrev.com/654af1c797919357cb9b1d11325c91af89d36f44/third_party/WebKit/LayoutTests/virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/foreignfetch-origin-trial-interfaces-expected.txt
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/179ce665cd0310a8254288428dd97ae715b34100

commit 179ce665cd0310a8254288428dd97ae715b34100
Author: Charlie Harrison <csharrison@chromium.org>
Date: Mon Apr 09 20:33:48 2018

Remove dead foreign fetch code

Also obsoletes some histograms. There is probably a lot more histograms
that we should remove in followups.

Bug: 788604
Change-Id: I263a3d6ab0fc612d38ea4ad794751f276cc37188
Reviewed-on: https://chromium-review.googlesource.com/999793
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549261}
[modify] https://crrev.com/179ce665cd0310a8254288428dd97ae715b34100/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/179ce665cd0310a8254288428dd97ae715b34100/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/179ce665cd0310a8254288428dd97ae715b34100/tools/metrics/histograms/histograms.xml

Comment 9 by falken@chromium.org, Jun 12 2018

Labels: Hotlist-GoodFirstBug

Comment 10 by falken@chromium.org, Aug 8

Cc: falken@chromium.org
Owner: ----
Status: Available (was: Started)
►

Sign in to add a comment