Ensure cached notifications channels are cleared when ClearAllContentSettingsRules is called |
|||
Issue descriptionCurrently NotificationChannelsProviderAndroid::ClearAllContentSettingsRules doesn't clear the chached notification channels in the provider. This can lead to bugs due to the inconsistent state between real and cached channels.
,
Nov 27 2017
This was landed in https://chromium-review.googlesource.com/c/chromium/src/+/784275. The fix is fairly trivial. Technically this impacts M63. The scope of the impact: There is a risk that after clearing channels, new channels won't get recreated properly. This is fairly unlikely and the issue should rectify itself after notification settings are displayed on the screen (or Chrome is restarted, etc.). I can't think of any other potential problems. But I'm also making an assumption here that trying to delete a non-existent channel in the Android side won't crash or do anything bad. awdf: could you confirm that? But otherwise, given that we're so close to Stable release of 63, I'm not sure we would be able to merge this. peter/awdf/cmasso: thoughts?
,
Nov 27 2017
Re #2: Can confirm deleting a non-existent channel is fine. Agree it's probably not worth merging now, given the timescale and the available workaround (restarting Chrome).
,
Nov 27 2017
Thanks Anita. Closing as fixed then.
,
Nov 28 2017
Thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by raymes@chromium.org
, Nov 27 2017