New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788574 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Exo doesn't generate leave events when focus surface is destroyed.

Project Member Reported by reve...@chromium.org, Nov 26 2017

Issue description

This is required by spec and implemented properly in Weston. Xwayland will be confused when these leave events are missing.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c97c47fe23d7f2e5d8645299ea88659449634ad2

commit c97c47fe23d7f2e5d8645299ea88659449634ad2
Author: David Reveman <reveman@chromium.org>
Date: Mon Nov 27 18:27:01 2017

exo: Generate keyboard/pointer leave events when focus is destroyed.

We need to generate leave events if the current focus surface is
destroyed. This is a small refactor of pointer/keyboard code to
generate these events without having to duplicate code.

Bug:  788574 
Test: exo_unittests --gtest_filter=*.On*Leave
Change-Id: Ied64b149a38b67392b68f351814610c30c197e4f
Reviewed-on: https://chromium-review.googlesource.com/789421
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519344}
[modify] https://crrev.com/c97c47fe23d7f2e5d8645299ea88659449634ad2/components/exo/keyboard.cc
[modify] https://crrev.com/c97c47fe23d7f2e5d8645299ea88659449634ad2/components/exo/keyboard.h
[modify] https://crrev.com/c97c47fe23d7f2e5d8645299ea88659449634ad2/components/exo/keyboard_unittest.cc
[modify] https://crrev.com/c97c47fe23d7f2e5d8645299ea88659449634ad2/components/exo/pointer.cc
[modify] https://crrev.com/c97c47fe23d7f2e5d8645299ea88659449634ad2/components/exo/pointer.h
[modify] https://crrev.com/c97c47fe23d7f2e5d8645299ea88659449634ad2/components/exo/pointer_unittest.cc

Status: Fixed (was: Started)

Comment 3 by hirono@chromium.org, Jan 12 2018

Cc: hirono@chromium.org niwa@chromium.org reve...@chromium.org
 Issue 784737  has been merged into this issue.

Sign in to add a comment