Issue metadata
Sign in to add a comment
|
All/ParameterizedWebFrameTest.DISABLE_ON_TSAN(MaxFramesDetach) failing on linux_chromium_tsan_rel_ng |
||||||||||||||||||||||
Issue descriptionThese two tests: All/ParameterizedWebFrameTest.DISABLE_ON_TSAN(MaxFramesDetach)/0 All/ParameterizedWebFrameTest.DISABLE_ON_TSAN(MaxFramesDetach)/1 are failing on every build on linux_chromium_tsan_rel_ng that runs webkit_unit_tests. This is preventing CLs from landing which change build parameters, since these don't run retries. It doesn't seem that either of the two most recent changes to this test were the cause: https://chromium-review.googlesource.com/772430 https://chromium-review.googlesource.com/784930 and unfortunately it's been >200 builds since they were failing so it's not easy to see what regressed. Everything also appears green on https://build.chromium.org/p/chromium.memory/console and https://ci.chromium.org/buildbot/chromium.memory/Linux%20TSan%20Tests/ . CC'ing some folks who might have insight into what's going on. Sheriffs, could you please track this down on Monday? Thanks.
,
Nov 27 2017
The tests sounds disabled on TSAN enabled builds, why are they run on linux_chromium_tsan_rel_ng?
,
Nov 27 2017
The macro is not expanded.
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed0bff9c8e369ecb48409278d09204d4d29ab3ee commit ed0bff9c8e369ecb48409278d09204d4d29ab3ee Author: Yutaka Hirano <yhirano@chromium.org> Date: Mon Nov 27 07:55:30 2017 Disable ParameterizedWebFrameTest.MaxFramesDetach when TSAN is enabled The test has been intended to be disabled on TSAN enabled environments, but it has not been disabled correctly. Bug: 788572 Change-Id: Idb561808d3385785209d0538dd797a0876035ab2 Reviewed-on: https://chromium-review.googlesource.com/790180 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#519239} [modify] https://crrev.com/ed0bff9c8e369ecb48409278d09204d4d29ab3ee/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
,
Nov 27 2017
,
Nov 28 2017
Re comment #1: Many thanks kbr@ for sharing this case! Unfortunately, these reliable failures only happended on CQ and Findit is not analyzing reliable failures on CQ. I filed bug 789244 to collect more cases like this. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kbr@chromium.org
, Nov 26 2017