Issue 788554 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ rjwright@chromium.org Last visit > 30 days ago
Closed:	Dec 2017
Cc:	style-bugs@google.com
Components:	Blink>CSS
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Task

Blocking:
issue 779939

Move CSSPropertyNames' getPropertyName etc. to CSSProperty subclasses.

Project Member Reported by rjwright@chromium.org, Nov 26 2017

Issue description

This is part of Project Ribbon. We are trying to minimize references to CSSPropertyID.

Impl plan:

1. Add getPropertyName method to CSSProperty & make it call through to the CSSPropertyNames version.

2. Update all the callers to use the CSSProperty version.

3. Change the CSSProperty methods to contain the logic and not call through to CSSPropertyNames (This will be done over multiple CLs. I'll need to break up CSSProperty groups).

4. Delete the CSSPropertyNames version.

Comment 1 by nainar@chromium.org, Dec 6 2017

Labels: -Update-Weekly

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85b6741bea73eeb6b9705399cb37d33f4f73f383

commit 85b6741bea73eeb6b9705399cb37d33f4f73f383
Author: Renee Wright <rjwright@chromium.org>
Date: Mon Dec 18 02:03:16 2017

[Ribbon] Start moving getPropertyName and similar to CSSProperty

The old versions of these methods are in CSSPropertyNames.h/.cpp

Moved methods are
- getPropertyName             -> CSSProperty::GetPropertyName
- getPropertyNameAtomicString -> CSSProperty::GetPropertyNameAtomicString
- getPropertyNameString       -> CSSProperty::GetPropertyNameString
- getJSPropertyName           -> CSSProperty::GetJSPropertyName


Adds GetPropertyName & GetPropertyNameAtomicString methods to CSSProperty.
For properties that are in group CSSProperty classes, these methods call through
to the legacy CSSPropertyNames versions (passing the result of PropertyID).
For the properties that have unique CSSProperty classes, these methods are
overridden, with the returned string hard-coded in the override.

Moves getPropertyNameString and getJSPropertyName to CSSProperty.

Updates all the callers of these 4 methods to use the CSSProperty versions.

Removes the CSSProperty subclass "Inherited" and adds unique subclasses for
its members.

GetPropertyName also needs to support aliases, so I have added generated
CSSProperty classes for aliases. These derive from a new base class called
CSSUnresolvedProperty, which CSSProperty also derives from. I'm not sure if
casting from CSSUnresolvedProperty to CSSProperty upon CSSProperty::Get
incurs a runtime cost. This support is added in patch set 9 & up.

gist for gen diff here:
https://gist.github.com/rjwright/78980ce0a9c5c589bab98fcec1e74a13/revisions

Part 2 of this effort is here:
https://chromium-review.googlesource.com/c/chromium/src/+/804645

Bug:  788554 
Change-Id: I245e7a807e696addc44cebc55c92b3b463861bdb
Reviewed-on: https://chromium-review.googlesource.com/793650
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: dstockwell <dstockwell@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524638}
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/build/scripts/core/css/css_properties.py
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_base.py
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_headers.py
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSProperty.cpp.tmpl
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSProperty.h.tmpl
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertySubclass.h.tmpl
[add] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSUnresolvedProperty.cpp.tmpl
[add] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSUnresolvedProperty.h.tmpl
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/build/scripts/templates/CSSPropertyNames.cpp.tmpl
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/build/scripts/templates/CSSPropertyNames.h.tmpl
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/css/StylePropertySerializer.h
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/css/properties/CSSPropertyBaseCustom.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h
[modify] https://crrev.com/85b6741bea73eeb6b9705399cb37d33f4f73f383/third_party/WebKit/Source/core/testing/Internals.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3

commit e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3
Author: Renee Wright <rjwright@chromium.org>
Date: Mon Dec 18 13:05:08 2017

[Ribbon] Remove CSSProperty groups

Gist for gen diff here:

https: //gist.github.com/rjwright/d32835d21f8b313c46ec7a1c6d4d0155/revisions
Bug:  788554 
Change-Id: Ia19d78686e9742a91455fa044c69c22c94c05552
Reviewed-on: https://chromium-review.googlesource.com/804645
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524692}
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/build/scripts/core/css/css_properties.py
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_base.py
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_headers.py
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertySubclass.h.tmpl
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSUnresolvedProperty.cpp.tmpl
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSUnresolvedProperty.h.tmpl
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/build/scripts/make_style_builder.py
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/build/scripts/templates/CSSPropertyNames.cpp.tmpl
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/build/scripts/templates/CSSPropertyNames.h.tmpl
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/CSSParsingUtils.cpp
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/CSSParsingUtils.h
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/AlignContent.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/AnimationDelay.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/AnimationDuration.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/AnimationTimingFunction.cpp
[delete] https://crrev.com/c31c9f240beb510166899cb7d95d2acdfd4bcdb1/third_party/WebKit/Source/core/css/properties/longhands/BackgroundBox.cpp
[add] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BackgroundClip.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BackgroundImage.cpp
[delete] https://crrev.com/c31c9f240beb510166899cb7d95d2acdfd4bcdb1/third_party/WebKit/Source/core/css/properties/longhands/BackgroundOrMaskSize.cpp
[add] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BackgroundOrigin.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BackgroundPositionX.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BackgroundPositionY.cpp
[add] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BackgroundSize.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BlockSize.cpp
[delete] https://crrev.com/c31c9f240beb510166899cb7d95d2acdfd4bcdb1/third_party/WebKit/Source/core/css/properties/longhands/BlockSizeOrLogicalHeight.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BorderBottomLeftRadius.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BorderBottomRightRadius.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BorderBottomWidth.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BorderImageSource.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BorderLeftWidth.cpp
[delete] https://crrev.com/c31c9f240beb510166899cb7d95d2acdfd4bcdb1/third_party/WebKit/Source/core/css/properties/longhands/BorderRadiusCorner.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BorderRightWidth.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BorderTopLeftRadius.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BorderTopRightRadius.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/BorderTopWidth.cpp
[delete] https://crrev.com/c31c9f240beb510166899cb7d95d2acdfd4bcdb1/third_party/WebKit/Source/core/css/properties/longhands/BorderWidthSide.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Bottom.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Cx.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Cy.cpp
[delete] https://crrev.com/c31c9f240beb510166899cb7d95d2acdfd4bcdb1/third_party/WebKit/Source/core/css/properties/longhands/Delay.cpp
[add] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Fill.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/FillOpacity.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/FlexGrow.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/FlexShrink.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/FloodOpacity.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/GridAutoColumns.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/GridAutoRows.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/GridColumnEnd.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/GridColumnGap.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/GridColumnStart.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/GridRowEnd.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/GridRowGap.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/GridRowStart.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/GridTemplateColumns.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/GridTemplateRows.cpp
[add] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Height.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/InlineSize.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/JustifyContent.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Left.cpp
[delete] https://crrev.com/c31c9f240beb510166899cb7d95d2acdfd4bcdb1/third_party/WebKit/Source/core/css/properties/longhands/LetterAndWordSpacing.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/LetterSpacing.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/MarkerEnd.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/MarkerMid.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/MarkerStart.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/MaxBlockSize.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/MaxHeight.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/MaxInlineSize.cpp
[delete] https://crrev.com/c31c9f240beb510166899cb7d95d2acdfd4bcdb1/third_party/WebKit/Source/core/css/properties/longhands/MaxInlineSizeOrMaxLogicalWidth.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/MaxWidth.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/MinBlockSize.cpp
[delete] https://crrev.com/c31c9f240beb510166899cb7d95d2acdfd4bcdb1/third_party/WebKit/Source/core/css/properties/longhands/MinBlockSizeOrMinLogicalHeight.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/MinHeight.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/MinInlineSize.cpp
[delete] https://crrev.com/c31c9f240beb510166899cb7d95d2acdfd4bcdb1/third_party/WebKit/Source/core/css/properties/longhands/MinInlineSizeOrMinLogicalWidth.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/MinWidth.cpp
[add] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Orphans.cpp
[delete] https://crrev.com/c31c9f240beb510166899cb7d95d2acdfd4bcdb1/third_party/WebKit/Source/core/css/properties/longhands/OrphansOrWidows.cpp
[delete] https://crrev.com/c31c9f240beb510166899cb7d95d2acdfd4bcdb1/third_party/WebKit/Source/core/css/properties/longhands/PaintStroke.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/R.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Right.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Rx.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Ry.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/ScrollPaddingBottom.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/ScrollPaddingLeft.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/ScrollPaddingRight.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/ScrollPaddingTop.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginBottom.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginLeft.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginRight.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginTop.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/StopOpacity.cpp
[add] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Stroke.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/StrokeDashoffset.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/StrokeOpacity.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/StrokeWidth.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Top.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/TransitionDelay.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/TransitionDuration.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/TransitionTimingFunction.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitBorderHorizontalSpacing.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitBorderVerticalSpacing.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitHyphenateCharacter.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitLocale.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitLogicalHeight.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitLogicalWidth.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskBoxImageSource.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskImage.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskPositionX.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskPositionY.cpp
[add] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskSize.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaxLogicalHeight.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaxLogicalWidth.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitMinLogicalHeight.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitMinLogicalWidth.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitPerspectiveOriginX.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitPerspectiveOriginY.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitTransformOriginX.cpp
[rename] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WebkitTransformOriginY.cpp
[add] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Widows.cpp
[add] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Width.cpp
[delete] https://crrev.com/c31c9f240beb510166899cb7d95d2acdfd4bcdb1/third_party/WebKit/Source/core/css/properties/longhands/WidthOrHeight.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/WordSpacing.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/X.cpp
[copy] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/longhands/Y.cpp
[modify] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/shorthands/Background.cpp
[add] https://crrev.com/e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3/third_party/WebKit/Source/core/css/properties/shorthands/WebkitMask.cpp

Comment 4 by rjwright@chromium.org, Dec 18 2017

Status: Fixed (was: Started)

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16df149df4ccbaa93852d0522140b97365f9d681

commit 16df149df4ccbaa93852d0522140b97365f9d681
Author: Christian Dullweber <dullweber@chromium.org>
Date: Mon Dec 18 15:00:02 2017

Revert "[Ribbon] Remove CSSProperty groups"

This reverts commit e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3.

Reason for revert:  https://crbug.com/795744 

Original change's description:
> [Ribbon] Remove CSSProperty groups
> 
> Gist for gen diff here:
> 
> https: //gist.github.com/rjwright/d32835d21f8b313c46ec7a1c6d4d0155/revisions
> Bug:  788554 
> Change-Id: Ia19d78686e9742a91455fa044c69c22c94c05552
> Reviewed-on: https://chromium-review.googlesource.com/804645
> Commit-Queue: Renée Wright <rjwright@chromium.org>
> Reviewed-by: meade_UTC10 <meade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524692}

TBR=rjwright@chromium.org,meade@chromium.org

Change-Id: I0c1d41d5ef0f93b4563ad755b3b1743810b8a9b8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  788554 
Reviewed-on: https://chromium-review.googlesource.com/832469
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524708}
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/build/scripts/core/css/css_properties.py
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_base.py
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_headers.py
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertySubclass.h.tmpl
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSUnresolvedProperty.cpp.tmpl
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSUnresolvedProperty.h.tmpl
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/build/scripts/make_style_builder.py
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/build/scripts/templates/CSSPropertyNames.cpp.tmpl
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/build/scripts/templates/CSSPropertyNames.h.tmpl
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/CSSParsingUtils.cpp
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/CSSParsingUtils.h
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/AlignOrJustifyContent.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/AnimationDelay.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/AnimationDuration.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/AnimationTimingFunction.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/AutoOrString.cpp
[add] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/BackgroundBox.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/BackgroundClip.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/BackgroundImage.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/BackgroundOrMaskImage.cpp
[add] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/BackgroundOrMaskSize.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/BackgroundOrigin.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/BackgroundSize.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/BlockSize.cpp
[copy] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/BlockSizeOrLogicalHeight.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/BorderBottomLeftRadius.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/BorderBottomRightRadius.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/BorderBottomWidth.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/BorderLeftWidth.cpp
[add] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/BorderRadiusCorner.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/BorderRightWidth.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/BorderTopLeftRadius.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/BorderTopRightRadius.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/BorderTopWidth.cpp
[add] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/BorderWidthSide.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/Bottom.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/Cx.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/Cy.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/Delay.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/Duration.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/Fill.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/FillOrStrokeOpacity.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/FlexGrowOrShrink.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/FloodOpacity.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/FloodOrStopOpacity.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/GridAutoLine.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/GridAutoRows.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/GridColumnEnd.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/GridColumnStart.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/GridLine.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/GridRowEnd.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/GridRowGap.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/GridRowOrColumnGap.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/GridRowStart.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/GridTemplateColumns.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/GridTemplateLine.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/Height.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/ImageSource.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/InlineSizeOrLogicalWidth.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/JustifyContent.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/Left.cpp
[add] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/LetterAndWordSpacing.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/LetterSpacing.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/MarkerEnd.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/MarkerPoint.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/MarkerStart.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/MaxBlockSize.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/MaxBlockSizeOrMaxLogicalHeight.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/MaxInlineSize.cpp
[copy] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/MaxInlineSizeOrMaxLogicalWidth.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/MaxWidthOrHeight.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/MinBlockSize.cpp
[copy] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/MinBlockSizeOrMinLogicalHeight.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/MinInlineSize.cpp
[copy] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/MinInlineSizeOrMinLogicalWidth.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/MinWidth.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/MinWidthOrHeight.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/OffsetSide.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/Orphans.cpp
[copy] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/OrphansOrWidows.cpp
[add] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/PaintStroke.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/PositionX.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/PositionY.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/R.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/Radius.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/Right.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/Rx.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/ScrollPaddingBottom.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/ScrollPaddingRight.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/ScrollPaddingSide.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/ScrollPaddingTop.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginBottom.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginRight.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginSide.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginTop.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/ShapeLength.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/Stroke.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/StrokeDashoffset.cpp
[copy] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/StrokeDashoffsetOrStrokeWidth.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/StrokeOpacity.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/TimingFunction.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/TransitionDuration.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/WebkitBorderHorizontalSpacing.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/WebkitBorderSpacing.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/WebkitHyphenateCharacter.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/WebkitLogicalHeight.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/WebkitLogicalWidth.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskBoxImageSource.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskPositionX.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskPositionY.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskSize.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaxLogicalHeight.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/WebkitMinLogicalHeight.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/WebkitMinLogicalWidth.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/WebkitOriginX.cpp
[rename] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/WebkitOriginY.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/WebkitPerspectiveOriginX.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/WebkitPerspectiveOriginY.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/Widows.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/Width.cpp
[copy] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/longhands/WidthOrHeight.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/WordSpacing.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/X.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/longhands/Y.cpp
[modify] https://crrev.com/16df149df4ccbaa93852d0522140b97365f9d681/third_party/WebKit/Source/core/css/properties/shorthands/Background.cpp
[delete] https://crrev.com/c8b605c6082d36e8ae316f328417280150f0787f/third_party/WebKit/Source/core/css/properties/shorthands/WebkitMask.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/505ec4645e87ce2bfc7875b053d3f48967aabbc5

commit 505ec4645e87ce2bfc7875b053d3f48967aabbc5
Author: Renee Wright <rjwright@chromium.org>
Date: Tue Dec 19 03:03:08 2017

[Ribbon][Reupload] Remove CSSProperty groups

Re-upload after revert
https://chromium-review.googlesource.com/c/chromium/src/+/832469

Bug:  788554 
Change-Id: I36428a382e10b02dc97241df5e30e89b5f711f6c
Reviewed-on: https://chromium-review.googlesource.com/832588
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524927}
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/build/scripts/core/css/css_properties.py
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_base.py
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_headers.py
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertySubclass.h.tmpl
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSUnresolvedProperty.cpp.tmpl
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSUnresolvedProperty.h.tmpl
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/build/scripts/make_style_builder.py
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/build/scripts/templates/CSSPropertyNames.cpp.tmpl
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/build/scripts/templates/CSSPropertyNames.h.tmpl
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/CSSParsingUtils.cpp
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/CSSParsingUtils.h
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/AlignContent.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/AnimationDelay.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/AnimationDuration.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/AnimationTimingFunction.cpp
[delete] https://crrev.com/59b9b8b9892e6c2befca6ba649b8a77342872e78/third_party/WebKit/Source/core/css/properties/longhands/BackgroundBox.cpp
[add] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BackgroundClip.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BackgroundImage.cpp
[delete] https://crrev.com/59b9b8b9892e6c2befca6ba649b8a77342872e78/third_party/WebKit/Source/core/css/properties/longhands/BackgroundOrMaskSize.cpp
[add] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BackgroundOrigin.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BackgroundPositionX.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BackgroundPositionY.cpp
[add] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BackgroundSize.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BlockSize.cpp
[delete] https://crrev.com/59b9b8b9892e6c2befca6ba649b8a77342872e78/third_party/WebKit/Source/core/css/properties/longhands/BlockSizeOrLogicalHeight.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BorderBottomLeftRadius.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BorderBottomRightRadius.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BorderBottomWidth.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BorderImageSource.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BorderLeftWidth.cpp
[delete] https://crrev.com/59b9b8b9892e6c2befca6ba649b8a77342872e78/third_party/WebKit/Source/core/css/properties/longhands/BorderRadiusCorner.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BorderRightWidth.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BorderTopLeftRadius.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BorderTopRightRadius.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/BorderTopWidth.cpp
[delete] https://crrev.com/59b9b8b9892e6c2befca6ba649b8a77342872e78/third_party/WebKit/Source/core/css/properties/longhands/BorderWidthSide.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Bottom.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Cx.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Cy.cpp
[delete] https://crrev.com/59b9b8b9892e6c2befca6ba649b8a77342872e78/third_party/WebKit/Source/core/css/properties/longhands/Delay.cpp
[add] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Fill.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/FillOpacity.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/FlexGrow.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/FlexShrink.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/FloodOpacity.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/GridAutoColumns.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/GridAutoRows.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/GridColumnEnd.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/GridColumnGap.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/GridColumnStart.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/GridRowEnd.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/GridRowGap.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/GridRowStart.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/GridTemplateColumns.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/GridTemplateRows.cpp
[add] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Height.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/InlineSize.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/JustifyContent.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Left.cpp
[delete] https://crrev.com/59b9b8b9892e6c2befca6ba649b8a77342872e78/third_party/WebKit/Source/core/css/properties/longhands/LetterAndWordSpacing.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/LetterSpacing.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/MarkerEnd.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/MarkerMid.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/MarkerStart.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/MaxBlockSize.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/MaxHeight.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/MaxInlineSize.cpp
[delete] https://crrev.com/59b9b8b9892e6c2befca6ba649b8a77342872e78/third_party/WebKit/Source/core/css/properties/longhands/MaxInlineSizeOrMaxLogicalWidth.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/MaxWidth.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/MinBlockSize.cpp
[delete] https://crrev.com/59b9b8b9892e6c2befca6ba649b8a77342872e78/third_party/WebKit/Source/core/css/properties/longhands/MinBlockSizeOrMinLogicalHeight.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/MinHeight.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/MinInlineSize.cpp
[delete] https://crrev.com/59b9b8b9892e6c2befca6ba649b8a77342872e78/third_party/WebKit/Source/core/css/properties/longhands/MinInlineSizeOrMinLogicalWidth.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/MinWidth.cpp
[add] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Orphans.cpp
[delete] https://crrev.com/59b9b8b9892e6c2befca6ba649b8a77342872e78/third_party/WebKit/Source/core/css/properties/longhands/OrphansOrWidows.cpp
[delete] https://crrev.com/59b9b8b9892e6c2befca6ba649b8a77342872e78/third_party/WebKit/Source/core/css/properties/longhands/PaintStroke.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/R.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Right.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Rx.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Ry.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/ScrollPaddingBottom.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/ScrollPaddingLeft.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/ScrollPaddingRight.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/ScrollPaddingTop.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginBottom.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginLeft.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginRight.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginTop.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/StopOpacity.cpp
[add] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Stroke.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/StrokeDashoffset.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/StrokeOpacity.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/StrokeWidth.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Top.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/TransitionDelay.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/TransitionDuration.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/TransitionTimingFunction.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitBorderHorizontalSpacing.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitBorderVerticalSpacing.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitHyphenateCharacter.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitLocale.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitLogicalHeight.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitLogicalWidth.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskBoxImageSource.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskImage.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskPositionX.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskPositionY.cpp
[add] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskSize.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaxLogicalHeight.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaxLogicalWidth.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitMinLogicalHeight.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitMinLogicalWidth.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitPerspectiveOriginX.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitPerspectiveOriginY.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitTransformOriginX.cpp
[rename] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WebkitTransformOriginY.cpp
[add] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Widows.cpp
[add] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Width.cpp
[delete] https://crrev.com/59b9b8b9892e6c2befca6ba649b8a77342872e78/third_party/WebKit/Source/core/css/properties/longhands/WidthOrHeight.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/WordSpacing.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/X.cpp
[copy] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/longhands/Y.cpp
[modify] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/shorthands/Background.cpp
[add] https://crrev.com/505ec4645e87ce2bfc7875b053d3f48967aabbc5/third_party/WebKit/Source/core/css/properties/shorthands/WebkitMask.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a033b3c28fd199e2bf20a23831406cc791d40c1

commit 6a033b3c28fd199e2bf20a23831406cc791d40c1
Author: Renee Wright <rjwright@chromium.org>
Date: Mon Jan 08 09:55:16 2018

[Ribbon] Even more ComputedStyleCSSValueMapping

Methods moved to ComputedStyleUtils:
- CreatePositionListForLayer
- ValueForFillSize
- ValueForFillRepeat
- ValuesForBackgroundShorthand

Cases removed from Get:
- BackgroundImage
- WebkitMaskImage
- BackgroundSize
- WebkitMaskSize
- BackgroundRepeat
- WebkitMaskRepeat
- BackgroundPosition
- WebkitMaskPosition
- Background

Bug:  788554 
Change-Id: I624e16fadbbbd13b8340464d233cbf077b11ea8c
Reviewed-on: https://chromium-review.googlesource.com/831774
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527594}
[modify] https://crrev.com/6a033b3c28fd199e2bf20a23831406cc791d40c1/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/6a033b3c28fd199e2bf20a23831406cc791d40c1/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/6a033b3c28fd199e2bf20a23831406cc791d40c1/third_party/WebKit/Source/core/css/properties/ComputedStyleUtils.cpp
[modify] https://crrev.com/6a033b3c28fd199e2bf20a23831406cc791d40c1/third_party/WebKit/Source/core/css/properties/ComputedStyleUtils.h
[modify] https://crrev.com/6a033b3c28fd199e2bf20a23831406cc791d40c1/third_party/WebKit/Source/core/css/properties/longhands/BackgroundImageCustom.cpp
[modify] https://crrev.com/6a033b3c28fd199e2bf20a23831406cc791d40c1/third_party/WebKit/Source/core/css/properties/longhands/BackgroundSizeCustom.cpp
[modify] https://crrev.com/6a033b3c28fd199e2bf20a23831406cc791d40c1/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskImageCustom.cpp
[modify] https://crrev.com/6a033b3c28fd199e2bf20a23831406cc791d40c1/third_party/WebKit/Source/core/css/properties/longhands/WebkitMaskSizeCustom.cpp
[modify] https://crrev.com/6a033b3c28fd199e2bf20a23831406cc791d40c1/third_party/WebKit/Source/core/css/properties/shorthands/BackgroundCustom.cpp
[modify] https://crrev.com/6a033b3c28fd199e2bf20a23831406cc791d40c1/third_party/WebKit/Source/core/css/properties/shorthands/BackgroundPositionCustom.cpp
[modify] https://crrev.com/6a033b3c28fd199e2bf20a23831406cc791d40c1/third_party/WebKit/Source/core/css/properties/shorthands/BackgroundRepeatCustom.cpp
[modify] https://crrev.com/6a033b3c28fd199e2bf20a23831406cc791d40c1/third_party/WebKit/Source/core/css/properties/shorthands/WebkitMaskPositionCustom.cpp
[modify] https://crrev.com/6a033b3c28fd199e2bf20a23831406cc791d40c1/third_party/WebKit/Source/core/css/properties/shorthands/WebkitMaskRepeatCustom.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba3e9aa6bde29fb3cd930e97ad989fd96201aece

commit ba3e9aa6bde29fb3cd930e97ad989fd96201aece
Author: Naina Raisinghani <nainar@chromium.org>
Date: Tue Jan 09 07:50:06 2018

[Ribbon] Even more ComputedStyleCSSValueMapping

Methods moved to ComputedStyleUtils:
- ValueForPosition
- ValueForOffset

Cases removed from Get:
- Offset
- OffsetAnchor
- OffsetPosition
- OffsetRotate
- OffsetPath

Bug:  788554 
Change-Id: Ifd2bd081cb9c9162e1f1e2f76719842fc6bfcd84
Reviewed-on: https://chromium-review.googlesource.com/853816
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527929}
[modify] https://crrev.com/ba3e9aa6bde29fb3cd930e97ad989fd96201aece/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/ba3e9aa6bde29fb3cd930e97ad989fd96201aece/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/ba3e9aa6bde29fb3cd930e97ad989fd96201aece/third_party/WebKit/Source/core/css/properties/ComputedStyleUtils.cpp
[modify] https://crrev.com/ba3e9aa6bde29fb3cd930e97ad989fd96201aece/third_party/WebKit/Source/core/css/properties/ComputedStyleUtils.h
[modify] https://crrev.com/ba3e9aa6bde29fb3cd930e97ad989fd96201aece/third_party/WebKit/Source/core/css/properties/longhands/OffsetAnchorCustom.cpp
[modify] https://crrev.com/ba3e9aa6bde29fb3cd930e97ad989fd96201aece/third_party/WebKit/Source/core/css/properties/longhands/OffsetPathCustom.cpp
[modify] https://crrev.com/ba3e9aa6bde29fb3cd930e97ad989fd96201aece/third_party/WebKit/Source/core/css/properties/longhands/OffsetPositionCustom.cpp
[modify] https://crrev.com/ba3e9aa6bde29fb3cd930e97ad989fd96201aece/third_party/WebKit/Source/core/css/properties/longhands/OffsetRotateCustom.cpp
[modify] https://crrev.com/ba3e9aa6bde29fb3cd930e97ad989fd96201aece/third_party/WebKit/Source/core/css/properties/shorthands/OffsetCustom.cpp

►

Issue 788554 link

Issue metadata

Move CSSPropertyNames' getPropertyName etc. to CSSProperty subclasses.

Issue description

Comment 1 by nainar@chromium.org, Dec 6 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Dec 18 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Dec 18 2017

Comment 3 Deleted

Comment 4 by rjwright@chromium.org, Dec 18 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Dec 18 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Dec 19 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Jan 8 2018

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Jan 9 2018

Comment 8 Deleted

Sign in to add a comment