New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment
link

Issue 788539: CHECK failure: frame_state->opcode() == IrOpcode::kFrameState || (node->opcode() == IrOpcode::k

Reported by ClusterFuzz, Nov 26 2017 Project Member

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5786307229122560

Fuzzer: mbarbella_js_mutation
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: CHECK failure
Crash Address: 
Crash State:
  frame_state->opcode() == IrOpcode::kFrameState || (node->opcode() == IrOpcode::k
  v8::platform::PrintStackTrace
  v8::internal::compiler::Verifier::Visitor::Check
  
Sanitizer: address (ASAN)

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5786307229122560

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 

Comment 1 by jialiul@chromium.org, Nov 26 2017

Labels: Security_Impact-Head

Comment 2 by jialiul@chromium.org, Nov 26 2017

Components: -Blink>JavaScript Blink>JavaScript>Compiler
Owner: bmeu...@chromium.org
Status: Assigned (was: Untriaged)
bmeurer@, could you take a look at this issue?  Thanks!

Comment 3 by jialiul@chromium.org, Nov 26 2017

Labels: M-63

Comment 4 by sheriffbot@chromium.org, Nov 26 2017

Project Member
Labels: -Security_Impact-Head Security_Impact-Beta

Comment 5 by sheriffbot@chromium.org, Nov 26 2017

Project Member
Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by sheriffbot@chromium.org, Nov 26 2017

Project Member
Labels: Pri-1

Comment 7 by gov...@chromium.org, Nov 27 2017

Cc: awhalley@chromium.org
+awhalley@

Comment 8 by bmeu...@chromium.org, Nov 27 2017

Cc: bmeu...@chromium.org mvstan...@chromium.org jarin@chromium.org
Owner: tebbi@chromium.org

Comment 9 by bugdroid1@chromium.org, Nov 28 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/904c3a1f091d3ff6f19451fced343392a5ec944a

commit 904c3a1f091d3ff6f19451fced343392a5ec944a
Author: Tobias Tebbi <tebbi@chromium.org>
Date: Tue Nov 28 09:09:09 2017

[turbofan] fix dead code elimination: propagate DeadValue along FrameState inputs

Bug:  chromium:788539 
Change-Id: I75b6ef7e486b578f123747d79f52c9eb45a0370e
Reviewed-on: https://chromium-review.googlesource.com/792050
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49654}
[modify] https://crrev.com/904c3a1f091d3ff6f19451fced343392a5ec944a/src/compiler/dead-code-elimination.cc
[add] https://crrev.com/904c3a1f091d3ff6f19451fced343392a5ec944a/test/mjsunit/compiler/regress-788539.js

Comment 10 by tebbi@chromium.org, Nov 28 2017

Labels: -M-63 M-64
Status: Fixed (was: Assigned)

Comment 11 by tebbi@chromium.org, Nov 28 2017

Labels: -Security_Impact-Beta
This issue was introduced by https://chromium-review.googlesource.com/772150, so it doesn't affect M63.

Comment 12 by sheriffbot@chromium.org, Nov 28 2017

Project Member
Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify

Comment 13 by awhalley@google.com, Nov 28 2017

Labels: Security_Impact-Head
thanks!

Comment 14 by ClusterFuzz, Nov 29 2017

Project Member
ClusterFuzz has detected this issue as fixed in range 49653:49654.

Detailed report: https://clusterfuzz.com/testcase?key=5786307229122560

Fuzzer: mbarbella_js_mutation
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: CHECK failure
Crash Address: 
Crash State:
  frame_state->opcode() == IrOpcode::kFrameState || (node->opcode() == IrOpcode::k
  v8::platform::PrintStackTrace
  v8::internal::compiler::Verifier::Visitor::Check
  
Sanitizer: address (ASAN)

Fixed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=49653:49654

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5786307229122560

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Comment 15 by ClusterFuzz, Nov 29 2017

Project Member
Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5786307229122560 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 16 by sheriffbot@chromium.org, Mar 6 2018

Project Member
Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 17 by sheriffbot@chromium.org, Mar 27 2018

Project Member
Labels: -Security_Impact-Head -M-64 M-65 Security_Impact-Stable

Comment 18 by awhalley@google.com, Mar 31 2018

Labels: -ReleaseBlock-Stable

Sign in to add a comment