chome.app.window.create API with showInSelf set to true does not show shelf icon on consecutive window launch
Reported by
srinivas...@gmail.com,
Nov 26 2017
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 9901.77.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.97 Safari/537.36 Platform: 9901.77.0 (Official Build) stable-channel link Steps to reproduce the problem: 1. Launch the attached sample app 2. It launches with separate shelf icon for window 3. Close the window and launch it again 4. Consecutive launches does not show the shelf icon specified in the createWindowOptions What is the expected behavior? shelf icon for the window should be shown always What went wrong? Close the window and relaunch it for consecutive times does not show the shelf icon. Reload the app again and then launch it to get the shelf again. Did this work before? N/A Does this work in other browsers? N/A Chrome version: 62.0.3202.97 Channel: stable OS Version: 9901.77.0 Flash Version: With showInShelf option set to true and with icon image available, the created window is expected to show the shelf icon for the window.
,
Jan 19 2018
,
Jan 22 2018
mws@, Any idea on who works on the chrome.app.window.create API?
,
Jan 24 2018
I don't know who's actively working in this area. CC'ing some relevant folks.
,
Jan 24 2018
Probably I have recent experience here.
,
Jan 31 2018
trying to load app in Chrome (extensions->developer mode) - Could not load manifest.
,
Jan 31 2018
#6 - nvm, could repro using another test app.
,
Jan 31 2018
race condition in main body load and icon load. Also 735842 disabled test SetIcon for a long time and this problem is hidden.
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65af1ea1670045ddbcad0909d2b0798155bfdc3a commit 65af1ea1670045ddbcad0909d2b0798155bfdc3a Author: khmel <khmel@google.com> Date: Fri Feb 02 04:45:38 2018 Fix race condition on loading custom app icon. Custom app icon loading is started immidiatelly when it is assigned, including the case when it is set as a create parameter for Chrome app window. In last case icon gets loaded in together with main page content loaded. Here is the race. If page is loaded first it commits navigation which abort all pending resource load requests, including the custom icon. As result custom icon is not loaded. Solution is to start custom icon loading only when app window is ready. Test: Manually Bug: 788531 Change-Id: If72a094a846b87f45bfe60bfbbcb7889281579c5 Reviewed-on: https://chromium-review.googlesource.com/895200 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#533958} [modify] https://crrev.com/65af1ea1670045ddbcad0909d2b0798155bfdc3a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc [modify] https://crrev.com/65af1ea1670045ddbcad0909d2b0798155bfdc3a/chrome/browser/ui/test/test_app_window_icon_observer.cc [modify] https://crrev.com/65af1ea1670045ddbcad0909d2b0798155bfdc3a/chrome/browser/ui/test/test_app_window_icon_observer.h [modify] https://crrev.com/65af1ea1670045ddbcad0909d2b0798155bfdc3a/chrome/test/data/extensions/platform_apps/app_icon/test.js [modify] https://crrev.com/65af1ea1670045ddbcad0909d2b0798155bfdc3a/extensions/browser/app_window/app_window.cc [modify] https://crrev.com/65af1ea1670045ddbcad0909d2b0798155bfdc3a/extensions/browser/app_window/app_window.h
,
Feb 5 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by vsu...@chromium.org
, Jan 16 2018