New issue
Advanced search Search tips

Issue 788467 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

thorough component updater unittest

Project Member Reported by xiaochu@chromium.org, Nov 25 2017

Issue description

1. modify imageloader dbus client in chrome to emulate chrome os dbus call.
 
Description: Show this description
Summary: thorough component updater unittest (was: modify imageloader dbus client in chrome to emulate chrome os on linux)
Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b9fb998ce9d71662d2508e47a01b6805a4aa817

commit 0b9fb998ce9d71662d2508e47a01b6805a4aa817
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Fri Jan 05 18:26:32 2018

make CrOSComponent a real object

I make CrOSComponent a real object and a member variable of chromeos
browser process. It is constructed/deconstructed accordingly in browser
process. Compatible component states are moved into CrOSComponent
object.

Additions: better unittest.

BUG= chromium:788467 
TEST=better unittest. simplified naming.

Change-Id: I64b649b238e299d9959ee2e4fb4d76cf8a0ce7bb
Reviewed-on: https://chromium-review.googlesource.com/826122
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527327}
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chrome/browser/browser_process_platform_part_chromeos.cc
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chrome/browser/browser_process_platform_part_chromeos.h
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chrome/browser/chromeos/dbus/chrome_component_updater_service_provider_delegate.cc
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chrome/browser/chromeos/dbus/chrome_component_updater_service_provider_delegate.h
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chrome/browser/chromeos/printing/printer_configurer.cc
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chrome/browser/component_updater/cros_component_installer.cc
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chrome/browser/component_updater/cros_component_installer.h
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chrome/browser/component_updater/cros_component_installer_unittest.cc
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chrome/browser/extensions/api/media_perception_private/media_perception_api_delegate_chromeos.cc
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chromeos/dbus/fake_image_loader_client.cc
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chromeos/dbus/fake_image_loader_client.h
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chromeos/dbus/image_loader_client.cc
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chromeos/dbus/image_loader_client.h
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chromeos/dbus/services/component_updater_service_provider.cc
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/chromeos/dbus/services/component_updater_service_provider.h
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/components/component_updater/component_updater_service.h
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/extensions/browser/api/media_perception_private/media_perception_api_delegate.h
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/extensions/browser/api/media_perception_private/media_perception_api_manager.cc
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/extensions/browser/api/media_perception_private/media_perception_api_manager.h
[modify] https://crrev.com/0b9fb998ce9d71662d2508e47a01b6805a4aa817/extensions/browser/api/media_perception_private/media_perception_private_apitest.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment