Off by one error frequently seen for exo client shadow |
|||
Issue descriptionThere's often a one pixel wide gap between app and shadow for Android and other exo clients.
,
Nov 24 2017
Is this only on high-dpi devices?
,
Nov 25 2017
No, all devices.
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60c9b2421f33b4e329270f678a6459bad4281e1d commit 60c9b2421f33b4e329270f678a6459bad4281e1d Author: David Reveman <reveman@chromium.org> Date: Tue Nov 28 02:24:50 2017 ui: Fix rounded corner radius for shadows. This makes sure nine-patch is updated when rounded corner radius has changed and not only when elevation has changed. WMTestSuite has also been updated to allow tests that call into skia and use discardable memory (needed for corner radius test). Bug: 788461 Tbr: sadrul@chromium.org Test: wm_unittests --gtest_fiter=ShadowTest.AdjustRoundedCornerRadius Change-Id: I4489fbf11416559a3da8ac3b194f96c59ed5801c Reviewed-on: https://chromium-review.googlesource.com/789730 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#519527} [modify] https://crrev.com/60c9b2421f33b4e329270f678a6459bad4281e1d/ui/wm/core/shadow.cc [modify] https://crrev.com/60c9b2421f33b4e329270f678a6459bad4281e1d/ui/wm/core/shadow.h [modify] https://crrev.com/60c9b2421f33b4e329270f678a6459bad4281e1d/ui/wm/core/shadow_unittest.cc [modify] https://crrev.com/60c9b2421f33b4e329270f678a6459bad4281e1d/ui/wm/test/run_all_unittests.cc
,
Nov 28 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by reve...@chromium.org
, Nov 24 2017