Fill phones that have a format placeholder in the value field. |
||
Issue descriptionThe issue arises from the fact that some sites use the value of the field along with some JavaScript to create their "placeholder". The problem does not happen if the field is tagged with a placeholder attribute. What generally happens is that by default the fields will have a value set, "First Name" for example. It will be styled like a placeholder (grey) and will get removed by JavaScript when the user clicks on the field. Thus it behaves like a placeholder from the point of view of the user. However, Autofill does not overwrite values in fields. The reason is that we would not want to replace a value that the user entered. Sites: thenorthface.com vans.com jomashop.com timberland.com
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a4fd9674bf8898ca70ced48ba4c121ff5ceb703 commit 2a4fd9674bf8898ca70ced48ba4c121ff5ceb703 Author: Parastoo Geranmayeh <parastoog@google.com> Date: Thu Dec 07 22:21:53 2017 Autofill fields with values added by website. Sometimes, the website enters a value for a field as a string formatting. This value is taken as the value entered by the user, and thus the field is not filled by the Autofill. Solution: If the entered value doesn't look like a real value, and looks more like a string formatting, ignore the entered value, and autofill the field. Tests Added. Bug: 788450 Change-Id: I1d27691e57c9162f75ecdacee4683472e3137048 Reviewed-on: https://chromium-review.googlesource.com/801051 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#522574} [modify] https://crrev.com/2a4fd9674bf8898ca70ced48ba4c121ff5ceb703/chrome/renderer/autofill/form_autofill_browsertest.cc [modify] https://crrev.com/2a4fd9674bf8898ca70ced48ba4c121ff5ceb703/components/autofill/content/renderer/form_autofill_util.cc [modify] https://crrev.com/2a4fd9674bf8898ca70ced48ba4c121ff5ceb703/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/2a4fd9674bf8898ca70ced48ba4c121ff5ceb703/components/autofill/core/common/autofill_util.cc [modify] https://crrev.com/2a4fd9674bf8898ca70ced48ba4c121ff5ceb703/components/autofill/core/common/autofill_util.h
,
Dec 21 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by parastoog@chromium.org
, Nov 28 2017