New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788439 link

Starred by 17 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 1
Type: Feature


Sign in to add a comment

[Canvas] Low latency rendering mode

Project Member Reported by junov@chromium.org, Nov 24 2017

Issue description

Comment 1 by junov@chromium.org, Nov 24 2017

Blockedon: 788234
Blocking: 732814
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce8833ddce0737e50cd3894eec2abb7cc5ea0b12

commit ce8833ddce0737e50cd3894eec2abb7cc5ea0b12
Author: Justin Novosad <junov@chromium.org>
Date: Wed Nov 29 17:31:21 2017

Simplify OffscreenCanvasResourceProvider

There was a flickering bug with OffscreenCanvasResourceProvider::
SetTransferableResourceToSharedGPUContext(), probably due to
state tracking of the GL texture object. Instead of fixing it,
we can just use the nice pre-canned RAII model provided by
AcceleratedStaticBitmapImage.  This makes the code much simpler
and it fixes the glitch.

BUG=788439
TBR=xlai@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ifb19e96802c4ed1e41c8a01101066a0d7e3ab22a
Reviewed-on: https://chromium-review.googlesource.com/794108
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520155}
[modify] https://crrev.com/ce8833ddce0737e50cd3894eec2abb7cc5ea0b12/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/ce8833ddce0737e50cd3894eec2abb7cc5ea0b12/third_party/WebKit/Source/platform/graphics/OffscreenCanvasResourceProvider.cpp
[modify] https://crrev.com/ce8833ddce0737e50cd3894eec2abb7cc5ea0b12/third_party/WebKit/Source/platform/graphics/OffscreenCanvasResourceProvider.h

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae8f714d41b0141638b6d17d70dbe1d8e726024a

commit ae8f714d41b0141638b6d17d70dbe1d8e726024a
Author: Justin Novosad <junov@chromium.org>
Date: Thu Nov 30 16:09:48 2017

Add low latency canvas code path via SurfaceLayer

This CL re-purposes the commit flow from OffscreenCanvas for push
<canvas> frames in low latency mode.  It also turns on low latency
input events when ther are event listeners registered on the canvas.

TBR=zmo@chromium.org

Bug: 788439
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8be2755ba953fd2c77e2420356ad582d96b95e7a
Reviewed-on: https://chromium-review.googlesource.com/793950
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520557}
[add] https://crrev.com/ae8f714d41b0141638b6d17d70dbe1d8e726024a/content/test/data/gpu/pixel_canvas_low_latency_2d.html
[modify] https://crrev.com/ae8f714d41b0141638b6d17d70dbe1d8e726024a/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/ae8f714d41b0141638b6d17d70dbe1d8e726024a/content/test/gpu/gpu_tests/pixel_test_pages.py
[add] https://crrev.com/ae8f714d41b0141638b6d17d70dbe1d8e726024a/third_party/WebKit/ManualTests/canvas-low-latency.html
[modify] https://crrev.com/ae8f714d41b0141638b6d17d70dbe1d8e726024a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/ae8f714d41b0141638b6d17d70dbe1d8e726024a/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
[modify] https://crrev.com/ae8f714d41b0141638b6d17d70dbe1d8e726024a/third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl
[modify] https://crrev.com/ae8f714d41b0141638b6d17d70dbe1d8e726024a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/ae8f714d41b0141638b6d17d70dbe1d8e726024a/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/ae8f714d41b0141638b6d17d70dbe1d8e726024a/third_party/WebKit/Source/platform/graphics/GraphicsTypes.h
[modify] https://crrev.com/ae8f714d41b0141638b6d17d70dbe1d8e726024a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/ae8f714d41b0141638b6d17d70dbe1d8e726024a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h
[modify] https://crrev.com/ae8f714d41b0141638b6d17d70dbe1d8e726024a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp
[modify] https://crrev.com/ae8f714d41b0141638b6d17d70dbe1d8e726024a/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f913f8dd9fd03078f4c0786c91837dfab07698c7

commit f913f8dd9fd03078f4c0786c91837dfab07698c7
Author: Justin Novosad <junov@chromium.org>
Date: Thu Nov 30 17:31:53 2017

Make CanvasResource RefCounted

This is a step towards unifying OffscreenCanvasResourceProvider
with CanvasResourceProvider, which will eventually allow low
latency canvas rendering to use a single buffered GpuMemoryBuffer

BUG=788439,  776801 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie9f04e7920e7d74c229c4d45c34c371ab5d06e36
Reviewed-on: https://chromium-review.googlesource.com/800670
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520586}
[modify] https://crrev.com/f913f8dd9fd03078f4c0786c91837dfab07698c7/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp
[modify] https://crrev.com/f913f8dd9fd03078f4c0786c91837dfab07698c7/third_party/WebKit/Source/platform/graphics/CanvasResource.h
[modify] https://crrev.com/f913f8dd9fd03078f4c0786c91837dfab07698c7/third_party/WebKit/Source/platform/graphics/CanvasResourceProvider.cpp
[modify] https://crrev.com/f913f8dd9fd03078f4c0786c91837dfab07698c7/third_party/WebKit/Source/platform/graphics/CanvasResourceProvider.h

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f6bce25c2f94e59611343ddab1fffcc13f79f07

commit 4f6bce25c2f94e59611343ddab1fffcc13f79f07
Author: Justin Novosad <junov@chromium.org>
Date: Tue Dec 05 22:44:49 2017

Move TransferableResource creation to Canvas Resource

This change makes it possible to decouple the actions of capturing an
animation frame from a canvas and sending it to the compositor.
This is a prerequisite for mergin OffscreenCanvasResourceProdiver
with CanvasResourceProvider.

Bug: 788439,  776801 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iaf4563069ede53b1bba8bde5ea8b693d4c1a2b73
Reviewed-on: https://chromium-review.googlesource.com/803945
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521868}
[modify] https://crrev.com/4f6bce25c2f94e59611343ddab1fffcc13f79f07/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/4f6bce25c2f94e59611343ddab1fffcc13f79f07/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp
[modify] https://crrev.com/4f6bce25c2f94e59611343ddab1fffcc13f79f07/third_party/WebKit/Source/platform/graphics/CanvasResource.h
[modify] https://crrev.com/4f6bce25c2f94e59611343ddab1fffcc13f79f07/third_party/WebKit/Source/platform/graphics/CanvasResourceProvider.cpp
[modify] https://crrev.com/4f6bce25c2f94e59611343ddab1fffcc13f79f07/third_party/WebKit/Source/platform/graphics/CanvasResourceProvider.h
[modify] https://crrev.com/4f6bce25c2f94e59611343ddab1fffcc13f79f07/third_party/WebKit/Source/platform/graphics/CanvasResourceTest.cpp

Comment 6 by junov@chromium.org, Dec 13 2017

Labels: -M-64 M-65
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6

commit 2e4a432454ac3f04d6c5fa8f17c49ce3026217d6
Author: Justin Novosad <junov@chromium.org>
Date: Thu Dec 14 22:37:30 2017

Replace CanvasResource_Skia with CanvasResource_Bitmap

This change refactors the existing CanvasResource_Skia to make it
store a StaticBitmapImage instead of an SkImage intenally. This
simplifies the gpu mailbox management code by re-using the
functionality provided by StaticBitmapImage. It also bring the code
closer to unifying OffscreenCanvasResourceProvider with
CanvasResourceProvider

BUG=788439, 776801 
TBR=bajones@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia57a68e1a61763daa158403e258b89b56a82a6f7
Reviewed-on: https://chromium-review.googlesource.com/820251
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524204}
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/CanvasResource.h
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/CanvasResourceProvider.cpp
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/CanvasResourceTest.cpp
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/GpuMemoryBufferImageCopy.cpp
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/MailboxTextureHolder.cpp
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/MailboxTextureHolder.h
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/OffscreenCanvasResourceProvider.cpp
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/TextureHolder.h
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/gpu/GraphicsContext3DUtils.cpp
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/gpu/GraphicsContext3DUtils.h
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/gpu/ImageLayerBridge.cpp
[modify] https://crrev.com/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContextTest.cpp

Comment 8 by junov@chromium.org, Feb 27 2018

Labels: -M-65 M-67
Cc: tbuck...@chromium.org
@junov, are there any updates on this for M67?

Comment 11 by junov@chromium.org, Apr 24 2018

Cc: junov@chromium.org
Owner: mcasas@chromium.org
Status: Assigned (was: Started)
Project Member

Comment 12 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/394023960b2756b2dd4e26ef9890989235a2ed36

commit 394023960b2756b2dd4e26ef9890989235a2ed36
Author: Justin Novosad <junov@chromium.org>
Date: Wed May 09 21:35:21 2018

Use IntSize for size in OffscreenCanvasFrameDispatcher

This change is on the path to replacing OffscreenCanvasResourceProvider
with CanvasResourceProvider

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I34637343dbd7693cbbfe099061b18a8cfd2094b7
Reviewed-on: https://chromium-review.googlesource.com/1052923
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557324}
[modify] https://crrev.com/394023960b2756b2dd4e26ef9890989235a2ed36/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/394023960b2756b2dd4e26ef9890989235a2ed36/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/394023960b2756b2dd4e26ef9890989235a2ed36/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.cc
[modify] https://crrev.com/394023960b2756b2dd4e26ef9890989235a2ed36/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.h
[modify] https://crrev.com/394023960b2756b2dd4e26ef9890989235a2ed36/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc

Project Member

Comment 13 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b152cd12f8e5758fbe14e11eeeead2f3378df978

commit b152cd12f8e5758fbe14e11eeeead2f3378df978
Author: Justin Novosad <junov@chromium.org>
Date: Thu May 10 14:25:44 2018

Adding some utility functions to CanvasResource

This CL is a step towards removing OffscreenCanvasResourceProvider

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I78972f67aa8849de59690f591d69c534bdc08a42
Reviewed-on: https://chromium-review.googlesource.com/1053173
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557507}
[modify] https://crrev.com/b152cd12f8e5758fbe14e11eeeead2f3378df978/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/b152cd12f8e5758fbe14e11eeeead2f3378df978/third_party/blink/renderer/platform/graphics/canvas_resource.h
[modify] https://crrev.com/b152cd12f8e5758fbe14e11eeeead2f3378df978/third_party/blink/renderer/platform/graphics/canvas_resource_test.cc

Project Member

Comment 14 by bugdroid1@chromium.org, May 10 2018

Project Member

Comment 15 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fff46f43cd4a4cfdd00dc5c1fb936805df9da0a

commit 4fff46f43cd4a4cfdd00dc5c1fb936805df9da0a
Author: Justin Novosad <junov@chromium.org>
Date: Fri May 11 15:39:13 2018

Add MakeUnaccelerated method to CanvasResource

This change is a component of a larger refactor that transitions
OffscreenCanvas to using CanvasResource.

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id58bca5a71ec4eaad2513a099571e073a34ec866
Reviewed-on: https://chromium-review.googlesource.com/1053999
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557890}
[modify] https://crrev.com/4fff46f43cd4a4cfdd00dc5c1fb936805df9da0a/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/4fff46f43cd4a4cfdd00dc5c1fb936805df9da0a/third_party/blink/renderer/platform/graphics/canvas_resource.h
[modify] https://crrev.com/4fff46f43cd4a4cfdd00dc5c1fb936805df9da0a/third_party/blink/renderer/platform/graphics/canvas_resource_test.cc

Project Member

Comment 16 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2305b38ee8350095c8649892b6a8ee927da82e15

commit 2305b38ee8350095c8649892b6a8ee927da82e15
Author: Justin Novosad <junov@chromium.org>
Date: Wed May 23 16:28:11 2018

Add CanvasColorParams to CanvasResource

This channge allow the color spaces of resources to be managed from
withing CanvasResource, which will be convenient when we'll have
multiple call sites for CanvasResource::PrepareTransferableResource

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1587677c4f2e75c713e220607d82061767afc820
Reviewed-on: https://chromium-review.googlesource.com/1070218
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561115}
[modify] https://crrev.com/2305b38ee8350095c8649892b6a8ee927da82e15/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/2305b38ee8350095c8649892b6a8ee927da82e15/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/2305b38ee8350095c8649892b6a8ee927da82e15/third_party/blink/renderer/platform/graphics/canvas_resource.h
[modify] https://crrev.com/2305b38ee8350095c8649892b6a8ee927da82e15/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/2305b38ee8350095c8649892b6a8ee927da82e15/third_party/blink/renderer/platform/graphics/canvas_resource_test.cc

Project Member

Comment 17 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3736b8265b623b6a477f2d8112c353abac436593

commit 3736b8265b623b6a477f2d8112c353abac436593
Author: Justin Novosad <junov@chromium.org>
Date: Wed May 23 19:54:19 2018

Re-arrange CanvasResourceHost class hierarchy

With this change, HTMLCanvasElement now inherrits CanvasResourceHost
indirectly via CanvasResourceProviderHost, this means that
OffscreenCanvas now also inherrits CanvasResourceHost, thus making
CanvasResourceHost a good place to put CanvasResourceProvider-related
interfaces and code that will be shared between OffscreenCanvas
and HTMLCanvasElement will be moved to CanvasResourceProviderHost
in a future CL.

This CL is a small chunk of a large refactor. For part of the full
picture, see:
https://chromium-review.googlesource.com/c/chromium/src/+/1057437

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7ba0c159c0ad72a8c1970341638c4742f597eeae
Reviewed-on: https://chromium-review.googlesource.com/1067647
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561218}
[modify] https://crrev.com/3736b8265b623b6a477f2d8112c353abac436593/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
[modify] https://crrev.com/3736b8265b623b6a477f2d8112c353abac436593/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
[modify] https://crrev.com/3736b8265b623b6a477f2d8112c353abac436593/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/3736b8265b623b6a477f2d8112c353abac436593/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/3736b8265b623b6a477f2d8112c353abac436593/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
[modify] https://crrev.com/3736b8265b623b6a477f2d8112c353abac436593/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/3736b8265b623b6a477f2d8112c353abac436593/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
[modify] https://crrev.com/3736b8265b623b6a477f2d8112c353abac436593/third_party/blink/renderer/platform/graphics/canvas_resource_host.h

Project Member

Comment 18 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d58a24353033b9213b3076bb7c603519f76dc852

commit d58a24353033b9213b3076bb7c603519f76dc852
Author: Justin Novosad <junov@chromium.org>
Date: Mon May 28 20:13:58 2018

Use CanvasResource as a vehicle for OffscreenCanvas placeholder frames

This is an incremental step toward unifying <canvas> and
OffscreenCanvas around CanvasResource.

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2445e5cbe63f4ae329afd13cb07d3211e0f4de56
Reviewed-on: https://chromium-review.googlesource.com/1073634
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562304}
[modify] https://crrev.com/d58a24353033b9213b3076bb7c603519f76dc852/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/d58a24353033b9213b3076bb7c603519f76dc852/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/d58a24353033b9213b3076bb7c603519f76dc852/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc
[modify] https://crrev.com/d58a24353033b9213b3076bb7c603519f76dc852/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/d58a24353033b9213b3076bb7c603519f76dc852/third_party/blink/renderer/platform/graphics/canvas_resource.h
[modify] https://crrev.com/d58a24353033b9213b3076bb7c603519f76dc852/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.cc
[modify] https://crrev.com/d58a24353033b9213b3076bb7c603519f76dc852/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.h
[modify] https://crrev.com/d58a24353033b9213b3076bb7c603519f76dc852/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc
[modify] https://crrev.com/d58a24353033b9213b3076bb7c603519f76dc852/third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.cc
[modify] https://crrev.com/d58a24353033b9213b3076bb7c603519f76dc852/third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.h

Project Member

Comment 19 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aeaf3cd332e1815789bdb45c19d70f1df82a3f35

commit aeaf3cd332e1815789bdb45c19d70f1df82a3f35
Author: Justin Novosad <junov@chromium.org>
Date: Tue May 29 15:30:01 2018

Move CanvasResourceProvider ownership up to CanvasResourceHost

This change pushes HTMLCanvasElement's CanvasResourceProvider
up the class hierachy so that it can be shared with
OffscreenCanvas. The next step is to remove
Canvas2DLayerBridge's resource provider to use this shared one
instead.

BUG=788439
TBR=zmo@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib85237d0ee98205c5da8848cbd861ce6d5d9d4d2
Reviewed-on: https://chromium-review.googlesource.com/1075729
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562433}
[modify] https://crrev.com/aeaf3cd332e1815789bdb45c19d70f1df82a3f35/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
[modify] https://crrev.com/aeaf3cd332e1815789bdb45c19d70f1df82a3f35/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
[modify] https://crrev.com/aeaf3cd332e1815789bdb45c19d70f1df82a3f35/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/aeaf3cd332e1815789bdb45c19d70f1df82a3f35/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/aeaf3cd332e1815789bdb45c19d70f1df82a3f35/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/aeaf3cd332e1815789bdb45c19d70f1df82a3f35/third_party/blink/renderer/platform/BUILD.gn
[add] https://crrev.com/aeaf3cd332e1815789bdb45c19d70f1df82a3f35/third_party/blink/renderer/platform/graphics/canvas_resource_host.cc
[modify] https://crrev.com/aeaf3cd332e1815789bdb45c19d70f1df82a3f35/third_party/blink/renderer/platform/graphics/canvas_resource_host.h

Project Member

Comment 20 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5baae128c31880177c202d14b9efdd61a046887

commit b5baae128c31880177c202d14b9efdd61a046887
Author: Justin Novosad <junov@chromium.org>
Date: Tue May 29 17:20:08 2018

Use CanvasResource more in OffscreenCanvasFrameDispatcher

Use CanvasResource instead of StaticBitmapImage in more places
in OffscreenCanvasFrameDispatcher. This change brings us closer to
unifying <canvas> and OffscreenCanvas resource management.

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2595acf5733015d1c892995181897be90d6619c5
Reviewed-on: https://chromium-review.googlesource.com/1076309
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562478}
[modify] https://crrev.com/b5baae128c31880177c202d14b9efdd61a046887/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/b5baae128c31880177c202d14b9efdd61a046887/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.cc
[modify] https://crrev.com/b5baae128c31880177c202d14b9efdd61a046887/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.h

Project Member

Comment 21 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf822f7d4dc10cf2fc9cf3e7d1e6dfbc53a560c1

commit bf822f7d4dc10cf2fc9cf3e7d1e6dfbc53a560c1
Author: Justin Novosad <junov@chromium.org>
Date: Tue May 29 21:36:29 2018

Refactor Canvas2DLayerBridge tests to use CanvasResourceProviderHost

This change prepares unit tests for having a new dependency on
CanvasResourceProviderHost, which will soon be the owner
of the CanvasResourceProvider instance used by 2D canvas.

Drive-by refactor: some tests that were formerly implemented in
fixture methods (for no good reason) were moved out.

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I68331760a9ecb47efc6d91b185dd4ddc7a38dee8
Reviewed-on: https://chromium-review.googlesource.com/1077068
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562600}
[modify] https://crrev.com/bf822f7d4dc10cf2fc9cf3e7d1e6dfbc53a560c1/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/bf822f7d4dc10cf2fc9cf3e7d1e6dfbc53a560c1/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
[add] https://crrev.com/bf822f7d4dc10cf2fc9cf3e7d1e6dfbc53a560c1/third_party/blink/renderer/platform/graphics/test/fake_canvas_resource_host.h

Project Member

Comment 22 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/099c819eadedc3dc0eec3547761714984e5a39b9

commit 099c819eadedc3dc0eec3547761714984e5a39b9
Author: Justin Novosad <junov@chromium.org>
Date: Wed May 30 22:14:38 2018

Make Canvas2DLayerBridge use CanvasResourceHost

This change makes Canvas2DLayerBridge use the instance of
CanvasResourceProvider that is stored in CanvasResourceHost.
This moves the code towards having a single location for
the resource provider for all use cases.

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib2fbda6d2853da6ca8f35325380a1674bde0ff5d
Reviewed-on: https://chromium-review.googlesource.com/1079192
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563017}
[modify] https://crrev.com/099c819eadedc3dc0eec3547761714984e5a39b9/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/099c819eadedc3dc0eec3547761714984e5a39b9/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/099c819eadedc3dc0eec3547761714984e5a39b9/third_party/blink/renderer/core/paint/html_canvas_painter_test.cc
[modify] https://crrev.com/099c819eadedc3dc0eec3547761714984e5a39b9/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
[modify] https://crrev.com/099c819eadedc3dc0eec3547761714984e5a39b9/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/099c819eadedc3dc0eec3547761714984e5a39b9/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
[modify] https://crrev.com/099c819eadedc3dc0eec3547761714984e5a39b9/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc

Project Member

Comment 23 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7a84fa1200879e685456528f5ab3f0327097073

commit a7a84fa1200879e685456528f5ab3f0327097073
Author: Justin Novosad <junov@chromium.org>
Date: Thu May 31 19:26:18 2018

Simplify SyncToken logic in CanvasResource

CanvasResource was deferring some calls to WaitSyncToken.
There is no evidence that this deferral affect performance and
it adds unnecessary complexity to the code that makes refactoring
harder and more bug prone.  Therefore, the logic is being removed.

BUG=788439
NOTRY=true

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9864d2ccdd300b535ba9292373577bd09f9f5f7c
Reviewed-on: https://chromium-review.googlesource.com/1080048
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563345}
[modify] https://crrev.com/a7a84fa1200879e685456528f5ab3f0327097073/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/a7a84fa1200879e685456528f5ab3f0327097073/third_party/blink/renderer/platform/graphics/canvas_resource.h
[modify] https://crrev.com/a7a84fa1200879e685456528f5ab3f0327097073/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/a7a84fa1200879e685456528f5ab3f0327097073/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.cc

Project Member

Comment 24 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4597579c706947f027c2158b84181923f3dbaf3f

commit 4597579c706947f027c2158b84181923f3dbaf3f
Author: Justin Novosad <junov@chromium.org>
Date: Thu May 31 22:08:02 2018

Make Gpu-accelerated OffscreenCanvases use CanvasResource

This is a step towards merging resource management code between <canvas>
and OffscreenCanvas.  With this CL, submitting GPU-accelerated images
from an OffscreenCanvas uses CanvasResource for preparing the
transferable resource.

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8092e77af2b20ce3f270e9ab5408f5ee1aec035e
Reviewed-on: https://chromium-review.googlesource.com/1069803
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563391}
[modify] https://crrev.com/4597579c706947f027c2158b84181923f3dbaf3f/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/4597579c706947f027c2158b84181923f3dbaf3f/third_party/blink/renderer/platform/graphics/canvas_color_params.cc
[modify] https://crrev.com/4597579c706947f027c2158b84181923f3dbaf3f/third_party/blink/renderer/platform/graphics/canvas_color_params.h
[modify] https://crrev.com/4597579c706947f027c2158b84181923f3dbaf3f/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/4597579c706947f027c2158b84181923f3dbaf3f/third_party/blink/renderer/platform/graphics/canvas_resource.h
[modify] https://crrev.com/4597579c706947f027c2158b84181923f3dbaf3f/third_party/blink/renderer/platform/graphics/canvas_resource_test.cc
[modify] https://crrev.com/4597579c706947f027c2158b84181923f3dbaf3f/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.cc
[modify] https://crrev.com/4597579c706947f027c2158b84181923f3dbaf3f/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.cc
[modify] https://crrev.com/4597579c706947f027c2158b84181923f3dbaf3f/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.h

Project Member

Comment 25 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e831ba57afc38ee0074186b1f7ee75d71f2de7f

commit 7e831ba57afc38ee0074186b1f7ee75d71f2de7f
Author: Justin Novosad <junov@chromium.org>
Date: Thu May 31 22:08:19 2018

Make OffscreenCanvas use the ResourceProvider from CanvasResourceHost.

With this CL, both <canvas> and OffscreenCanvas use the same
CanvasResourceProvider reference.

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I52b8a91e18bfe2d0c003a38cb8a966b1abea7c50
Reviewed-on: https://chromium-review.googlesource.com/1079463
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563392}
[modify] https://crrev.com/7e831ba57afc38ee0074186b1f7ee75d71f2de7f/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
[modify] https://crrev.com/7e831ba57afc38ee0074186b1f7ee75d71f2de7f/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/7e831ba57afc38ee0074186b1f7ee75d71f2de7f/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/7e831ba57afc38ee0074186b1f7ee75d71f2de7f/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
[modify] https://crrev.com/7e831ba57afc38ee0074186b1f7ee75d71f2de7f/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.cc
[modify] https://crrev.com/7e831ba57afc38ee0074186b1f7ee75d71f2de7f/third_party/blink/renderer/platform/graphics/canvas_resource_host.cc
[modify] https://crrev.com/7e831ba57afc38ee0074186b1f7ee75d71f2de7f/third_party/blink/renderer/platform/graphics/canvas_resource_host.h

Project Member

Comment 26 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2be411671f7e07fc7b3220be603174de02eee030

commit 2be411671f7e07fc7b3220be603174de02eee030
Author: Justin Novosad <junov@chromium.org>
Date: Tue Jun 05 18:01:40 2018

Add SW rendering flavor to CanvasResourceGpuMemoryBuffer

This change adds a software rendering mode to
CanvasResourceGpuMemoryBuffer.  This is meant to replace (in a
follow-up CL) the presentation code path for software rendered 2d
canvases.

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8656e4efd82e1d1e6fbb853dd7dc235fd72960e0
Reviewed-on: https://chromium-review.googlesource.com/1083146
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564572}
[modify] https://crrev.com/2be411671f7e07fc7b3220be603174de02eee030/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/2be411671f7e07fc7b3220be603174de02eee030/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/2be411671f7e07fc7b3220be603174de02eee030/third_party/blink/renderer/platform/graphics/canvas_resource.h
[modify] https://crrev.com/2be411671f7e07fc7b3220be603174de02eee030/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/2be411671f7e07fc7b3220be603174de02eee030/third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
[modify] https://crrev.com/2be411671f7e07fc7b3220be603174de02eee030/third_party/blink/renderer/platform/graphics/canvas_resource_test.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6

commit f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6
Author: Justin Novosad <junov@chromium.org>
Date: Wed Jun 06 21:56:01 2018

Rename OffscreenCanvasFrameDispatcher to CanvasResourceDispatcher

This is a step in unifying canvas and OffscreenCanvas code paths

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6f3a3f7bed8b36f502bc7ce138b4bf21920629f7
Reviewed-on: https://chromium-review.googlesource.com/1089582
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565048}
[modify] https://crrev.com/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
[modify] https://crrev.com/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6/third_party/blink/renderer/modules/canvas/offscreencanvas/offscreen_canvas_test.cc
[modify] https://crrev.com/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6/third_party/blink/renderer/platform/BUILD.gn
[rename] https://crrev.com/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
[rename] https://crrev.com/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.h
[modify] https://crrev.com/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc
[modify] https://crrev.com/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6/third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.cc
[modify] https://crrev.com/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6/third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.h
[modify] https://crrev.com/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.cc
[modify] https://crrev.com/f42dbfcc4cbb63a1622ad6d91ba3984d392d7ee6/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.h

Project Member

Comment 28 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10b73ad29d4d91f4ce5a1b52ae606f1c9dd81b41

commit 10b73ad29d4d91f4ce5a1b52ae606f1c9dd81b41
Author: Justin Novosad <junov@chromium.org>
Date: Tue Jun 12 00:13:43 2018

Add tracing to CanvasResource related code

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic8d5eabeb05d0dd19d9a8e4a1f6acf0e93d9c051
Reviewed-on: https://chromium-review.googlesource.com/1094043
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566219}
[modify] https://crrev.com/10b73ad29d4d91f4ce5a1b52ae606f1c9dd81b41/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc
[modify] https://crrev.com/10b73ad29d4d91f4ce5a1b52ae606f1c9dd81b41/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/10b73ad29d4d91f4ce5a1b52ae606f1c9dd81b41/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/10b73ad29d4d91f4ce5a1b52ae606f1c9dd81b41/third_party/blink/renderer/platform/graphics/mailbox_texture_holder.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d8b8c164458e2fcc5ea31ad74f4c709948d4165

commit 0d8b8c164458e2fcc5ea31ad74f4c709948d4165
Author: Justin Novosad <junov@chromium.org>
Date: Wed Jun 13 16:50:47 2018

Make OffscreenCanvas use GpuMemoryBuffers for presentation

This CL enables GpuMemoryBuffer-backed pixel buffers for
OffscreenCanvases that are GPU-accelerated.  This should result
in the use of HW overlays on Mac and Chrome OS.

BUG=788439
TBR=zmo@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6cb30f090b1175036a64f4f122162824023f42a0
Reviewed-on: https://chromium-review.googlesource.com/1091643
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566871}
[modify] https://crrev.com/0d8b8c164458e2fcc5ea31ad74f4c709948d4165/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
[modify] https://crrev.com/0d8b8c164458e2fcc5ea31ad74f4c709948d4165/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/0d8b8c164458e2fcc5ea31ad74f4c709948d4165/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
[modify] https://crrev.com/0d8b8c164458e2fcc5ea31ad74f4c709948d4165/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/0d8b8c164458e2fcc5ea31ad74f4c709948d4165/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/0d8b8c164458e2fcc5ea31ad74f4c709948d4165/third_party/blink/renderer/platform/drag_image.cc
[modify] https://crrev.com/0d8b8c164458e2fcc5ea31ad74f4c709948d4165/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/0d8b8c164458e2fcc5ea31ad74f4c709948d4165/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/0d8b8c164458e2fcc5ea31ad74f4c709948d4165/third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
[modify] https://crrev.com/0d8b8c164458e2fcc5ea31ad74f4c709948d4165/third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc

Blockedon: 839970
Project Member

Comment 31 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3589d51340c2aec28922e156e6f6b033b5a75998

commit 3589d51340c2aec28922e156e6f6b033b5a75998
Author: Justin Novosad <junov@chromium.org>
Date: Thu Jun 14 20:51:13 2018

Add a Shared Memory variant of CanvasResourceProvider

This change adds CanvasResourceProviderSharedBitmap, and uses it
for composited software rendering use cases.

TBR=zmo@chromium.org

Bug: 788439
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibb4ea4c33ab152efac9de8ba302b055b7f830aec
Reviewed-on: https://chromium-review.googlesource.com/1099727
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567398}
[modify] https://crrev.com/3589d51340c2aec28922e156e6f6b033b5a75998/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
[modify] https://crrev.com/3589d51340c2aec28922e156e6f6b033b5a75998/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/3589d51340c2aec28922e156e6f6b033b5a75998/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
[modify] https://crrev.com/3589d51340c2aec28922e156e6f6b033b5a75998/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/3589d51340c2aec28922e156e6f6b033b5a75998/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/3589d51340c2aec28922e156e6f6b033b5a75998/third_party/blink/renderer/platform/drag_image.cc
[modify] https://crrev.com/3589d51340c2aec28922e156e6f6b033b5a75998/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/3589d51340c2aec28922e156e6f6b033b5a75998/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
[modify] https://crrev.com/3589d51340c2aec28922e156e6f6b033b5a75998/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/3589d51340c2aec28922e156e6f6b033b5a75998/third_party/blink/renderer/platform/graphics/canvas_resource.h
[modify] https://crrev.com/3589d51340c2aec28922e156e6f6b033b5a75998/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/3589d51340c2aec28922e156e6f6b033b5a75998/third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
[modify] https://crrev.com/3589d51340c2aec28922e156e6f6b033b5a75998/third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8b8872f2080130c2b5bdf026f32f46aad7598da

commit f8b8872f2080130c2b5bdf026f32f46aad7598da
Author: Justin Novosad <junov@chromium.org>
Date: Thu Jul 12 17:16:04 2018

Refactor canvas code to centralize CanvasResourceProvider ownership

With this change, CanvasResourceProvider is always owned
by CanvasResourceHost, except for a a few special case that use
ephemeral resource providers.  This is a step towards unifying
canvas and OffscreenCanvas presentation code paths.

BUG=788439
TBR=fserb@chromium.org, zmo@chromium.org
NOTRY=true

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id9bdbb2c3e93b264f67946b887419b47599df65d
Reviewed-on: https://chromium-review.googlesource.com/1134182
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574614}
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/core/paint/html_canvas_painter_test.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/modules/canvas/offscreencanvas/offscreen_canvas_test.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/platform/graphics/canvas_resource.h
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/platform/graphics/canvas_resource_host.h
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/platform/graphics/gpu/graphics_context_3d_utils.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/platform/graphics/gpu/graphics_context_3d_utils.h
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/platform/graphics/test/fake_canvas_resource_host.h
[modify] https://crrev.com/f8b8872f2080130c2b5bdf026f32f46aad7598da/third_party/blink/renderer/platform/graphics/test/fake_web_graphics_context_3d_provider.h

Project Member

Comment 33 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/21a99d42c34f44dac4a71cace9572dc244cad583

commit 21a99d42c34f44dac4a71cace9572dc244cad583
Author: Justin Novosad <junov@chromium.org>
Date: Tue Jul 17 21:32:41 2018

Fix validity check in SkSurface::MakeFromBackendTextureAsRenderTarget

Swaped the order of validate_backend_texture() and
SkSurface_Gpu::Valid() so that the pixel config computed by
validate_backend_texture() get used by SkSurface_Gpu::Valid().
This makes the behavior of this method consistent with the behavior
of sister method MakeFromBackendTexture()

BUG=788439

Change-Id: I132ea8da23430ea99bbeabce79b08edb6b4cae03
Reviewed-on: https://skia-review.googlesource.com/141837
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Auto-Submit: Justin Novosad <junov@chromium.org>

[modify] https://crrev.com/21a99d42c34f44dac4a71cace9572dc244cad583/src/image/SkSurface_Gpu.cpp

Project Member

Comment 34 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bf661e2e9555f73d4c9fba26b8dbc05d2a6f305

commit 9bf661e2e9555f73d4c9fba26b8dbc05d2a6f305
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jul 17 23:54:19 2018

Roll src/third_party/skia 3229e65886a0..21a99d42c34f (5 commits)

https://skia.googlesource.com/skia.git/+log/3229e65886a0..21a99d42c34f


git log 3229e65886a0..21a99d42c34f --date=short --no-merges --format='%ad %ae %s'
2018-07-17 junov@chromium.org Fix validity check in SkSurface::MakeFromBackendTextureAsRenderTarget
2018-07-17 ethannicholas@google.com fixed SPIR-V memory layout
2018-07-17 allanmac@google.com Use std::chrono for measuring timing
2018-07-17 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-07-17 ruiqimao@google.com fix MSAN dm failures


Created with:
  gclient setdep -r src/third_party/skia@21a99d42c34f

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:788439
TBR=bungeman@chromium.org

Change-Id: I0d28ef2fa612e4d10cb0e778a4332769bba7aa49
Reviewed-on: https://chromium-review.googlesource.com/1140537
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575852}
[modify] https://crrev.com/9bf661e2e9555f73d4c9fba26b8dbc05d2a6f305/DEPS

Project Member

Comment 35 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00d64e2ea02ea16beb67f92ee971871402185eae

commit 00d64e2ea02ea16beb67f92ee971871402185eae
Author: Justin Novosad <junov@chromium.org>
Date: Wed Jul 18 19:07:41 2018

Make WebGL use CanvasResource for submitting to OffscreenCanvas.

This CL is a step toward unifying the canvas and OffscreenCanvas
presentation code paths by making WebGL contexts use CanvasResource
to pass frames for OffscreenCanvases

This change revamps mechanisms for triggering calls to PushFrame()
The mechanisms was change to reference OffscreenCanvas object instead
of rendering contexts.  This fixes a destruction race condition where
redereng contexts were failing to de-register themselves when their
host is disposed first.  We also stop requesting BeginFrames in
OffscreenCanvasDidDraw in cases where the draw happens from within
a rAF callback on a worker.

BUG=788439
TBR=zmo@chromium.org
NOTRY=true

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I36965c4a0a892484a9ede966b268c91c7a34548f
Reviewed-on: https://chromium-review.googlesource.com/1135637
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576154}
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/core/workers/worker_animation_frame_provider.cc
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/core/workers/worker_animation_frame_provider.h
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.cc
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/platform/graphics/canvas_color_params.cc
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/platform/graphics/canvas_color_params.h
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/00d64e2ea02ea16beb67f92ee971871402185eae/third_party/blink/renderer/platform/graphics/canvas_resource_test.cc

Project Member

Comment 36 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79531c77e491dc9536c985d6c4f5dcd8c6bb48b8

commit 79531c77e491dc9536c985d6c4f5dcd8c6bb48b8
Author: Justin Novosad <junov@chromium.org>
Date: Thu Jul 19 20:45:26 2018

Make OffscreenCanvas 2d contexts use CanvasResource

This change is a step toward unifying the canvas and OffscreenCanvas
presentation code paths by making offscreen 2d contexts use
CanvasResource for pushing frames.

BUG=788439
TBR=zmo@chromium.org
NOTRY=true

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icc138c8ab53a28c16d9502ef774064acb0087ac5
Reviewed-on: https://chromium-review.googlesource.com/1135580
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576612}
[modify] https://crrev.com/79531c77e491dc9536c985d6c4f5dcd8c6bb48b8/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/79531c77e491dc9536c985d6c4f5dcd8c6bb48b8/content/test/gpu/gpu_tests/pixel_test_pages.py
[modify] https://crrev.com/79531c77e491dc9536c985d6c4f5dcd8c6bb48b8/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/79531c77e491dc9536c985d6c4f5dcd8c6bb48b8/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/79531c77e491dc9536c985d6c4f5dcd8c6bb48b8/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.cc
[modify] https://crrev.com/79531c77e491dc9536c985d6c4f5dcd8c6bb48b8/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.h
[modify] https://crrev.com/79531c77e491dc9536c985d6c4f5dcd8c6bb48b8/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/79531c77e491dc9536c985d6c4f5dcd8c6bb48b8/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc

Project Member

Comment 37 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0ec36a15791c7c2d9d470b2a172c4982cddc2ec

commit a0ec36a15791c7c2d9d470b2a172c4982cddc2ec
Author: Justin Novosad <junov@chromium.org>
Date: Thu Jul 19 23:48:48 2018

Make unaccelerated canvas resources transferable

BUG=788439
TBR=fserb@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I04200ce9cc3a8e3ab88d6d87d89630a41bd13e98
Reviewed-on: https://chromium-review.googlesource.com/1144258
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576698}
[modify] https://crrev.com/a0ec36a15791c7c2d9d470b2a172c4982cddc2ec/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/a0ec36a15791c7c2d9d470b2a172c4982cddc2ec/third_party/blink/renderer/platform/graphics/canvas_resource_test.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Jul 20

Project Member

Comment 39 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9719c572d0afb519299e2e0108eee784d280b2d

commit f9719c572d0afb519299e2e0108eee784d280b2d
Author: Justin Novosad <junov@chromium.org>
Date: Fri Jul 20 00:38:11 2018

Rebase LowLatency 2d canvas tests

BUG=788439
TBR=zmo@chromium.org
NOTRY=true

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6fdbe5e935931480817f3fd9290fae7a13c162b1
Reviewed-on: https://chromium-review.googlesource.com/1144528
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576723}
[modify] https://crrev.com/f9719c572d0afb519299e2e0108eee784d280b2d/content/test/gpu/gpu_tests/pixel_test_pages.py

Project Member

Comment 40 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/886e0902f53e9f0dcbf58c3d1274079b4bffb425

commit 886e0902f53e9f0dcbf58c3d1274079b4bffb425
Author: Justin Novosad <junov@chromium.org>
Date: Fri Jul 20 02:30:12 2018

Enable pixel tests for low latency canvas

BUG=788439
TBR=zmo@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib758904323adb6039d21f916d4aed9fdc631278e
Reviewed-on: https://chromium-review.googlesource.com/1144275
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576759}
[modify] https://crrev.com/886e0902f53e9f0dcbf58c3d1274079b4bffb425/content/test/gpu/gpu_tests/pixel_expectations.py

Blockedon: 865957
Project Member

Comment 42 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e61ec2a12b1144082f76f37144250a4d4dd6bf18

commit e61ec2a12b1144082f76f37144250a4d4dd6bf18
Author: Justin Novosad <junov@chromium.org>
Date: Fri Jul 20 15:59:21 2018

Complete the plumbing of CanvasResource through CanvasResourceDispatcher

This CL completes the the last link of plumbing allowing CanvasResource
objects of any type to be pushed all the way through to the compositor.

BUG=788439
TBR=fserb@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I08c9775b0e62e5dd7fd3a9cb73d0b6dba0e43ccc
Reviewed-on: https://chromium-review.googlesource.com/1144602
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576882}
[modify] https://crrev.com/e61ec2a12b1144082f76f37144250a4d4dd6bf18/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/e61ec2a12b1144082f76f37144250a4d4dd6bf18/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/e61ec2a12b1144082f76f37144250a4d4dd6bf18/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/e61ec2a12b1144082f76f37144250a4d4dd6bf18/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
[modify] https://crrev.com/e61ec2a12b1144082f76f37144250a4d4dd6bf18/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.h
[modify] https://crrev.com/e61ec2a12b1144082f76f37144250a4d4dd6bf18/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc
[modify] https://crrev.com/e61ec2a12b1144082f76f37144250a4d4dd6bf18/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.cc
[modify] https://crrev.com/e61ec2a12b1144082f76f37144250a4d4dd6bf18/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.h

Project Member

Comment 43 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c4bc1ff53af81b21ba55479c492e085cfd10ec2

commit 5c4bc1ff53af81b21ba55479c492e085cfd10ec2
Author: Justin Novosad <junov@chromium.org>
Date: Fri Jul 20 20:08:19 2018

Add a single buffered mode to CanvasResourceProvider

This CL completes the initial implementation of Low Latency mode for 2d
canvases

Bug: 788439
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I58fcd3fe4ab19fa10f2876f3da4f078fd4fbc2a9
Reviewed-on: https://chromium-review.googlesource.com/1145235
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576962}
[modify] https://crrev.com/5c4bc1ff53af81b21ba55479c492e085cfd10ec2/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/5c4bc1ff53af81b21ba55479c492e085cfd10ec2/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
[modify] https://crrev.com/5c4bc1ff53af81b21ba55479c492e085cfd10ec2/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/5c4bc1ff53af81b21ba55479c492e085cfd10ec2/third_party/blink/renderer/platform/graphics/canvas_resource_provider.h

Project Member

Comment 44 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56151bcd55fd802bc0c583cf9c50434e771408fa

commit 56151bcd55fd802bc0c583cf9c50434e771408fa
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Fri Jul 20 22:19:57 2018

Revert "Complete the plumbing of CanvasResource through CanvasResourceDispatcher"

This reverts commit e61ec2a12b1144082f76f37144250a4d4dd6bf18.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 576882 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U2MWVjMmExMmIxMTQ0MDgyZjc2ZjM3MTQ0MjUwYTRkNGRkNmJmMTgM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/10896

Sample Failed Step: network_service_content_browsertests

Original change's description:
> Complete the plumbing of CanvasResource through CanvasResourceDispatcher
> 
> This CL completes the the last link of plumbing allowing CanvasResource
> objects of any type to be pushed all the way through to the compositor.
> 
> BUG=788439
> TBR=fserb@chromium.org
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I08c9775b0e62e5dd7fd3a9cb73d0b6dba0e43ccc
> Reviewed-on: https://chromium-review.googlesource.com/1144602
> Commit-Queue: Justin Novosad <junov@chromium.org>
> Reviewed-by: Justin Novosad <junov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576882}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=788439
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

Change-Id: I42ef501b5c4b1e11e2de9a0524241f72f4ea54fa
Reviewed-on: https://chromium-review.googlesource.com/1145202
Cr-Commit-Position: refs/heads/master@{#577013}
[modify] https://crrev.com/56151bcd55fd802bc0c583cf9c50434e771408fa/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/56151bcd55fd802bc0c583cf9c50434e771408fa/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/56151bcd55fd802bc0c583cf9c50434e771408fa/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/56151bcd55fd802bc0c583cf9c50434e771408fa/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
[modify] https://crrev.com/56151bcd55fd802bc0c583cf9c50434e771408fa/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.h
[modify] https://crrev.com/56151bcd55fd802bc0c583cf9c50434e771408fa/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc
[modify] https://crrev.com/56151bcd55fd802bc0c583cf9c50434e771408fa/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.cc
[modify] https://crrev.com/56151bcd55fd802bc0c583cf9c50434e771408fa/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.h

Project Member

Comment 45 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aeabd72a10ef61fb282866417a2721127622762b

commit aeabd72a10ef61fb282866417a2721127622762b
Author: Timothy Loh <timloh@chromium.org>
Date: Mon Jul 23 03:49:56 2018

Revert "Add a single buffered mode to CanvasResourceProvider"

This reverts commit 5c4bc1ff53af81b21ba55479c492e085cfd10ec2.

Reason for revert: CanvasRenderingContext2DTest.LowLatencyIsSingleBuffered failing

I suppose this depended on https://chromium-review.googlesource.com/c/1144602/, which was reverted, so the test this CL adds is failing now.

Original change's description:
> Add a single buffered mode to CanvasResourceProvider
>
> This CL completes the initial implementation of Low Latency mode for 2d
> canvases
>
> Bug: 788439
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I58fcd3fe4ab19fa10f2876f3da4f078fd4fbc2a9
> Reviewed-on: https://chromium-review.googlesource.com/1145235
> Commit-Queue: Justin Novosad <junov@chromium.org>
> Reviewed-by: Fernando Serboncini <fserb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576962}

TBR=junov@chromium.org,fserb@chromium.org

NOTRY=TRUE

Bug: 788439, 866211 
Change-Id: I8e976b4cb6aca452f6d1891677e35e4411e2a5e4
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1146460
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577108}
[modify] https://crrev.com/aeabd72a10ef61fb282866417a2721127622762b/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/aeabd72a10ef61fb282866417a2721127622762b/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
[modify] https://crrev.com/aeabd72a10ef61fb282866417a2721127622762b/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/aeabd72a10ef61fb282866417a2721127622762b/third_party/blink/renderer/platform/graphics/canvas_resource_provider.h

Blockedon: 866211
Project Member

Comment 47 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d3307710cdc05749643602e27941f591c62a8e1

commit 0d3307710cdc05749643602e27941f591c62a8e1
Author: Justin Novosad <junov@chromium.org>
Date: Mon Jul 23 22:19:34 2018

Reland: Complete the plumbing of CanvasResource through CanvasResourceDispatcher

This reverts commit 56151bcd55fd802bc0c583cf9c50434e771408fa.

This reland fixes the MSAN error from the original CL by making sure the
filter_quality field of CanvasResource is always initialized

TBR=zmo@chromium.org

Bug: 788439
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7dd29f123cbfd75598005532fc5b2135e6bfebc9
Reviewed-on: https://chromium-review.googlesource.com/1147317
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577294}
[modify] https://crrev.com/0d3307710cdc05749643602e27941f591c62a8e1/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/0d3307710cdc05749643602e27941f591c62a8e1/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/0d3307710cdc05749643602e27941f591c62a8e1/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/0d3307710cdc05749643602e27941f591c62a8e1/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
[modify] https://crrev.com/0d3307710cdc05749643602e27941f591c62a8e1/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.h
[modify] https://crrev.com/0d3307710cdc05749643602e27941f591c62a8e1/third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
[modify] https://crrev.com/0d3307710cdc05749643602e27941f591c62a8e1/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc
[modify] https://crrev.com/0d3307710cdc05749643602e27941f591c62a8e1/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.cc
[modify] https://crrev.com/0d3307710cdc05749643602e27941f591c62a8e1/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.h

Project Member

Comment 48 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf161698673cefe3376f6fa68b842b8d89410d13

commit bf161698673cefe3376f6fa68b842b8d89410d13
Author: Justin Novosad <junov@chromium.org>
Date: Tue Jul 24 16:08:58 2018

Reland "Add a single buffered mode to CanvasResourceProvider"

This is a reland of 5c4bc1ff53af81b21ba55479c492e085cfd10ec2

Original change's description:
> Add a single buffered mode to CanvasResourceProvider
>
> This CL completes the initial implementation of Low Latency mode for 2d
> canvases
>
> Bug: 788439
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I58fcd3fe4ab19fa10f2876f3da4f078fd4fbc2a9
> Reviewed-on: https://chromium-review.googlesource.com/1145235
> Commit-Queue: Justin Novosad <junov@chromium.org>
> Reviewed-by: Fernando Serboncini <fserb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576962}

TBR=fserb@chromium.org

Bug: 788439
Change-Id: Ie18018ef0ebcff92beb31fcdebbc0ac2e077053e
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1147952
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577566}
[modify] https://crrev.com/bf161698673cefe3376f6fa68b842b8d89410d13/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/bf161698673cefe3376f6fa68b842b8d89410d13/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
[modify] https://crrev.com/bf161698673cefe3376f6fa68b842b8d89410d13/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/bf161698673cefe3376f6fa68b842b8d89410d13/third_party/blink/renderer/platform/graphics/canvas_resource_provider.h

Cc: -junov@chromium.org
Labels: LowLatency
Blocking: 872975
Blocking: 878545
Blocking: -878545
Blockedon: 878545
Project Member

Comment 55 by bugdroid1@chromium.org, Sep 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/711f86f62945c303ad6ffaa5dfd8621055f32ee1

commit 711f86f62945c303ad6ffaa5dfd8621055f32ee1
Author: Miguel Casas <mcasas@chromium.org>
Date: Sun Sep 23 16:01:09 2018

Canvas: Improve CanvasResourceDispatcherTest

This CL adds a new test case to CanvasResourceDispatcherTest, generating
a CompositorFrame and inspecting its contents, specially regarding its
expected opacity, size and |damage_rect|.

For that, it moves the Mock classes landed in crrev.com/c/1228859 to
one level deeper renderer/platform/graphics/test/ so it can be used
from where CanvasResourceDispatcherTest lives.  At the same time, it
extracts the hardcoded ASSERT/EXPECT out of it, to be run in the test
cases themselves and finally renames the file to mock_compositor_frame_sink
to better reflect what it does now.

This CL only touches webkit_unit_tests stuff.

Bug: 788439
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6af472f0cc6e80c17bd707f0734ad83a4688d021
Reviewed-on: https://chromium-review.googlesource.com/1238798
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593454}
[modify] https://crrev.com/711f86f62945c303ad6ffaa5dfd8621055f32ee1/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/711f86f62945c303ad6ffaa5dfd8621055f32ee1/third_party/blink/renderer/modules/canvas/htmlcanvas/html_canvas_element_module_test.cc
[modify] https://crrev.com/711f86f62945c303ad6ffaa5dfd8621055f32ee1/third_party/blink/renderer/modules/canvas/offscreencanvas/offscreen_canvas_test.cc
[delete] https://crrev.com/675fb5b9bfb23451df4406983a1fd29d0b754593/third_party/blink/renderer/modules/canvas/test/DEPS
[modify] https://crrev.com/711f86f62945c303ad6ffaa5dfd8621055f32ee1/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/711f86f62945c303ad6ffaa5dfd8621055f32ee1/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
[modify] https://crrev.com/711f86f62945c303ad6ffaa5dfd8621055f32ee1/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher_test.cc
[rename] https://crrev.com/711f86f62945c303ad6ffaa5dfd8621055f32ee1/third_party/blink/renderer/platform/graphics/test/mock_compositor_frame_sink.h

Blockedon: 895907
Blockedon: 895918
Blockedon: 897787
Blockedon: 894021
Project Member

Comment 60 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c132fc985233a4f094f0582d1564cabf1ac4660

commit 0c132fc985233a4f094f0582d1564cabf1ac4660
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Wed Dec 05 03:28:53 2018

Re-enable rebaselined forgotten pixel tests

The _NoGpuProcess tests were rebaselined in https://crrev.com/c/876523

The unaccelerated offscreen canvas tests were rebaselined in
https://crrev.com/c/1135580

Bug:  744658 , 788439
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iec28c2d23eb6c79d3edddc41766293c6d14ff0b4
Reviewed-on: https://chromium-review.googlesource.com/c/1214428
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613848}
[modify] https://crrev.com/0c132fc985233a4f094f0582d1564cabf1ac4660/content/test/gpu/gpu_tests/pixel_expectations.py

Labels: -M-67 M-73
Project Member

Comment 62 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d1557e84992428767937e98808d3bbad915e53f

commit 4d1557e84992428767937e98808d3bbad915e53f
Author: James Darpinian <jdarpinian@chromium.org>
Date: Wed Dec 19 07:17:47 2018

Roll WebGL 5b6cbd7..a2b3563

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/5b6cbd7..a2b3563

Bug: 849576,  809237 ,  911918 ,  angleproject:3012 
Bug: 913301,  912842 ,  913033 ,  563816 , 788439
Bug: angleproject:3033
Change-Id: I9b257afd69d26e75d1635633f556249583fdaa52
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1383329
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617754}
[modify] https://crrev.com/4d1557e84992428767937e98808d3bbad915e53f/DEPS
[modify] https://crrev.com/4d1557e84992428767937e98808d3bbad915e53f/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/4d1557e84992428767937e98808d3bbad915e53f/content/test/gpu/gpu_tests/webgl_conformance_revision.txt

Blockedon: 919592

Comment 64 by mcasas@chromium.org, Jan 15 (2 days ago)

Blockedon: 922218

Sign in to add a comment