New issue
Advanced search Search tips

Issue 788426 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Duplicates for password entries not removed when deleting from detail view

Project Member Reported by ioanap@chromium.org, Nov 24 2017

Issue description

Precondition:
Have two password form entries that are considered duplicates from the point of view of the sort key [1].

Note: With the current password manager saving flow, this state should not be achievable, however there are cases in which such entries were saved in the past

What steps will reproduce the problem?
(1) Launch Chrome
(2) Go to Settings > Save Passwords
(3) Tap on the displayed password entry that you want to delete (duplicated). 
(4) Delete the form.

What is the expected result?
The entry and its duplicates were removed.

View returns to Save Passwords, the entry is no longer displayed because it has been removed. Re-entering the Save Passwords page won't display the entry anymore.

What happens instead?
The selected entry was removed, but its duplicates were not.

View returns to Save Passwords, the entry is no longer displayed, however when re-entering the Save Passwords page, a duplicate of the deleted entry is displayed.

[1] https://cs.chromium.org/chromium/src/components/password_manager/core/browser/password_list_sorter.h?rcl=44906581b49621ee2d7be6ef9a3f575db4dca331&l=25

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6535adc1eeeb0047d85c6d7feb944ce603210db2

commit 6535adc1eeeb0047d85c6d7feb944ce603210db2
Author: Ioana Pandele <ioanap@chromium.org>
Date: Fri Nov 24 16:33:45 2017

Delete duplicates of a password form when deleting it from the detail view

When displaying password forms on the Save Passwords page, duplicates of an entry are not displayed,
however they must be removed when the form is deleted.

This change introduces duplicates deletion when a form is deleted from the password detail view.

Bug:  788426 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idf148b319d77e31b20bd75fa12655465f687d6ed
Reviewed-on: https://chromium-review.googlesource.com/789070
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519131}
[modify] https://crrev.com/6535adc1eeeb0047d85c6d7feb944ce603210db2/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
[modify] https://crrev.com/6535adc1eeeb0047d85c6d7feb944ce603210db2/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm

Comment 2 by ioanap@chromium.org, Nov 27 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on 64.0.3279.0 Canary on iPhone 6+ iOs 11.2 , iPad Pro iOS 11.2, iPhone 7+ iOS 10.3.3

Sign in to add a comment