Move SyzyASAN bot to chromium.win |
|||||
Issue descriptionThere appears to be very sparse, if any, coverage for the MSVC build on try bots and waterfalls. We regularly get MSVC-only breakage, usually due to differences in warning levels on signed/unsigned comparisons between MSVC and Clang. It would be helpful to have at least a couple of waterfall bots that do the full Chromium MSVC build, and/or the SyzyASAN bot could be moved to chromium.win.
,
Nov 28 2017
I'm not sure what we need, but the canonical MSVC-only build break is due to MSVC warnings on signed/unsigned comparisons. They seem to be happening all over the place too, so a full build of chromium-branded chrome.exe would be best. Essentially anything that'll catch MSVC-only regressions like https://bugs.chromium.org/p/chromium/issues/detail?id=780377#c3 https://chromium-review.googlesource.com/c/chromium/src/+/756295 https://crbug.com/788176 will do the job. Note that the official SyzyASAN build is a little bit special, as it's a full-official build with dchecks_always_on=true, so it'll fail on e.g. CHECK_EQ(<signed-entity>, <unsigned-entity>)
,
Nov 29 2017
@brucedawson, @wfh - any thoughts here?
,
Nov 29 2017
Having 32-bit coverage seems good, especially with DCHECK's enabled. What are the build times for SyzyASAN like? To clarify, this would put it on the waterfall, not the CQ, correct?
,
Nov 29 2017
I plan to change win-msvc-dbg to 32-bit, and that's moving onto the CQ. I was not planning to put SyzyASAN into the CQ (or the main waterfall), since it was never there before. win-msvc-rel should have DCHECKs enabled, so it'll catch many of the issues, but there's probably some official-only code we might miss.
,
Feb 2 2018
I don't know when I'm going to have time to clean this up properly. I think there's at least three work items here: 1) Flip win-msvc-dbg to 32-bit (renaming to win32-msvc-dbg, I suppose) on tryserver.chromium.win. 2) Rename "WinMSVC64 (dbg)" on chromium.win to win32-msvc-dbg to match. 3) Add a SyzyASAN bot to chromium.win From what I can tell, the only public SyzyASAN builder is on chromium.lkgr, and I'd assume that's being used for fuzzing and we don't want to move it. I'm not sure if it's worth it to spin up a new builder at this point. Anyone have any leanings?
,
Feb 2 2018
,
Feb 20 2018
We're close enough to shutting of MSVC that I think I'll just WontFix this. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dpranke@chromium.org
, Nov 28 2017