New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788401 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

6.3% regression in memory.top_10_mobile at 518612:518677

Project Member Reported by hjd@google.com, Nov 24 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=788401

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=5d072c5641dee895b1d91e6220e61080657a93ca6c6c39e086478bc5cf29e6d2


Bot(s) for this bug's original alert(s):

android-nexus7v2
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

Cc: machenb...@chromium.org
Owner: machenb...@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author machenbach@chromium.org ===

Hi machenbach@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Michael Achenbach
  Commit : e93cb0e2b895f5813affb1df033d36a03ab222f6
  Date   : Wed Nov 22 09:42:03 2017
  Subject: Revert "[heap] Removed keep-one-unused-page concept in sweeper."

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:private_dirty_size_avg/background/after_http_www_amazon_com_gp_aw_s_k_nexus
  Change       : 5.60% | 50672230.0 -> 53509392.6667

Revision                           Result                   N
chromium@518611                    50672230 +- 1861474      6      good
chromium@518620                    51011960 +- 1304320      6      good
chromium@518624                    50763707 +- 2049769      6      good
chromium@518626                    50603727 +- 556054       6      good
chromium@518626,v8@25a753383e      50854027 +- 1056022      6      good
chromium@518626,v8@e93cb0e2b8      53737165 +- 551093       6      bad       <--
chromium@518626,v8@ffa30ced17      53622477 +- 775822       6      bad
chromium@518627                    54205712 +- 954070       6      bad
chromium@518628                    53302099 +- 729535       6      bad
chromium@518644                    53530555 +- 948658       6      bad
chromium@518677                    53509393 +- 557321       6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.www.amazon.com.gp.aw.s.k.nexus memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8962038202870538400


For feedback, file a bug with component Speed>Bisection
Owner: hpayer@chromium.org
This was a revert. Assigning to original author.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 25 2017

Issue 788360 has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Nov 25 2017

Issue 788353 has been merged into this issue.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Nov 25 2017

Issue 788355 has been merged into this issue.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Nov 25 2017

 Issue 788362  has been merged into this issue.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Nov 26 2017

Issue 788413 has been merged into this issue.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Nov 26 2017

 Issue 788366  has been merged into this issue.
Status: WontFix (was: Assigned)

Sign in to add a comment